Skip to content

QVAC-23467 chore: drop @qvac/bare-sdk from the lockstep pipeline - #4019

Open
opaninakuffo wants to merge 3 commits into
mainfrom
chore/QVAC-23467-drop-bare-sdk
Open

QVAC-23467 chore: drop @qvac/bare-sdk from the lockstep pipeline#4019
opaninakuffo wants to merge 3 commits into
mainfrom
chore/QVAC-23467-drop-bare-sdk

Conversation

@opaninakuffo

@opaninakuffo opaninakuffo commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Stacked on #4018. Merge that first; GitHub will retarget this PR to main.

🎯 What problem does this PR solve?

  • A 0.19 cut still cannot skip @qvac/bare-sdk: publish-sdk.yml builds it, version-checks it against @qvac/inference, and blocks npm/PyPI/GitHub release on its publish jobs.
  • Lockstep tooling still treats packages/bare-sdk as a client of the inference anchor, including an import of files removed in QVAC-21751 chore[bc]: use @qvac/inference for SDK #3595.
  • The thin shim should not ship. Last npm release stays 0.18.1.

📝 How does it solve it?

  • Drop @qvac/bare-sdk from publish-sdk.yml (path filters, version lockstep, build, GPR, npm, PyPI needs, GitHub release needs).
  • Delete packages/bare-sdk and on-pr-bare-sdk-e2e.yml; remove the sdk-pod-checks.json entry.
  • Stamp qv-sdk-lockstep-sync to @qvac/sdk + tetherto-qvac-sdk only. Update C4 diagrams and agent skills/rules to match.

Do not unpublish 0.12.1–0.18.1. npm deprecate runs when 0.19 ships (message must not imply a 0.19 of this package exists). Historical changelogs and release-notes MDX are left unchanged.

🧪 How was it tested?

  • node .cursor/skills/qv-sdk-lockstep-sync/scripts/sync-sdk-pod.mjs --check — sdk at the @qvac/inference anchor.
  • node --test .github/scripts/test/ci-trust-policy.test.mjs — 71 passed, including the sdk e2e gate list after removing on-pr-bare-sdk-e2e.yml.

@opaninakuffo
opaninakuffo requested review from a team as code owners August 24, 2026 12:02
@github-actions

Copy link
Copy Markdown
Contributor

License compliance — clean

No new dependency license findings in this PR.

Warn-only (shadow) mode — this check does not block merges yet.

Updated automatically by the canonical license compliance workflow.

NOTICE presence (advisory)

Missing NOTICE (advisory, does not block):

  • ./.github/actions/release-merge-guard
  • ./docs/website
  • ./packages/ggml-coload-smoke
  • ./packages/fabric/test/integration
  • ./packages/inference-addon-cpp/mobile
  • ./packages/sdk/e2e
  • ./packages/llm-llamacpp/benchmarks/performance
  • ./packages/llm-llamacpp/benchmarks/server
  • ./packages/vla-ggml/sim/server
  • ./packages/embed-llamacpp/benchmarks/performance
  • ./packages/embed-llamacpp/benchmarks/server
  • ./packages/asr-ggml/benchmarks/server

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Workflow security (shadow mode)

zizmor found 1069 finding(s) in .github/ (highest severity: high). This check is warn-only and does not block the merge.

Findings are annotated inline on the changed files and listed in the job summary.

Reproduce locally:

pipx run zizmor==1.27.0 --offline .github/

0.19 ships inference, sdk, and python only. Stop building and publishing the discontinued package, and delete it from the repo so lockstep cannot require a 0.19 of @qvac/bare-sdk.
@opaninakuffo
opaninakuffo force-pushed the chore/QVAC-23467-drop-bare-sdk branch from 077f4c6 to 9ce968a Compare August 27, 2026 10:03
@github-actions

Copy link
Copy Markdown
Contributor

Review Status

Current Status: ❌ PENDING
Approvals so far: none

Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant