Skip to content

chore(assets): consume thaw-app/brand-assets - #823

Merged
diazdesandi merged 3 commits into
developmentfrom
chore/consume-brand-assets
Jul 27, 2026
Merged

chore(assets): consume thaw-app/brand-assets#823
diazdesandi merged 3 commits into
developmentfrom
chore/consume-brand-assets

Conversation

@diazdesandi

@diazdesandi diazdesandi commented Jul 27, 2026

Copy link
Copy Markdown
Member

Summary

Point Thaw’s marketing/packaging assets at the shared thaw-app/brand-assets repo and remove the local root Resources/ tree (headers, icons, DMG background, partner badges).

Scope: README header URLs, DMG packaging action sparse-checkout, delete root Resources/ only. App-runtime Thaw/Resources/ is untouched.

Closes: N/A

PR Type

Describe what this change does (not the linked issue’s request kind). Bug reports use bug on issues; bug fixes use fix on PRs.

If you tick Feature or Refactor and touch more than ~20 files, please mention why this can’t be split.

  • Bug fix
  • CI/CD
  • Documentation
  • Feature
  • Enhancement
  • Performance improvement
  • Refactor
  • Test addition or update
  • Other (please describe): remove duplicated brand assets from app repo

Area

Product surfaces (optional when the change is not about the app UI). Path-based labeling also applies.

  • Use PR Type for what changed (CI/CD, Documentation, Other / chore, etc.).

  • Use ops for where when it is repo operations: CI, release, GitHub hygiene, scripts, lint/sonar config — not a product surface.

  • menubar

  • icebar

  • layout

  • appearance

  • settings

  • onboarding

  • permissions

  • profiles

  • hotkeys

  • updates

  • ops

Does this PR introduce a breaking change?

  • Yes - if yes, please describe the impact and migration path
  • No

What is the new behavior?

  • README dark/light headers load from https://raw.githubusercontent.com/thaw-app/brand-assets/main/headers/thaw-*.svg
  • export-and-package sparse-checkouts packaging/dmg-background@2x.png from thaw-app/brand-assets instead of a local file
  • Root Resources/ (marketing/packaging) is deleted; Thaw/Resources/ remains for the app bundle

PR Checklist

  • I've built and run the app locally and verified that it works as expected.
  • I've run swiftformat . to keep the code style consistent.
  • I've run the smallest relevant test commands (list 1–2 below), e.g. xcodebuild test … or swift test --package-path MenuBarModel.
  • I've added tests for new behavior (if applicable).
  • I've documented new public APIs / non-obvious helpers.
  • I've updated documentation as needed.
  • This PR targets the development branch.

Test commands run:

  • (docs/CI-only change — no app code; DMG path should be verified on next release/DMG workflow run)

Known limitations / follow-ups

  • Merge after brand-assets seed is on main (done: thaw-app/brand-assets#1); badges follow-up: thaw-app/brand-assets#2
  • Experimental branch still has macOS 27 DMG background locally; when that lands, point CI at packaging/dmg-background-27@2x.png instead

Other information

Companion PRs: platform#12, raycast-extension#3.

Summary by CodeRabbit

  • Packaging

    • Updated the macOS DMG creation to use the latest branded background artwork, improving visual consistency during export and packaging.
  • Documentation

    • Refreshed README visuals (header and badges) to use updated externally hosted brand assets, ensuring the correct appearance in both light and dark modes.

Point README headers and DMG packaging at the shared brand-assets repo
and drop the local marketing Resources/ tree from Thaw.
@github-actions github-actions Bot added the ops CI, release, GitHub hygiene, scripts — repo operations, not a product surface label Jul 27, 2026
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c4d30073-10dc-4f83-befb-87c6e6d2d9b1

📥 Commits

Reviewing files that changed from the base of the PR and between e7e22ff and 5fc2010.

📒 Files selected for processing (1)
  • README.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md

📝 Walkthrough

Walkthrough

The packaging action retrieves a DMG background from the brand-assets repository. README header and badge images now reference externally hosted brand assets.

Changes

Brand asset sourcing

Layer / File(s) Summary
DMG background retrieval and packaging
.github/actions/export-and-package/action.yml
The action sparsely checks out the brand-assets repository, defines the fetched background path, and supplies it to create-dmg.
README header and badge asset references
README.md
Header and badge images now use hosted raw.githubusercontent.com URLs.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • stonerl/Thaw#730: Reorganizes README header styling and asset layout in the same README area.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the PR's main change: switching asset consumption to thaw-app/brand-assets.
Description check ✅ Passed The description follows the template and includes summary, type, area, breaking change, behavior, checklist, limitations, and other info.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/consume-brand-assets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/actions/export-and-package/action.yml (1)

24-32: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Pin shared brand assets to an immutable revision.

Both consumers follow main, so asset changes can silently alter release DMGs and README rendering. Pin the checkout and all README URLs to the same commit SHA (or a deliberately managed release tag), updating it intentionally after brand-assets#1 lands.

  • .github/actions/export-and-package/action.yml#L24-L32: add ref: <brand-assets-commit-sha> to actions/checkout.
  • README.md#L3-L5: replace /main/ with the same immutable revision.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/actions/export-and-package/action.yml around lines 24 - 32, The
shared brand-assets reference is mutable and must be pinned consistently. In
`.github/actions/export-and-package/action.yml` lines 24-32, update the
`actions/checkout` step to specify the managed immutable brand-assets revision
via `ref`; in `README.md` lines 3-5, replace `/main/` in every brand-assets URL
with that exact same revision, updating both sites together.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/actions/export-and-package/action.yml:
- Around line 24-32: The shared brand-assets reference is mutable and must be
pinned consistently. In `.github/actions/export-and-package/action.yml` lines
24-32, update the `actions/checkout` step to specify the managed immutable
brand-assets revision via `ref`; in `README.md` lines 3-5, replace `/main/` in
every brand-assets URL with that exact same revision, updating both sites
together.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6b7de5ed-1974-470c-a210-a0313b9d5275

📥 Commits

Reviewing files that changed from the base of the PR and between 39cf762 and 4fa00f9.

⛔ Files ignored due to path filters (8)
  • Resources/background@2x.png is excluded by !**/*.png
  • Resources/badges/works-with-droppy.svg is excluded by !**/*.svg
  • Resources/badges/works-with-raycast.svg is excluded by !**/*.svg
  • Resources/headers/Header_Dark.svg is excluded by !**/*.svg
  • Resources/headers/Header_Light.svg is excluded by !**/*.svg
  • Resources/icons/Icon.png is excluded by !**/*.png
  • Resources/icons/Icon.svg is excluded by !**/*.svg
  • Resources/icons/NewIcon.png is excluded by !**/*.png
📒 Files selected for processing (3)
  • .github/actions/export-and-package/action.yml
  • README.md
  • Resources/icons/Icon.fig

Root Resources/badges were removed; README still referenced local
paths so Raycast/Droppy tags rendered as bare links.
@github-actions github-actions Bot added cd Related to deployments or release automation chore Housekeeping, non-user-facing maintenance ci Related to continuous integration workflows or runners. docs Improvements or additions to documentation labels Jul 27, 2026
@diazdesandi
diazdesandi merged commit 834df5b into development Jul 27, 2026
2 checks passed
@diazdesandi
diazdesandi deleted the chore/consume-brand-assets branch July 27, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cd Related to deployments or release automation chore Housekeeping, non-user-facing maintenance ci Related to continuous integration workflows or runners. docs Improvements or additions to documentation ops CI, release, GitHub hygiene, scripts — repo operations, not a product surface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant