chore(assets): consume thaw-app/brand-assets - #823
Conversation
Point README headers and DMG packaging at the shared brand-assets repo and drop the local marketing Resources/ tree from Thaw.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe packaging action retrieves a DMG background from the ChangesBrand asset sourcing
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/actions/export-and-package/action.yml (1)
24-32: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin shared brand assets to an immutable revision.
Both consumers follow
main, so asset changes can silently alter release DMGs and README rendering. Pin the checkout and all README URLs to the same commit SHA (or a deliberately managed release tag), updating it intentionally afterbrand-assets#1lands.
.github/actions/export-and-package/action.yml#L24-L32: addref: <brand-assets-commit-sha>toactions/checkout.README.md#L3-L5: replace/main/with the same immutable revision.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/actions/export-and-package/action.yml around lines 24 - 32, The shared brand-assets reference is mutable and must be pinned consistently. In `.github/actions/export-and-package/action.yml` lines 24-32, update the `actions/checkout` step to specify the managed immutable brand-assets revision via `ref`; in `README.md` lines 3-5, replace `/main/` in every brand-assets URL with that exact same revision, updating both sites together.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/actions/export-and-package/action.yml:
- Around line 24-32: The shared brand-assets reference is mutable and must be
pinned consistently. In `.github/actions/export-and-package/action.yml` lines
24-32, update the `actions/checkout` step to specify the managed immutable
brand-assets revision via `ref`; in `README.md` lines 3-5, replace `/main/` in
every brand-assets URL with that exact same revision, updating both sites
together.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 6b7de5ed-1974-470c-a210-a0313b9d5275
⛔ Files ignored due to path filters (8)
Resources/background@2x.pngis excluded by!**/*.pngResources/badges/works-with-droppy.svgis excluded by!**/*.svgResources/badges/works-with-raycast.svgis excluded by!**/*.svgResources/headers/Header_Dark.svgis excluded by!**/*.svgResources/headers/Header_Light.svgis excluded by!**/*.svgResources/icons/Icon.pngis excluded by!**/*.pngResources/icons/Icon.svgis excluded by!**/*.svgResources/icons/NewIcon.pngis excluded by!**/*.png
📒 Files selected for processing (3)
.github/actions/export-and-package/action.ymlREADME.mdResources/icons/Icon.fig
Root Resources/badges were removed; README still referenced local paths so Raycast/Droppy tags rendered as bare links.
Summary
Point Thaw’s marketing/packaging assets at the shared
thaw-app/brand-assetsrepo and remove the local rootResources/tree (headers, icons, DMG background, partner badges).Scope: README header URLs, DMG packaging action sparse-checkout, delete root
Resources/only. App-runtimeThaw/Resources/is untouched.Closes: N/A
PR Type
Describe what this change does (not the linked issue’s request kind). Bug reports use
bugon issues; bug fixes usefixon PRs.If you tick Feature or Refactor and touch more than ~20 files, please mention why this can’t be split.
Area
Product surfaces (optional when the change is not about the app UI). Path-based labeling also applies.
Use PR Type for what changed (
CI/CD,Documentation,Other/ chore, etc.).Use
opsfor where when it is repo operations: CI, release, GitHub hygiene, scripts, lint/sonar config — not a product surface.menubar
icebar
layout
appearance
settings
onboarding
permissions
profiles
hotkeys
updates
ops
Does this PR introduce a breaking change?
What is the new behavior?
https://raw.githubusercontent.com/thaw-app/brand-assets/main/headers/thaw-*.svgexport-and-packagesparse-checkoutspackaging/dmg-background@2x.pngfromthaw-app/brand-assetsinstead of a local fileResources/(marketing/packaging) is deleted;Thaw/Resources/remains for the app bundlePR Checklist
swiftformat .to keep the code style consistent.xcodebuild test …orswift test --package-path MenuBarModel.developmentbranch.Test commands run:
Known limitations / follow-ups
main(done: thaw-app/brand-assets#1); badges follow-up: thaw-app/brand-assets#2packaging/dmg-background-27@2x.pnginsteadOther information
Companion PRs: platform#12, raycast-extension#3.
Summary by CodeRabbit
Packaging
Documentation