feat(campaign): discussion polish — open to all + likes, button/layout/dialog refinements#5978
Merged
Merged
Conversation
…nt likes - canComment relaxed to viewer.isAuthed (was: succeeded participant only); the server enforces the same rule. Drops the now-unused viewer-application query. - enable upvote (like) on discussion comments (hasUpvote), in both the inline preview and the full dialog. Downvote stays off. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ne submit, i18n) - comment content: collapse campaign-discussion comments to 2 lines with a proper 展開/收回 toggle (was 4 lines, expand-only) — campaignDiscussion only - discussion preview: cap height (20rem) so a busy thread scrolls instead of pushing the participants list down the rail - comment form: add an `inlineFooter` variant that places the submit inside the editor box; the campaign discussion uses it (circles unaffected) - i18n: fill the zh-Hant / zh-Hans translations for the discussion + quote-wall strings that were still showing the English defaults Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…de scrollbars - the campaign-discussion comment upvote now renders a heart (like) icon instead of the circle up-vote arrow (gated to campaignDiscussion only) - shrink campaign-discussion comment text to 14px (was 15) - hide the preview scrollbars and clip horizontal overflow so the comment list scrolls cleanly without visible bars Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Drop the per-comment collapse: campaign-discussion comments now clamp to 2 lines then expand-only (like article comments), via the rich expand path. This also fixes the font mismatch between the clamped and expanded states (the previous non-rich Truncate path rendered them at different sizes). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Pass the comment size down to Expandable so the rich "展開" button renders at 14px (the campaign-discussion comment size) instead of the larger default. Gated to campaignDiscussion; other comment types unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Both are right-rail section titles at the same level, so bump 討論區 from 16px to 20px to match 參與者 (SideParticipants). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replace the green-box chip (with 💬 and chevron) with a Secondary outlined pill that mirrors the Apply button's outlined state, so the discussion entry reads one clear level below the apply button. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ghten spacing - remove the duplicate mobile participants chip (the avatar row inside InfoHeader already shows them) - reduce the cover→title gap on mobile (sp24 → sp12; desktop keeps sp24) - add spacing above the mobile discussion entry button so it no longer crowds the apply button above it Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The default Dialog is `small` (375px / fixedWidth), which crams avatars
and threaded comments. Switch the discussion dialog to fixedWidth={false}
and constrain its body to 480px on sm-up — the design-system dialog spec's
`medium` size. Below sm it remains a full-width bottom sheet.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ants The discussion module and the participants section shared near-identical titles with only a small gap, blurring the seam between two distinct aside fields. Drop the existing HorizontalRule (dashed) between them on desktop, with symmetric 16px breathing room above (discussion padding) and below (participants margin-top). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ators The HorizontalRule used --color-line-grey-light (8% black), noticeably lighter than the article list's dashed #ddd separators. Replace it with a dashed top border on the participants section using the same border-top-grey-light (#ddd) mixin the List uses, so both rules match. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
yingshinlee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
活動討論區整備上線（搭配 server#4859「開放登入者留言」已上 ICU）。base =
develop。功能
canComment = viewer.isAuthed，前後端一致）＋ 留言點讚（hasUpvote，圖示用既有留言區的愛心IconLike/IconLikeFill，非三角形）max-height捲動、隱藏捲軸，不擠壓下方參與者UI / 排版打磨
Apply/Button）外框狀態用同組 props；移除 💬 與›small(375px) → design-system dialogmedium(480px)，≤sm仍為全寬底部抽屜border-top-grey-light=#ddddashed）CircleCommentForm新增inlineFooter變體，圍爐眾聊不受影響）i18n
lang/*.json進版，compiled-lang由 build 時npm run i18n生成依賴
測試狀態
build、unit、Vercel 皆 pass；本機tsc --noEmit綠next dev不 render（ssr:false+ fresnel 的 dev 怪癖，與本 PR 無關），請一律在此 PR 的 Vercel preview 上驗收