CI overhaul (4/9): excise the screenshot-feedback apparatus and slim the retry shells #68

Activity

1. thiagobrez

   added

   ready-for-agentFully specified, ready for an AFK agentFully specified, ready for an AFK agent

   on Sep 3, 2026
2. thiagobrez

   marked this as blocked by 2 issues on Sep 3, 2026

   • CI overhaul (2/9): delete the YAML-regex change-detector tests, keep the script-execution tests #66
   • CI overhaul (3/9): add the RNTL drag render-path backstop #67
3. thiagobrez

   marked this as blocking 2 issues on Sep 3, 2026

   • CI overhaul (7/9): make the exact package candidate the sole push-to-main gate #74
   • CI overhaul (9/9): purge the agent-device runner-artifact cache before retry attempts #76
4. thiagobrez

   added a commit that references this issue on Sep 4, 2026

   ci: excise the screenshot-feedback apparatus

   ...

   c6331e5
5. thiagobrez commented on Sep 4, 2026

   

   thiagobrez

   on Sep 4, 2026

   OwnerAuthor

   More actions

   Pulled forward into PR #87 (commit c6331e5), out of order and ahead of #66/#67, because of a gate deadlock discovered on that PR's first CI run:

   • CI overhaul (1/9): route iOS 26 device-contract pointer scenarios through Detox #65's Detox routing made all five iOS 26 pointer scenarios pass, but the job then failed inside this apparatus (drag released before feedback sampling) — and that assertion masked the real error: the drags held their destination for 8000ms, well past the ~4.9s sampling window, so the assert could only fire when the Detox gesture promise settled early, with the underlying rejection swallowed by the .catch.
   • Approve exact tarball for publication workflow is a required check on main and gates on contract + feedback + parity. While iOS 26 was red, nothing could merge — including this ticket's own PR. Deleting the apparatus in the same PR was the only unblocking path.

   Deviations from the plan's ordering, for the record:

   • CI overhaul (2/9): delete the YAML-regex change-detector tests, keep the script-execution tests #66 did not need to ride along — the workflow edits (deleting the feedback job and its approve-candidate edge) tripped none of the eight YAML change-detector tests, so ci-fixtures.test.mjs is untouched and CI overhaul (2/9): delete the YAML-regex change-detector tests, keep the script-execution tests #66 remains as specified.
   • CI overhaul (3/9): add the RNTL drag render-path backstop #67 lands after, not before — the compensating RNTL render-path backstop is the immediate follow-up PR. Until it merges, the broken-render-wiring regression class is covered only by Detox per-test videos, the dogfooding-caught risk class ADR 0006's 2026-09-01 amendment already accepted.

   Acceptance criteria status: the grep (grep -ri "feedback\|ISSUE39_FEEDBACK" scripts/ e2e/ .github/) returns nothing; the exit-75 retry chain and its infra/contract classification are untouched (release-policy and ci-fixtures suites pass); the retained criteria — candidate passing on main with approve-candidate gating on surviving jobs, and measurably faster device jobs (the five drags drop their 8000ms hold for the 2000ms default) — are verifiable once PR #87 merges.
6. thiagobrez commented on Sep 5, 2026

   

   thiagobrez

   on Sep 5, 2026

   OwnerAuthor

   More actions

   All acceptance criteria are now met — closing.

   • Excision grep: grep -ri "feedback\|ISSUE39_FEEDBACK" scripts/ e2e/ .github/ returns nothing (verified at merge of PR ci: route iOS 26 pointer scenarios through Detox and excise the screenshot-feedback apparatus #87, commit c6331e5).
   • Candidate passes on main with approve-candidate gating only on surviving jobs: three consecutive green runs — 33951437527 (push 9a2bcbb), 33953330578 (nightly 9a2bcbb), 33962748103 (push 9a50e91), all 2026-09-05.
   • Device jobs measurably faster: the ios26.auto-fallback job ran 35m11s on PR ci: route iOS 26 pointer scenarios through Detox and excise the screenshot-feedback apparatus #87's first run with the sampling apparatus; the two green push runs completed it in ~26m and ~20m, single attempt.
   • Exit-75 retry chain intact: contract-vs-infrastructure classification untouched (release-policy and consumer-script suites green); the run on e15ad0a (33912402913) exercised the whole-job retry path exactly as before.

   Delivered ahead of plan order inside PR #87 (see the earlier comment for why the gate deadlock forced the pull-forward). The feedback job, Vision OCR analyzer, verifier, specs, fixtures, mid-hold sampling in both pointer runners, the mtime-poll IPC, and the sampling timing constants are all gone; Detox per-test video/screenshot recording remains the human-reviewable record.
7. thiagobrez

   closed this as completedon Sep 5, 2026