ci: delete the physical-performance workflow and manual device-verification scripts - #94
Merged
Merged
Conversation
…cation scripts (#75) Physical-device performance validation is cut from the lifecycle (#57, the accepted performance proof. Removes the workflow, the collector and verifier scripts, the named-scenario/FlashList/Legend List device verifiers, their package.json script entries, the example README device-verification section, and the tests that exercised them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
thiagobrez
force-pushed
the
ci/issue-75-remove-physical-performance
branch
from
September 5, 2026 19:36
828f1c0 to
7f5bac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75. Part of the CI overhaul execution plan (#59, map #53), order 8 of 9.
Physical-device performance validation is cut from the lifecycle entirely (decision in #57; #45 closed as not planned): Reassure render gates plus geometry benchmarks on hosted CI are the accepted performance proof.
Changes
.github/workflows/physical-performance.yml.scripts/collect-physical-performance.mjs,scripts/verify-physical-performance.mjs,scripts/verify-named-scenario-device.mjs,scripts/verify-flash-list-device.mjs,scripts/verify-legend-list-device.mjs.package.json: removeverify:flash-deviceandverify:legend-device, plusperformance:physical:collect/performance:physical:verify(they invoked the deleted scripts; keeping them would fail the acceptance grep). The clean-package consumersverify:flash-package/verify:legend-packageare kept.example/README.md: remove the manual device-verification section.src/__tests__/issue40-performance-gates.test.ts(Reassure gates stay), the device-automation assertion inexample/src/__tests__/scenario-catalog.test.ts, and the physical-performance workflow entry inscripts/__tests__/ci-fixtures.test.mjs.yarn verify:flash-device/yarn verify:legend-devicementions in the historicalartifacts/issue-36|37/README.mdevidence as past-tense/removed..gitignoreentry for localartifacts/issue-40/evidence (kept ignored — local evidence still exists on dev machines).package.jsonis a release surface, but no published-package behavior changes.Acceptance
grep -rn "physical-performance\|verify-named-scenario\|flash-list-device\|legend-list-device"is clean (excluding node_modules/lib).yarn testgreen (28 suites, 286 tests),yarn test:releasegreen,yarn lintandyarn typecheckclean.🤖 Generated with Claude Code