Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/remove-physical-performance-pipeline.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
---

Delete the physical performance CI workflow and the manual device
verification scripts (issue #75). No published-package behavior changes:
only repository tooling entries were removed from `package.json`
`scripts`.
141 changes: 0 additions & 141 deletions .github/workflows/physical-performance.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ artifacts/issue-39/detox/
artifacts/issue-39/feedback/
artifacts/issue-39/outcomes-by-case/

# Issue 40 physical performance jobs (uploaded by CI, not committed)
# Local physical performance evidence (issue 40, pipeline removed in #75)
artifacts/issue-40/

# Exact release candidate generated and uploaded by CI
Expand Down
5 changes: 3 additions & 2 deletions artifacts/issue-36/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ Validated against fresh debug builds with `@shopify/flash-list@2.3.2` on:
- iOS 26.5 (23F77), iPhone 17 Pro, Auto policy's runtime fallback; and
- Android, Pixel 10 Pro emulator, Auto policy.

The reusable gate is `yarn verify:flash-device --platform <ios|android>
--device <name> --engine <auto|fallback> --session <name>`. Its four successful
The reusable gate at the time was `yarn verify:flash-device --platform
<ios|android> --device <name> --engine <auto|fallback> --session <name>`
(removed with the manual device gates in #75). Its four successful
runs and screenshots are under `matrix/`. It asserts provider windowing,
selected multi-row reorder, edge auto-scroll into an initially off-window
destination, section rendering, and in-flight cancellation by disabling three
Expand Down
5 changes: 3 additions & 2 deletions artifacts/issue-37/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ Validated against `@legendapp/list@3.3.3` and the exact issue 37 source on:
- iOS 26.5 (23F77), iPhone 17 Pro, Auto policy's runtime fallback; and
- Android, Pixel 10 Pro emulator, Auto policy.

The reusable gate is `yarn verify:legend-device --platform <ios|android>
--device <name> --engine <auto|fallback> --session <name>`. Its four successful
The reusable gate at the time was `yarn verify:legend-device --platform
<ios|android> --device <name> --engine <auto|fallback> --session <name>`
(removed with the manual device gates in #75). Its four successful
runs and screenshots are under `matrix/`. It asserts provider windowing,
selected multi-row reorder, edge auto-scroll into an initially off-window
destination, provider-native section rendering, empty start/end sections, the
Expand Down
17 changes: 0 additions & 17 deletions example/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,20 +46,3 @@ reorderable://integrations/flash-section-list?preset=focused&engine=auto
Examples and Integrations always normalize the engine to Auto. Scenario Lab
remounts the selected scenario when its policy changes so each run begins from
a deterministic state.

## Device verification

The shared verifier navigates through visible app controls and targets a named
scenario:

```sh
node scripts/verify-named-scenario-device.mjs \
--platform ios \
--device "iPhone 17 Pro" \
--scenario selection \
--engine fallback \
--artifacts artifacts/issue-38/selection-ios
```

The FlashList and Legend List package scripts delegate to this same named
scenario verifier rather than maintaining hidden automation surfaces.
11 changes: 0 additions & 11 deletions example/src/__tests__/scenario-catalog.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import { describe, expect, it } from '@jest/globals';
import { readFileSync } from 'node:fs';
import { resolve } from 'node:path';
import {
AREAS,
LAB_SCENARIOS,
Expand Down Expand Up @@ -105,13 +103,4 @@ describe('example application scenario catalog', () => {
).toBeNull();
expect(parseExampleLink('not a link')).toBeNull();
});

it('keeps device automation on an app-owned visible activation target', () => {
const verifier = readFileSync(
resolve(process.cwd(), 'scripts/verify-named-scenario-device.mjs'),
'utf8'
);
expect(verifier).toContain('id="row-autoscroll-10"');
expect(verifier).not.toMatch(/reorderable-(?:list|section-list)-wrapper-/);
});
});
4 changes: 0 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,8 @@
"performance:reassure": "reassure --testMatch '**/src/__perf__/issue34.perf-test.tsx' '**/src/__perf__/issue35.perf-test.tsx' '**/src/__perf__/issue40.perf-test.tsx'",
"performance:reassure:baseline": "reassure --baseline --testMatch '**/src/__perf__/issue34.perf-test.tsx' '**/src/__perf__/issue35.perf-test.tsx' '**/src/__perf__/issue40.perf-test.tsx'",
"performance:reassure:verify": "node scripts/verify-reassure-output.mjs",
"performance:physical:collect": "node scripts/collect-physical-performance.mjs",
"performance:physical:verify": "node scripts/verify-physical-performance.mjs",
"verify:flash-device": "node scripts/verify-flash-list-device.mjs",
"verify:flash-package": "node scripts/verify-flash-list-package.mjs",
"verify:legend-package": "node scripts/verify-legend-list-package.mjs",
"verify:legend-device": "node scripts/verify-legend-list-device.mjs",
"pack:candidate": "node scripts/pack-candidate.mjs",
"verify:candidate": "node scripts/verify-package-artifact.mjs artifacts/candidate/react-native-reorderable.tgz",
"docs:api": "node scripts/generate-api-docs.mjs",
Expand Down
Loading
Loading