SHREK-362: switch from semaphore to gha - #13
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the CI/CD pipeline from Semaphore to GitHub Actions. The change removes the Semaphore configuration and replaces it with a GitHub Actions workflow that runs the same test suite and linting checks.
Key changes:
- Removed
.semaphore/semaphore.ymlcontaining the Semaphore CI configuration - Added
.github/workflows/checks.ymlwith a GitHub Actions workflow - Switched from parallel job execution to sequential execution of tests and linting
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.semaphore/semaphore.yml |
Removed Semaphore CI configuration that ran parallel RSpec and Rubocop jobs |
.github/workflows/checks.yml |
Added GitHub Actions workflow to run tests and linting on Ruby 2.6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dceccfa to
fb0e32a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fb0e32a to
484c1bd
Compare
484c1bd to
f044b9d
Compare
|
|
||
| jobs: | ||
| checks: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
@seanvm @joseasouza I'm using one of GitHub's runners because we can't use our own self-hosted runners in public repositories due to security concerns. No a problem though, ubuntu-latest is free. Speaking of which, do we need this repo to be public, and what would the consequences of making it private be?
There was a problem hiding this comment.
I think it needs to public so bundle can pull the gem directly from the repo?
Another option would be to publish a version of this to a private gem repo
Ticket
Just closing off a ticket in our backlog. This switches the gem to use gha instead of semaphore for CICD. It should basically be a direct copy of the process Semaphore carries out as far as I can tell. This project is rarely updated, but I figured it was a good idea to get this small change out in case we have to make future changes.