Skip to content

SHREK-362: switch from semaphore to gha #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanNielson merged 1 commit into from
Jan 9, 2026
Merged

SHREK-362: switch from semaphore to gha #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: Checks

on:
push:
branches: [master]
pull_request:

Comment thread
RyanNielson marked this conversation as resolved.
jobs:
checks:
runs-on: ubuntu-latest

@RyanNielson RyanNielson Jan 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanvm @joseasouza I'm using one of GitHub's runners because we can't use our own self-hosted runners in public repositories due to security concerns. No a problem though, ubuntu-latest is free. Speaking of which, do we need this repo to be public, and what would the consequences of making it private be?

@joseasouza joseasouza Jan 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs to public so bundle can pull the gem directly from the repo?
Another option would be to publish a version of this to a private gem repo

strategy:
matrix:
command: [rake, rubocop]
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: '2.6'
Comment thread
RyanNielson marked this conversation as resolved.
bundler-cache: true
- run: bundle exec ${{ matrix.command }}
26 changes: 0 additions & 26 deletions .semaphore/semaphore.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion cloud_secret_env.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Gem::Specification.new do |spec|

spec.add_development_dependency 'bundler', '~> 1.17'
spec.add_development_dependency 'pry', '~> 0.10'
spec.add_development_dependency 'rake', '~> 12.3.3'
spec.add_development_dependency 'rake', '~> 12.3.3'
spec.add_development_dependency 'rspec', '~> 3.0'
spec.add_development_dependency 'rubocop', '0.71'
spec.add_runtime_dependency 'aws-sdk-core', '~> 3'
Expand Down