Repository navigation
Guard deploy.py behind __main__; test that import has no side effects - #4
Merged
Merged
Conversation
…e effects Fixes #3 Claude-Session: https://claude.ai/code/session_01BgadceR6ocdAzYbAQpcztz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3.
deploy.pyran a build andtwine uploadat module level, so anything that imported it (pytest --doctest-modulesfrom the repo root, a dependents gate) uploaded to PyPI. It now exposesmain()behindif __name__ == "__main__":and usessys.executable.tests/test_deploy_import.pyimports the file withsubprocess.run/Popenpatched and asserts nothing is called.Adversarial review (fresh Opus subagent): SHIP, no confirmed defects. Noted non-blocking: the test only watches subprocess calls, and grub has no
setup.py, so the script cannot work at all (follow-up issue filed).https://claude.ai/code/session_01BgadceR6ocdAzYbAQpcztz