Skip to content

Fix umap tests#271

Merged
EmilHvitfeldt merged 4 commits intomainfrom
fix-umap-tests
Jan 29, 2026
Merged

Fix umap tests#271
EmilHvitfeldt merged 4 commits intomainfrom
fix-umap-tests

Conversation

@EmilHvitfeldt
Copy link
Member

to close #270

@bwlewis
Copy link

bwlewis commented Jan 29, 2026

I checked out pr-271 to produce embed_1.2.1.9000.tar.gz, Unfortunately I still see the problem:

══ Failed tests 
── Error ('test-umap.R:435:3'): keep_original_cols - can prep recipes with it missing ──
<recipes_error_step/recipes_error/rlang_error/error/condition>
Error in `step_umap()`: Error in `step_umap()`:
Caused by error in `uwot()`:
! 'n_components' must be a positive integer
Backtrace:
     ▆
  1. ├─recipes::prep(rec)
  2. ├─recipes:::prep.recipe(rec)
  3. │ ├─recipes:::recipes_error_context(...)
  4. │ │ ├─base::withCallingHandlers(...)
  5. │ │ └─base::force(expr)
  6. │ ├─recipes::prep(x$steps[[i]], training = training, info = x$term_info)
  7. │ └─embed:::prep.step_umap(x$steps[[i]], training = training, info = x$term_info)
  8. │   ├─withr::with_seed(...)
  9. │   │ └─withr::with_preserve_seed(...)
 10. │   └─rlang::eval_tidy(umap_fit_call(x, y = y_name))
 11. ├─uwot::umap(...)
 12. │ └─uwot:::uwot(...)
 13. │   └─base::stop("'n_components' must be a positive integer")

If you want to try, you can check out and install irlba 2.3.7 from https://github.com/bwlewis/irlba.git -- you should be able to reproduce the error.

Let me know how I can help if you need more testing. I don't quite understand the code right now but am happy to look in to this more if you need assistance.

@EmilHvitfeldt
Copy link
Member Author

It should be fixed now, I will. submit a patch release later today

@EmilHvitfeldt EmilHvitfeldt merged commit 92b4d7f into main Jan 29, 2026
2 of 12 checks passed
@EmilHvitfeldt EmilHvitfeldt deleted the fix-umap-tests branch January 29, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_umap test_that("backwards compatible for initial and target_weight args (#213)" failure with new irlba version

2 participants