Doctor skill: track schema_version 3, quote the gh issue title, list ~/.grok - #262
Merged
londondavila merged 5 commits intoAug 26, 2026
Merged
Conversation
The doctor skill still described `schema_version` 1 and 2 and bailed above 2, but the CLI has emitted 3 since 0.22.0 and the skill pins `@tiny-fish/cli@latest` — as shipped it degraded to `--pretty` on every run. Same three defects were fixed in tinyfish-web-agent-integrations#29; this keeps the two copies identical. - doctor skill: `schema_version` 3 — `cli_version`, `ok_harnesses`/`ok_cli`, `checks[].scope`, `repairs[].action`, exit code from the harness scope alone (`ok_cli: false` beside exit 0 is real). Drops the removed `API key present but unverified` string; `--fix` examples go through `npx`. - feedback skill: `--title "$title"` alongside `--body-file "$body_file"` — the summary is user text too. Bans `eval` and constructed command strings. - plugins/tinyfish/README.md: adds `~/.grok` to the config dirs doctor reads, per the CLI's `CONFIG_DIRS`. - 1.2.3 → 1.2.4 in plugin.json and the marketplace entry, which CI requires to match. Edits are in `skills-src/`; the plugin and generic SKILL.md files are the generator's output. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
The README in this PR says doctor reads `~/.grok`, but the generator's generic target still enumerated the harnesses without it — so a Grok-run agent read "no entry describes you" for an entry doctor does emit, and found no re-auth row for its own harness. - `HARNESS_ENTRY`: grok in the known-harness list - `GENERIC_REAUTH`: grok row — TUI sign-in, and the keyed path's env var, which has no OAuth fallback - doctor skill: the Cursor `unattended_safe` caveat holds on `3` too, not just `2` Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
… telemetry note Self-review against CLI 0.32.0. `proves_harness_reach` is true whenever the harness's own client reports a live connection — Claude Code on OAuth included — so "always false for OAuth harnesses" and "presence only for auth_mode unknown" both told the agent to discard real wire evidence. doctor also sends telemetry on every run now, not only when a repair runs. - doctor skill: reach and `registration: pass` described by `proves_harness_reach` rather than by auth mode - doctor skill: `repairs[].command` arrives as bare `tinyfish …`, which is not on PATH under npx — say to prefix it - feedback skill: title goes to a file like the body; a `title=…` assignment evaluates backticks just as the command line does - README: doctor reports every run, and diagnosis makes authenticated calls Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
KateZhang98
approved these changes
Aug 26, 2026
londondavila
deleted the
london/cookbook-doctor-schema-3-and-gh-title-quoting
branch
August 26, 2026 21:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doctor still described
schema_version1 and 2 + bailed above 2, but CLI emitted 3 since 0.22.0 and skill pins@tiny-fish/cli@latest. as shipped it degraded to--prettyon every run. The feedback skill also passed an unquoted, user-derived title togh issue create. three fixes landed in tinyfish-web-agent-integrations#29; keeps 2 copies of plugin identicaldoctor: schema 3 —cli_version,ok_harnesses/ok_cli,checks[].scope,repairs[].action, and the exit code coming from the harness scope alone, sook_cli: falsebeside exit0is a real state. Drops theregistered, API key present but unverifiedstring the CLI no longer emits;--fixexamples run throughnpxlike step 1.feedback:--title "$title" --body-file "$body_file", injection warning widened to the title, andeval/ constructed command strings prohibited.plugins/tinyfish/README.md: adds~/.grokto the config dirs doctor reads, per the CLI'sCONFIG_DIRS. The rest of that list matches.plugin.jsonand the marketplace entry —validate-skills.mjsfails if they diverge