PTECH-34241: update workflow for macOS 15 runner#139
Merged
Conversation
Xcode 16 enforces stricter code signing validation, causing CI to fail with "No signing certificate Mac Development found" even for simulator test builds. Override signing settings via xcargs in Fastlane scan calls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Dimentar
force-pushed
the
feature/PTECH-34241-fix-ci-xcode-16
branch
from
b363f8d to
4c68517
Compare
DoddaSrinivasan
previously approved these changes
Mar 13, 2026
Dimentar
changed the title
auto-merge was automatically disabled
March 31, 2026 15:15
Pull request was closed
Contributor
Author
|
An empty commit was pushed to refresh the PR state (blocked by Could a code owner please re-approve so this can be merged? 🙏 |
- Add SonarCloud scan step after unit tests in unittests.yml - Add sonar-project.properties with project key traderepublic_SectionKit
- SonarQube requirement removed at org level
DoddaSrinivasan
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://traderepublic.atlassian.net/browse/PTECH-34241
Context
CI is broken on all PRs because
macOS-latestnow maps to macOS 15 (since Sep 2025), which only ships with Xcode 16.x. The workflow still referencesXcode_15.4.app, which doesn't exist on the runner:Changes
Workflow (
.github/workflows/unittests.yml)macos-15instead ofmacOS-latestto prevent future breakage when GitHub rolls the label forwardDEVELOPER_DIRtoXcode_16.4.app— the default and most stable Xcode on the macOS 15 imageactions/checkoutfrom v2 to v4 — v2 uses a deprecated Node.js runtimeCode signing (
fastlane/Fastfile)No signing certificate "Mac Development" foundeven for simulator-only test runs. Addedxcargsoverrides (CODE_SIGN_IDENTITY,CODE_SIGNING_REQUIRED,CODE_SIGNING_ALLOWED) to bothscancallsTest fix (
SectionKit/Tests/)UICollectionViewApplyTestsfor iOS 18+ —UIWindow()without aUIWindowSceneno longer attaches views to the window hierarchy, socollectionView.windowreturnsniland batch update tests take the wrong code path. Added overridable_windowproperty toMockCollectionViewinstead of relying on real window attachmentCODEOWNERS
@traderepublic/atom-mobile-platform-iosAcceptance Criteria
shouldAnimateItemsin diffing section controllers #138 also passesTesting Steps
shouldAnimateItemsin diffing section controllers #138) to confirm it picks up the fix