Skip to content

PTECH-34241: update workflow for macOS 15 runner #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dimentar merged 8 commits into from
Apr 7, 2026
Merged

PTECH-34241: update workflow for macOS 15 runner #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
78b437a
Fixed unittest workflow
Dimentar Mar 13, 2026
aace24f
Disable code signing in CI test builds
Dimentar Mar 13, 2026
4a09ade
Change codeowners to atom-mobile-platform-ios
Dimentar Mar 13, 2026
9cd486e
Fixed UICollectionViewApplyTests
Dimentar Mar 13, 2026
4c68517
SUPPORTS_MACCATALYST=NO
Dimentar Mar 13, 2026
65b1f6e
Refresh PR state for merge approval
Dimentar Apr 2, 2026
dce3d56
Add SonarCloud scan to CI workflow
Dimentar Apr 2, 2026
d0bcaec
Remove SonarCloud scan step
Dimentar Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
# Auto-generated on 2025-08-13 from topics: element-lifecycle
# Full-repo ownership:
* @traderepublic/element-lifecycle
* @traderepublic/atom-mobile-platform-ios
6 changes: 3 additions & 3 deletions .github/workflows/unittests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ on:
jobs:
build:
name: Unit Tests
runs-on: macOS-latest
runs-on: macos-15
if: github.event.pull_request.draft == false
env:
LC_ALL: en_US.UTF-8
LANG: en_US.UTF-8
DEVELOPER_DIR: '/Applications/Xcode_15.4.app/Contents/Developer'
DEVELOPER_DIR: '/Applications/Xcode_16.4.app/Contents/Developer'
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 100

Expand Down
8 changes: 8 additions & 0 deletions SectionKit/Tests/TestUtilities/MockCollectionView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@ import UIKit
import XCTest

internal final class MockCollectionView: UICollectionView {
// MARK: - window

internal var _window: UIWindow?

override var window: UIWindow? {
_window ?? super.window
}

// MARK: - reloadData

internal typealias ReloadDataBlock = () -> Void
Expand Down
12 changes: 4 additions & 8 deletions SectionKit/Tests/Utility/UICollectionViewApplyTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,7 @@ final class UICollectionViewApplyTests: XCTestCase {
reloadSectionsExpectation.fulfill()
}

let window = UIWindow()
window.addSubview(collectionView)
collectionView._window = UIWindow()

let update = CollectionViewSectionUpdate<String>(
controller: BaseSectionController(),
Expand Down Expand Up @@ -226,8 +225,7 @@ final class UICollectionViewApplyTests: XCTestCase {
reloadItemsExpectation.fulfill()
}

let window = UIWindow()
window.addSubview(collectionView)
collectionView._window = UIWindow()

let update = CollectionViewSectionUpdate<String>(
controller: BaseSectionController(),
Expand Down Expand Up @@ -379,8 +377,7 @@ final class UICollectionViewApplyTests: XCTestCase {
}
collectionView._reloadData = reloadDataExpectation.fulfill

let window = UIWindow()
window.addSubview(collectionView)
collectionView._window = UIWindow()

let update = CollectionViewUpdate<String>(
batchOperations: [
Expand Down Expand Up @@ -451,8 +448,7 @@ final class UICollectionViewApplyTests: XCTestCase {
reloadSectionsExpectation.fulfill()
}

let window = UIWindow()
window.addSubview(collectionView)
collectionView._window = UIWindow()

let update = CollectionViewUpdate<String>(
batchOperations: [
Expand Down
8 changes: 6 additions & 2 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@ ENV["FASTLANE_XCODEBUILD_SETTINGS_TIMEOUT"] = "10"

lane :unittest do
scan(
scheme: "SectionKit"
scheme: "SectionKit",
device: "iPhone 16",
xcargs: "CODE_SIGN_IDENTITY='' CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO"
)
scan(
scheme: "DiffingSectionKit"
scheme: "DiffingSectionKit",
device: "iPhone 16",
xcargs: "CODE_SIGN_IDENTITY='' CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO"
)
end
Loading