Repository navigation
refactor(go)!: short generated names; build the OpenAPI spec on the fly (XWING-2233) - #39
Merged
smith-xyz merged 1 commit intoOct 29, 2026
Conversation
… the spec on the fly
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smith-xyz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
v1/apifrom core with short operation ids (refactor(rest): operation ids are the route names (XWING-2233) traust-core#288):OnboardV1OnboardingPostWithResponse→OnboardWithResponse,ListProductsV1ProductsGetParams→ListProductsParams. Call sites inv1/api/client.go,v1/ops/record.go,v1/ops/recording.goandgo/README.mdrenamed.make api-generatebuilds core's OpenAPI at a pinnedCORE_REF(cached checkout, same pattern asCONTRACTS_REF), normalizes it in a temp dir, generatesclient.gen.go, deletes the spec.internal/generate/openapi/openapi.json,openapi-3.0.json(~400 KB, rewritten on every regen) and the snapshot-statusREADME.md.check-driftdiffs only the generated Go.Stacked
CORE_REFpins traust-core#288's commit1a6779a. Merge #288 first; re-pin to its merge commit if it changes.Also picked up
Core
developmentsince the last snapshot addsPrecedentReason.basis,.hashes,.unavailable_reason(+CodeHash,HashUnavailable,PrecedentBasis). Additive.Breaking
Every generated method/params/response name. Consumers rename by deleting the
V1…Get/V1…Postmiddle. #38 (onboarding regen) conflicts on the deleted spec files; after this lands it's a re-pin +make api-generate.Changed tests
None.
Checks
make lint,make test,make securitymake -C go check-driftclean