Skip to content

fix: Reject Triton reserved keys in parameters #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yinggeh merged 2 commits into from
May 5, 2026
Merged

fix: Reject Triton reserved keys in parameters #894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8cff99
security: Expand reserved parameter validation to full set (TRI-854)
yinggeh May 4, 2026
3524ed9
Update
yinggeh May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/python/library/tritonclient/grpc/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env python3

# Copyright 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# Copyright 2023-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -116,12 +116,8 @@ def _get_inference_request(

if parameters:
for key, value in parameters.items():
if (
key == "sequence_id"
or key == "sequence_start"
or key == "sequence_end"
or key == "priority"
or key == "binary_data_output"
if key in TRITON_RESERVED_REQUEST_PARAMS or key.startswith(
TRITON_RESERVED_REQUEST_PARAMS_PREFIX
):
raise_error(
f'Parameter "{key}" is a reserved parameter and cannot be specified.'
Expand Down
15 changes: 8 additions & 7 deletions src/python/library/tritonclient/http/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,12 @@
from urllib.parse import quote_plus

import rapidjson as json
from tritonclient.utils import InferenceServerException, raise_error
from tritonclient.utils import (
TRITON_RESERVED_REQUEST_PARAMS,
TRITON_RESERVED_REQUEST_PARAMS_PREFIX,
InferenceServerException,
raise_error,
)


def _get_error(response):
Expand Down Expand Up @@ -118,12 +123,8 @@ def _get_inference_request(

if custom_parameters:
for key, value in custom_parameters.items():
if (
key == "sequence_id"
or key == "sequence_start"
or key == "sequence_end"
or key == "priority"
or key == "binary_data_output"
if key in TRITON_RESERVED_REQUEST_PARAMS or key.startswith(
TRITON_RESERVED_REQUEST_PARAMS_PREFIX
):
raise_error(
f'Parameter "{key}" is a reserved parameter and cannot be specified.'
Expand Down
17 changes: 16 additions & 1 deletion src/python/library/tritonclient/utils/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env python3

# Copyright 2020-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# Copyright 2020-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -32,6 +32,21 @@

from ._shared_memory_tensor import SharedMemoryTensor

# Reserved request parameters for Triton's usage.
# Other locations:
# - server/src/common.h
# - server/docs/protocol/extension_parameters.md
TRITON_RESERVED_REQUEST_PARAMS = [
"sequence_id",
"sequence_start",
"sequence_end",
"priority",
"timeout",
"headers",
"binary_data_output",
]
TRITON_RESERVED_REQUEST_PARAMS_PREFIX = "triton_"


def raise_error(msg):
"""
Expand Down
Loading