Skip to content

fix: Reject Triton reserved keys in parameters#894

Merged
yinggeh merged 2 commits into
mainfrom
yinggeh/tri-854-psirt-triton-http-parameter-injection-via-header-forwarding
May 5, 2026
Merged

fix: Reject Triton reserved keys in parameters#894
yinggeh merged 2 commits into
mainfrom
yinggeh/tri-854-psirt-triton-http-parameter-injection-via-header-forwarding

Conversation

@yinggeh
Copy link
Copy Markdown
Contributor

@yinggeh yinggeh commented May 4, 2026

Reject Triton reserved keys in parameters in Python HTTP and gRPC clients.

@yinggeh yinggeh requested a review from mc-nv May 4, 2026 12:17
Comment thread src/python/library/tritonclient/http/_utils.py Fixed
Previously only 5 hardcoded keys were blocked; `timeout` and `headers`
were missing. Centralizes the list in `tritonclient/utils/__init__.py`
as `TRITON_RESERVED_REQUEST_PARAMS` / `TRITON_RESERVED_REQUEST_PARAMS_PREFIX`
and updates both gRPC and HTTP utils to use it.
@yinggeh yinggeh force-pushed the yinggeh/tri-854-psirt-triton-http-parameter-injection-via-header-forwarding branch from e3932fe to a8cff99 Compare May 4, 2026 12:19
@yinggeh yinggeh removed the request for review from mc-nv May 4, 2026 12:21
@yinggeh yinggeh changed the title security: Block reserved parameter injection via HTTP/gRPC header forwarding (TRI-854) fix: Reject Triton reserved keys and parameters May 4, 2026
@yinggeh yinggeh self-assigned this May 4, 2026
@yinggeh yinggeh changed the title fix: Reject Triton reserved keys and parameters fix: Reject Triton reserved keys in parameters May 4, 2026
@yinggeh yinggeh requested review from pskiran1 and whoisj May 4, 2026 12:32
@yinggeh yinggeh merged commit 58a44ca into main May 5, 2026
3 checks passed
@yinggeh yinggeh deleted the yinggeh/tri-854-psirt-triton-http-parameter-injection-via-header-forwarding branch May 5, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants