Repository navigation
Improve artifact classification and separate VM and installer storage - #76
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a335519089
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ): CleanupAnalysis { | ||
| // VM contents are inventory, not generic cache/media cleanup candidates. | ||
| files = files.filter((f) => !isVirtualMachineFile(f.path, f.extension)); | ||
| directories = directories.filter((d) => !isVirtualMachineFile(d.path)); |
There was a problem hiding this comment.
Exclude VM directory roots from cleanup analysis
When a DirectoryHotspot is the VM root itself for a path-owned layout (for example /VirtualBox VMs/node_modules or ~/.tart/vms/DiagOutputDir), this predicate returns false because the Tart/VirtualBox/Minikube/Docker checks require a child segment after the VM name. The later cache and diagnostic passes can then offer the whole VM as regenerable or even safe cleanup based solely on its name, so this call needs directory-aware root matching before those hotspots are analyzed.
Useful? React with 👍 / 👎.
| bucket.size += file.size; | ||
| bucket.count++; | ||
| } | ||
| return [...buckets.values()]; |
There was a problem hiding this comment.
Sort sampled extension buckets by aggregate size
When a category contains multiple extensions and the largest individual file is not from the extension with the largest aggregate (for example one 100 MB ISO followed by two 60 MB DMGs), this returns Map insertion order. Overview renders the array directly, whereas scan-wide topExtensions is size-sorted, so the filtered sidebar can place the 120 MB bucket below the 100 MB bucket and change ordering based on file input order; sort the completed buckets by total size before returning them.
Useful? React with 👍 / 👎.
Tart, VirtualBox, Minikube and Docker VM directories count as VMs themselves, so a folder named like a cache is not offered as one. Sampled extension buckets are ordered by total size.
tzarebczan
left a comment
There was a problem hiding this comment.
Codex's two notes are fixed on 830ce32. A Tart, VirtualBox, Minikube, or Docker VM directory counts as a VM itself, so a folder named like a cache is not offered as cleanup. Sampled extension buckets are ordered by total size.
The overlap with #75 in contracts.ts and index.css merges cleanly: both sides stay. CI is green, including Windows E2E.
Scala/sbt output was mislabeled Rust in mixed monorepos. This PR requires tool-specific evidence, expands disposable-cache coverage, and separates VM storage from installers.
targetcould imply RustSame-machine attribution — replay of 9.27 million files; GiB of recorded allocation, not guaranteed reclaimable space.
Full reconciliation and intentional exclusions. Later language coverage adds another 16.754 MiB of Bundler downloads. Source, Git history, configuration and ambiguous custom layouts remain excluded from disposable-cache attribution.
Screenshots — actual app, synthetic test files (4 KiB each).
Accepted layouts and limitations · VM / installer behavior