Skip to content

fix(stovepipe): scope task-wide closure suppression to its task - #1007

Closed
mnoah1 wants to merge 3 commits into
mainfrom
mnoah1/stovepipe-task-scoped-closure
Closed

mnoah1 wants to merge 3 commits into
mainfrom
mnoah1/stovepipe-task-scoped-closure

Conversation

@mnoah1

@mnoah1 mnoah1 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Why?

A task-wide failure currently prevents a completed build from closing any missing issue in the queue. An unrelated task can pass while its old issues remain open.

What?

Limit closure suppression to missing targets of the task with the task-wide failure. Missing issues from other tasks, including task-wide issues, can close. Unreported closed targets remain closed, and reported failures still open or remain open.

Keep the persisted HasTaskWideIssues flag and its existing refresh/checkpoint behavior. A named hasTaskWideIssue helper expresses the task-specific existence check and handles missing observations.

Situations

The table assumes the finalization pass runs; #1008 separately fixes the ordering that can discard a delayed finalization. Task matching uses the exact TaskID.

Situation Before After
Fully green terminal build; a previously open issue is missing Close it Close it
A different target fails, with no task-wide failure; a previously open issue is missing Close it Close it
Task-wide failure for task A; an open target issue for A is missing Keep it open Keep it open
Task-wide failure for task A; a closed target issue for A is missing Keep it closed Keep it closed
Task-wide failure for task A; an open target issue for task B is missing Keep it open Close it
Task-wide failure for task A; an old task-wide issue for task B is missing Keep it open Close it
A target or task-wide issue is reported again Open it or keep it open Open it or keep it open
Cancelled build; an existing issue is missing Preserve its status Preserve its status

Test Plan

  • MySQL storage unit and integration tests pass; task-specific suppression remains covered across batches, no-op refreshes, and retries.
  • Issue-tracking and entity Bazel unit tests pass, including task-specific suppression, failures discovered in a later batch, history retries, and closure on the next successful build.
  • Repository formatting, lint, dependency, and Gazelle checks pass.

Revert Plan

Revert this PR. Retain any existing has_task_wide_issues column until older readers and writers are retired.

@mnoah1
mnoah1 marked this pull request as ready for review November 4, 2026 15:45
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners November 4, 2026 15:45
@mnoah1
mnoah1 marked this pull request as draft November 4, 2026 15:55
@mnoah1 mnoah1 closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant