Repository navigation
Conversation
mnoah1
marked this pull request as ready for review
November 4, 2026 15:45
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
November 4, 2026 15:45
mnoah1
marked this pull request as draft
November 4, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
A task-wide failure currently prevents a completed build from closing any missing issue in the queue. An unrelated task can pass while its old issues remain open.
What?
Limit closure suppression to missing targets of the task with the task-wide failure. Missing issues from other tasks, including task-wide issues, can close. Unreported closed targets remain closed, and reported failures still open or remain open.
Keep the persisted
HasTaskWideIssuesflag and its existing refresh/checkpoint behavior. A namedhasTaskWideIssuehelper expresses the task-specific existence check and handles missing observations.Situations
The table assumes the finalization pass runs; #1008 separately fixes the ordering that can discard a delayed finalization. Task matching uses the exact
TaskID.Test Plan
Revert Plan
Revert this PR. Retain any existing has_task_wide_issues column until older readers and writers are retired.