Repository navigation
Conversation
mnoah1
force-pushed
the
mnoah1/stovepipe-finalization-order
branch
from
November 4, 2026 15:08
7dcebd2 to
bf9d8ff
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-finalization-order
branch
from
November 4, 2026 15:26
bf9d8ff to
49b7760
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
A running observation from a newer build advances the queue-wide source boundary and discards an older build's delayed finalization. This can leave resolved issues open, even when the newer observation reports no failures.
What?
Builds on #1007, which limits task-wide closure suppression to the affected task.
Retain a separate terminal request boundary across running refreshes. A newer running observation no longer invalidates an older finalization: each issue instead skips older sources while the rest of the finalization continues. Completed or abandoned terminal passes still supersede older work. Recovery preserves the same boundary, and finalization admission, completion, and stale-final discards are logged at info level.
Provision the non-null
issue_tracking.finalized_request_idcolumn with an empty default before deploying the updated normal and recovery controllers together. The canonical schema and rollout documentation are included. Existing completed terminal records seed their boundary from their request ID; existing refresh records have no retained terminal boundary.Test Plan
Revert Plan
Revert this PR and restart the consumers together. The added finalized_request_id column can remain.
Issues
Stack