Add support for set_ntp_server#6
Open
lauralindzey wants to merge 5 commits into
Open
Conversation
For some reason, the instrument's response to set_ntp_server is only terminated with \n, while all other responses to configuration commands are terminated with \r\n.
Previously, the disconnectTimer would fire too early, causing a messy startup sequence (as the first config attempt was often interrupted.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @CaptKrasno -- we're using a Norbit on NUI, and I wound up needing to make some changes to the driver for it to work with our rather power-constrained ops:
I'm also seeing some weirdness where it will spew hundreds of messages "Invalid version detected expected 4, got NNNN", while still seeming to parse the expected amount of data. tcpdump/wireshark wasn't illuminating (all the packets I captured from the sonar looked good, and there weren't any extras.) I may or may not take a closer look at that tomorrow.