Open
Conversation
Member
|
Interesting! Thanks for doing this. Is there an easy way to include terminal support? Like in a split screen? |
Contributor
Author
|
I added a command |
Member
Contributor
Author
|
Hi, thanks for reviewing. I signed the CLA and opened a PR with just the bugfix. I'll look into testing. |
Contributor
Author
|
Hi, I added tests for the plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #988.
This PR adds a Neovim plugin that makes it easy to use the Rascal LSP in Neovim. To make the LSP work in Neovim, this PR includes fixes for a NullPointerException.
NullPointerException stack trace
To be honest, I'm not sure what
getDidCreate,getDidRenameandgetDidDeletedo and whether it is necessary to invokegetFileOperations3 times, but at least the error is gone.This plugin only adds support for the Rascal LSP, not for the parametric LSP.