Repository navigation
feat(validate): reject unknown skills.yaml keys and unknown intel-hw-class - #4
Draft
vchamarthi wants to merge 1 commit into
Draft
vchamarthi wants to merge 1 commit into
vchamarthi wants to merge 1 commit into
Conversation
This was referenced Oct 22, 2026
vchamarthi
force-pushed
the
feat/catalog-field-check
branch
from
October 22, 2026 21:53
c7e95da to
2c51cf3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two checks to
check_catalogintools/validate_skills.py, plus a unittest wired into the Validate workflow. Askills.yamlentry with a misspelt key (for exampleintel-hw-clas) is now an error, and so is anintel-hw-classoutsidecpu | gpu | npu | accelerator.Evidence
python3 -m unittest discover -s testsandpython3 tools/validate_skills.pyintel-hw-class: GPUboth produce no error.validate_skills.pyexits 0.validate_skills.pyexits 0 on the real catalog, so all 33 current entries conform to the documented keys and classes.Blast radius
tools/validate_skills.py: two new error paths incheck_catalog, reached only when an entry has a key outside the documented set or a non-emptyintel-hw-classoutside the four classes.tests/test_catalog_fields.py: new, standard library only..github/workflows/validate.yml: one new step running that test.CATALOG_KEYS.Created with Claude Code.