feat(cli): add terminal hyperlinks, live feedback, and verification to guided installer by jack-arturo · Pull Request #157 · verygoodplugins/mcp-automem

jack-arturo · 2026-06-17T04:30:22Z

What changed

Terminal hyperlinks (OSC 8) on every actionable URL in the installer review, notes, commands, and success card (InstaPods/Railway deploys, health/recall probes, git clone for local, final endpoint). stripAnsi / visibleLength and all non-TTY/CI/NO_COLOR paths continue to see clean plain text.
Live attempt counters on the local "Waiting for AutoMem to come online" spinner (e.g. (7/30)).
Early interactive hint: "Detected on this machine: Codex, Claude Code, ..." so the agent pre-selection is obvious.
End-of-apply verification probe (re-uses the same health+auth logic) + a short celebratory line with the done mascot.
Small review polish: command lines in the plan are now linked where they contain URLs; only safe commands (prepare-local, manual-step) are shown.
Harness strip updated so the PTY transcript expectations stay stable with the new OSC sequences.

Scope

Only three files:

src/cli/ui/theme.ts (hyperlink helper + Theme.link + robust OSC strip)
src/cli/install.ts (all the call sites + onAttempt plumbing + detected line + verification + guards)
tests/e2e/interactive.mjs (OSC-aware strip)

Verification

npm run build clean
vitest run src/cli/install.test.ts src/cli/ui/ui.test.ts → 65 passing
node tests/e2e/interactive.mjs → all 5 routes (existing-*, cloud, local) pass

Risk / compatibility

Additive and behind the existing full degradation matrix (TTY, NO_COLOR, AUTOMEM_NO_ANIM, AUTOMEM_ASCII, CI, dumb TERM, win32, non-interactive preview, --dry-run, --yes, pipes). No new deps. Secrets and machine output paths untouched.

Closes the visual-flair gaps vs. 2026 peers (Railway live logs, modern create-*/Vercel-style links + confidence moments) while keeping (and strengthening) the "beautiful but works everywhere" contract.

How to try

cd /path/to/worktree   # or npx the built dist after checkout
node dist/index.js install --dry-run
# or full interactive

(Work done in the user-requested sibling worktree so main remained untouched.)

…o guided installer - OSC 8 hyperlinks (theme.link) for deploy links, health/recall URLs, git clone, success endpoint (graceful stripAnsi degradation) - Live attempt counters on local "Waiting for AutoMem" spinner via onAttempt callback - Early interactive "Detected on this machine: ..." summary explaining agent pre-selections - Post-apply connectivity + auth verification probe with celebratory line - Guarded action.command printing (only prepare-local + manual-step); linked commands in review - tests/e2e/interactive.mjs strip improved for OSC so harness expectations stay clean - All local gates green: build, 65 vitest, full 5/5 PTY interactive harness Related paths only; unrelated main-checkout dirt (AGENTS, INSTALLATION, other CLI, untracked cloud/grok) left behind per user worktree request.

Place the eslint-disable comments immediately before the two regex literals that contain \x1b / \x07 control characters. The previous placement on the return line was treated as unused and the rule still fired on the character positions inside the regexes. This was the sole cause of the "test" CI failure on the initial PR head. No behavior change.

Copilot

Pull request overview

This PR enhances the guided installer’s terminal UX by adding OSC 8 hyperlinks, more live feedback during endpoint waits, and a post-install verification probe, while keeping the e2e PTY harness stable by stripping OSC sequences.

Changes:

Add an OSC 8 hyperlink helper and teach stripAnsi/visibleLength to ignore OSC sequences.
Add live attempt counters during local endpoint wait + early “Detected on this machine …” hint + end-of-apply verification message.
Update e2e transcript stripping and relax a scenario expectation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
`tests/e2e/interactive.mjs`	Strip OSC (including hyperlinks) from PTY transcripts and adjust expectations.
`src/cli/ui/theme.ts`	Add `Theme.link`, implement OSC-aware `stripAnsi`, and introduce an OSC 8 hyperlink helper.
`src/cli/install.ts`	Use hyperlinks in plan/details, add spinner attempt updates, early detected-clients hint, and final verification probe messaging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

      bullet: unicode ? '•' : '-',
      arrow: unicode ? '→' : '->',
      line: unicode ? '─' : '-',
    },
+    link: hyperlink,
  };


+export function hyperlink(url: string, label?: string): string {
+  const text = label && label.length > 0 ? label : url;
+  // OSC 8 ; ; <url> ST <text> OSC 8 ; ; ST
+  return `\x1b]8;;${url}\x1b\\${text}\x1b]8;;\x1b\\`;
+}


 import { playInstallerSplash, shouldUseInstallerAnimation } from './install-ui.js';
-import { makeTheme } from './ui/theme.js';
+import { hyperlink, makeTheme } from './ui/theme.js';
 import { keyValueRows, type TableRow } from './ui/table.js';


+        const t = makeTheme(process.stdout);
+        process.stdout.write(`\n${t.style.gold('✦')} ${t.style.dim('Connectivity + auth verified — memory graph is reachable.')}\n`);
+      }


+  // Friendly early signal of smart defaults (only in interactive TTY so it doesn't
+  // pollute dry-run previews or pipes).
+  if (interactive && environment.detectedClients.length > 0) {


…uards - hyperlink(): add safe http(s) URL validation before emitting OSC 8. Non-URLs (e.g. <prompted>) and anything containing controls now return plain text, preventing terminal escape injection. - install.ts: switch the hosted-setup noteBox to use theme.link(...) so it goes through the capability-aware path (no direct hyperlink import). - Remove the now-unused named `hyperlink` import. - "Detected on this machine" guard now also checks !dryRun (the comment claimed it wouldn't pollute dry-run previews on TTY). - Verification success line now omits the hard-coded ✦ glyph when !theme.unicode (consistent with clientGlyph etc.). All other Copilot points were already covered by existing guards or the previous lint fix. Local build + targeted tests still green.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

 export function makeTheme(
  stream: NodeJS.WriteStream = process.stdout,
  options: ThemeOptions = {}
 ): Theme {
  const color = shouldColor(stream, options.color ?? 'auto');
  const unicode = shouldUseUnicode(stream, options.symbols ?? 'auto');
  return {
    color,
    unicode,
    width: options.width ?? streamWidth(stream),
    style: {
      bold: wrap(color, ANSI.bold),
      dim: wrap(color, ANSI.dim),
      red: wrap(color, ANSI.red),
      green: wrap(color, ANSI.green),
      yellow: wrap(color, ANSI.yellow),
      blue: wrap(color, ANSI.blue),
      magenta: wrap(color, ANSI.magenta),
      gold: wrap(color, ANSI.gold),
      goldBright: wrap(color, ANSI.goldBright),
      inverseGold: (text) =>
        color && text.length > 0
          ? `${ANSI.goldBg}${ANSI.black}${text}${ANSI.reset}`
          : `[${text.trim()}]`,
    },
    symbol: {
      check: unicode ? '✓' : '+',
      cross: unicode ? '✗' : 'x',
      warn: unicode ? '▲' : '!',
      info: unicode ? '●' : '*',
      bullet: unicode ? '•' : '-',
      arrow: unicode ? '→' : '->',
      line: unicode ? '─' : '-',
    },
+    link: hyperlink,
  };
 }


+export function hyperlink(url: string, label?: string): string {
+  const text = label && label.length > 0 ? label : url;
+  // Only produce a real hyperlink for safe http(s) URLs.
+  try {
+    const u = new URL(url);
+    if (u.protocol !== 'http:' && u.protocol !== 'https:') {
+      return text;
+    }
+  } catch {
+    return text;
+  }
+  // OSC 8 ; ; <url> ST <text> OSC 8 ; ; ST
+  return `\x1b]8;;${url}\x1b\\${text}\x1b]8;;\x1b\\`;
+}


…l char stripping per Copilot P1

jack-arturo · 2026-06-17T12:13:31Z

/copilot-review

Copilot AI review requested due to automatic review settings June 17, 2026 04:30

Copilot started reviewing on behalf of jack-arturo June 17, 2026 04:30 View session

Copilot AI reviewed Jun 17, 2026

View reviewed changes

jack-arturo requested a review from Copilot June 17, 2026 04:41

Copilot started reviewing on behalf of jack-arturo June 17, 2026 04:42 View session

Copilot AI reviewed Jun 17, 2026

View reviewed changes

fix(cli): harden hyperlink() with normalized href and explicit contro…

14f1c39

…l char stripping per Copilot P1

jack-arturo mentioned this pull request Jun 26, 2026

fix: Sanitize terminal hyperlinks in plain output #164

Merged

fix(cli): sanitize terminal hyperlinks in plain output (#164)

5885c1e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(cli): add terminal hyperlinks, live feedback, and verification to guided installer - #157

feat(cli): add terminal hyperlinks, live feedback, and verification to guided installer#157
jack-arturo wants to merge 5 commits into
mainfrom
feat/installer-visual-flair

jack-arturo commented Jun 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

jack-arturo commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jack-arturo commented Jun 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

jack-arturo commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants