Skip to content

fix(app): collapsible table aria-controls 대상 유지 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seonghobae wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(app): collapsible table aria-controls 대상 유지 #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f4477d
red(app): cover mounted collapsible table bodies
seonghobae Jun 15, 2026
6b86635
green(app): keep collapsible table bodies mounted
seonghobae Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 34 additions & 29 deletions apps/app/app/components/ActorTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use client";

import { useState } from "react";
import { Fragment, useState } from "react";
import { ChevronRight, CircleDot, ListOrdered, User } from "lucide-react";
import { Avatar, AvatarFallback } from "@/components/ui/avatar";
import { Badge } from "@/components/ui/badge";
Expand Down Expand Up @@ -148,41 +148,46 @@ export function ActorTable({
) : (
groups.map(([type, items]) => {
const isOpen = !collapsed.has(type);
const groupId = `actor-group-${type}`;
return (
<tbody key={type}>
<tr className="border-t border-border bg-muted/30">
<td colSpan={COLUMN_COUNT} className="py-1.5 pr-3 pl-4">
<button
type="button"
onClick={() => toggle(type)}
aria-expanded={isOpen}
className="inline-flex items-center gap-2 rounded-sm focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-ring"
>
<ChevronRight
aria-hidden="true"
className={cn(
"size-3.5 shrink-0 text-muted-foreground transition-transform",
isOpen && "rotate-90"
)}
/>
<span className="font-medium text-foreground">
{actorTypeLabel(type)}
</span>
<span className="text-xs text-muted-foreground">
{items.length}
</span>
</button>
</td>
</tr>
{isOpen &&
items.map((actor) => (
<Fragment key={type}>
<tbody>
<tr className="border-t border-border bg-muted/30">
<td colSpan={COLUMN_COUNT} className="py-1.5 pr-3 pl-4">
<button
type="button"
onClick={() => toggle(type)}
aria-expanded={isOpen}
aria-controls={groupId}
className="inline-flex items-center gap-2 rounded-sm focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-ring"
>
<ChevronRight
aria-hidden="true"
className={cn(
"size-3.5 shrink-0 text-muted-foreground transition-transform",
isOpen && "rotate-90"
)}
/>
<span className="font-medium text-foreground">
{actorTypeLabel(type)}
</span>
<span className="text-xs text-muted-foreground">
{items.length}
</span>
</button>
</td>
</tr>
</tbody>
<tbody id={groupId} className={cn(!isOpen && "hidden")}>
{items.map((actor) => (
<ActorRow
key={actor.id}
actor={actor}
usecaseCount={usecaseCountByActor[actor.name] ?? 0}
/>
))}
</tbody>
</tbody>
</Fragment>
);
})
)}
Expand Down
59 changes: 32 additions & 27 deletions apps/app/app/components/UsecaseTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use client";

import { useState } from "react";
import { Fragment, useState } from "react";
import Link from "next/link";
import {
ChevronRight,
Expand Down Expand Up @@ -193,39 +193,44 @@ export function UsecaseTable({
) : (
groups.map(([level, items]) => {
const isOpen = !collapsed.has(level);
const groupId = `usecase-group-${level}`;
return (
<tbody key={level}>
<tr className="border-t border-border bg-muted/30">
<td colSpan={COLUMN_COUNT} className="py-1.5 pr-3 pl-4">
<button
type="button"
onClick={() => toggle(level)}
aria-expanded={isOpen}
className="inline-flex items-center gap-2 rounded-sm focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-ring"
>
<ChevronRight
aria-hidden="true"
className={cn(
"size-3.5 shrink-0 text-muted-foreground transition-transform",
isOpen && "rotate-90"
)}
/>
<LevelTag level={level} />
<span className="text-xs text-muted-foreground">
{items.length}
</span>
</button>
</td>
</tr>
{isOpen &&
items.map((usecase) => (
<Fragment key={level}>
<tbody>
<tr className="border-t border-border bg-muted/30">
<td colSpan={COLUMN_COUNT} className="py-1.5 pr-3 pl-4">
<button
type="button"
onClick={() => toggle(level)}
aria-expanded={isOpen}
aria-controls={groupId}
className="inline-flex items-center gap-2 rounded-sm focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-ring"
>
<ChevronRight
aria-hidden="true"
className={cn(
"size-3.5 shrink-0 text-muted-foreground transition-transform",
isOpen && "rotate-90"
)}
/>
<LevelTag level={level} />
<span className="text-xs text-muted-foreground">
{items.length}
</span>
</button>
</td>
</tr>
</tbody>
<tbody id={groupId} className={cn(!isOpen && "hidden")}>
{items.map((usecase) => (
<UsecaseRow
key={usecase.key}
usecase={usecase}
projectKey={projectKey}
/>
))}
</tbody>
</tbody>
</Fragment>
);
})
)}
Expand Down
31 changes: 31 additions & 0 deletions apps/app/tests/e2e-web/tier1.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,37 @@ test("actor list page groups actors by role with per-actor detail", async ({
await expect(page.getByText("결제 게이트웨이")).toBeVisible();
});

test("collapsible table groups keep controlled row groups mounted", async ({
page
}) => {
await page.goto("/projects/CHECKOUT");

const usecaseToggle = page.getByRole("button", { name: "사용자 목표" });
await expect(usecaseToggle).toHaveAttribute("aria-expanded", "true");
await expect(usecaseToggle).toHaveAttribute(
"aria-controls",
"usecase-group-USER_GOAL"
);

const usecaseRows = page.locator("tbody#usecase-group-USER_GOAL");
await expect(usecaseRows).toHaveCount(1);
await usecaseToggle.click();
await expect(usecaseToggle).toHaveAttribute("aria-expanded", "false");
await expect(usecaseRows).toHaveClass(/hidden/);

await page.goto("/projects/CHECKOUT/actors");

const actorToggle = page.getByRole("button", { name: /지원 액터/ });
await expect(actorToggle).toHaveAttribute("aria-expanded", "true");
await expect(actorToggle).toHaveAttribute("aria-controls", "actor-group-SUPPORTING");

const actorRows = page.locator("tbody#actor-group-SUPPORTING");
await expect(actorRows).toHaveCount(1);
await actorToggle.click();
await expect(actorToggle).toHaveAttribute("aria-expanded", "false");
await expect(actorRows).toHaveClass(/hidden/);
});

test("use case detail renders Cockburn fields", async ({ page }) => {
await page.goto("/projects/CHECKOUT/usecases/CHECKOUT-001");
await expect(
Expand Down