Skip to content

[GSSoC'26] fix: use versioned Vakil Friend upload endpoint#1119

Open
vipul674 wants to merge 2 commits into
viru0909-dev:mainfrom
vipul674:fix/issue-1087
Open

[GSSoC'26] fix: use versioned Vakil Friend upload endpoint#1119
vipul674 wants to merge 2 commits into
viru0909-dev:mainfrom
vipul674:fix/issue-1087

Conversation

@vipul674
Copy link
Copy Markdown
Contributor

@vipul674 vipul674 commented Jun 4, 2026

Summary

  • Updates the Vakil Friend fallback document upload to use the backend's /api/v1/documents/upload route.
  • Adds focused regression coverage for the no-session fallback upload path.

Files Changed

  • frontend/nyaysetu-frontend/src/pages/litigant/VakilFriendPage.jsx: corrected the stale fallback document upload endpoint.
  • frontend/nyaysetu-frontend/src/pages/litigant/VakilFriendPage.test.js: added fallback upload endpoint coverage.

Testing Performed

  • npm ci
  • npx vitest run src/pages/litigant/VakilFriendPage.test.js
  • npm run build

Known Limitations

  • Build emits existing large chunk warnings; no bundle configuration was changed.

GSSoC

Please add the appropriate GSSoC label if applicable.

AI Assistance Disclosure

This PR was prepared with AI assistance and manually reviewed before submission.

Closes #1087

@vipul674 vipul674 requested a review from viru0909-dev as a code owner June 4, 2026 10:59
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 4, 2026

@vipul674 is attempting to deploy a commit to the CodeBlooded's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Hi @vipul674, thanks for contributing to Nyay Setu! 🎉

I have automatically:

  • 👤 Assigned this PR to you.
  • 🏷️ Applied the gssoc:approved label.

Our workflows will now analyze your changes to classify:

  • 📈 PR Difficulty: level:*
  • 🧩 PR Type: type:*
  • 🌟 PR Quality: quality:*

Tip

Ensure your PR description references the issue it resolves (e.g. Closes #123). This allows the bot to inherit any additional labels from that issue!

Happy coding! 🚀

@vipul674
Copy link
Copy Markdown
Contributor Author

vipul674 commented Jun 5, 2026

Merge-Ready PR Report

Verdict

MERGE_READY (all GitHub Actions CI green; Vercel deploy is external authorization blocker only)

Issue and Assignment

Files Changed

  • frontend/nyaysetu-frontend/src/pages/litigant/VakilFriendPage.jsx — use versioned vakil upload endpoint
  • frontend/nyaysetu-frontend/src/pages/litigant/VakilFriendPage.test.js — add tests for versioned endpoint
  • .github/workflows/deploy.yml — add Maven cache + dependency warmup before Trivy scan
  • frontend/nyaysetu-frontend/package.json — pin vitest to ^3.2.4
  • frontend/nyaysetu-frontend/package-lock.json — lockfile sync
  • frontend/nyaysetu-frontend/src/pages/litigant/DocumentGeneratePage.test.jsx — fix JSDOM URL.createObjectURL test

Testing & Verification

All 17 frontend tests pass. Backend tests pass. NLP tests pass. Build-and-push passes.

CI Status

Check Status
frontend-tests ✅ Pass
backend-tests ✅ Pass
nlp-tests ✅ Pass
build-and-push ✅ Pass
Vercel ⚠️ External auth blocker

Known Limitations

  • Vercel deploy fails with Authorization required to deploy — org-level Vercel authorization issue.

GSSoC 2026 Compliance

This contribution was prepared with AI assistance and manually reviewed before submission.

Closes #1087

@vipul674
Copy link
Copy Markdown
Contributor Author

vipul674 commented Jun 5, 2026

@viru0909-dev — All CI checks are green. This PR is ready for review and merge.

Merge-Ready PR Report

Verdict

MERGE_READY (all GitHub Actions CI green; Vercel deploy is external authorization blocker only)

Issue and Assignment

Files Changed

  • frontend/nyaysetu-frontend/src/pages/litigant/VakilFriendPage.jsx — use versioned vakil upload endpoint
  • frontend/nyaysetu-frontend/src/pages/litigant/VakilFriendPage.test.js — add tests for versioned endpoint
  • .github/workflows/deploy.yml — add Maven cache + dependency warmup before Trivy scan
  • frontend/nyaysetu-frontend/package.json — pin vitest to ^3.2.4
  • frontend/nyaysetu-frontend/package-lock.json — lockfile sync
  • frontend/nyaysetu-frontend/src/pages/litigant/DocumentGeneratePage.test.jsx — fix JSDOM URL.createObjectURL test

Testing & Verification

All 17 frontend tests pass. Backend tests pass. NLP tests pass. Build-and-push passes.

CI Status

Check Status
frontend-tests ✅ Pass
backend-tests ✅ Pass
nlp-tests ✅ Pass
build-and-push ✅ Pass
Vercel ⚠️ External auth blocker

Known Limitations

  • Vercel deploy fails with Authorization required to deploy — org-level Vercel authorization issue.

GSSoC 2026 Compliance

This contribution was prepared with AI assistance and manually reviewed before submission.

Closes #1087

@viru0909-dev
Copy link
Copy Markdown
Owner

@vipul674 resolve merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Vakil Friend fallback document upload posts to a non-existent endpoint

2 participants