style: fix clippy::items_after_statements warnings#231
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
fengmk2
approved these changes
Oct 16, 2025
Member
Author
Merge activity
|
Brooooooklyn
changed the base branch from
fix/clippy-redundant-closure-for-method-calls
to
graphite-base/231
October 17, 2025 06:08
Move item declarations (const, use, extern) to the beginning of their scopes: - macos.rs: Move DYLD_INSERT_LIBRARIES const to function start - client/mod.rs: Move extern "C" blocks and use statements before code - unix/mod.rs: Move PRELOAD_CDYLIB and SAFE_FD_NUM consts to function/scope start These changes improve code organization and follow Rust best practices where items should be declared at the start of their scope. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Move item declarations (struct, use statements) to the beginning of test functions to comply with clippy::items_after_statements lint. Changes: - vite_package_manager/src/request.rs: Move struct and use statements to the beginning of test functions - vite_task/src/fingerprint.rs: Move use statements to the beginning of test functions and remove duplicate imports All tests pass and clippy is clean with -D clippy::items_after_statements. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Brooooooklyn
force-pushed
the
fix/clippy-items-after-statements
branch
from
October 17, 2025 06:08
a92ef8a to
8b70578
Compare
wan9chi
pushed a commit
that referenced
this pull request
Mar 12, 2026
- feat: add pre/post lifecycle hooks for package.json scripts (#231) - feat: fast-fail execution when a task fails (#233) Also syncs run-config.ts types for new `enablePrePostScripts` option. https://claude.ai/code/session_0139LsSbe67hcD8NKKaK6Y8U
4 tasks
fengmk2
pushed a commit
that referenced
this pull request
Mar 12, 2026
## Summary - Bump vite-task dependency from `7e28617` to `28f371a` (latest main) - Picks up: - feat: add pre/post lifecycle hooks for package.json scripts (#231) - feat: fast-fail execution when a task fails (#233) - Syncs `run-config.ts` types for new `enablePrePostScripts` option ## Test plan - [x] `cargo check --all-targets --all-features` passes - [x] `cargo test -p vite-plus-cli` passes (22 tests) - [x] `run-config.ts` types synced - [ ] CI passes
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
style: fix clippy::items_after_statements warnings
Move item declarations (const, use, extern) to the beginning of their scopes:
These changes improve code organization and follow Rust best practices
where items should be declared at the start of their scope.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
style: fix clippy::items_after_statements in test code
Move item declarations (struct, use statements) to the beginning of test
functions to comply with clippy::items_after_statements lint.
Changes:
the beginning of test functions
test functions and remove duplicate imports
All tests pass and clippy is clean with -D clippy::items_after_statements.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com