style: fix clippy::redundant_clone warning#233
Merged
Conversation
This was referenced Oct 16, 2025
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
reviewed
Oct 17, 2025
Brooooooklyn
force-pushed
the
fix/clippy-very-low-priority
branch
3 times, most recently
from
October 17, 2025 02:25
fb052f8 to
d4885a3
Compare
fengmk2
approved these changes
Oct 17, 2025
Brooooooklyn
force-pushed
the
fix/clippy-very-low-priority
branch
from
October 17, 2025 06:02
d4885a3 to
0ff932c
Compare
Member
Author
Merge activity
|
Brooooooklyn
changed the base branch from
fix/clippy-uninlined-format-args
to
graphite-base/233
October 17, 2025 06:15
Remove unnecessary `to_owned()` call in raw_exec.rs. The `name` variable is already owned and being moved into the closure, so cloning it is redundant. Fixed 1 occurrence in: - crates/fspy_preload_unix/src/client/raw_exec.rs All tests pass and clippy is clean with -D clippy::redundant_clone. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit addresses warnings from the pedantic and nursery lint groups: **Auto-fixed (57 warnings):** - Converted manual range slicing to `.take()` method calls - Updated uninlined format arguments - Simplified redundant field names in struct initialization - Other automated fixes across 23 files **Manual fixes:** 1. **build.rs**: Added underscores to long integer literals for readability - Fixed 4 occurrences of literals > 100 digits 2. **which.rs**: Replaced unsafe transmute with proper pointer operations - Used `std::ptr::copy_nonoverlapping` for safe byte copying - Added explicit type annotations for clarity 3. **exec/mod.rs**: - Replaced `Default::default()` with explicit `ParseShebangOptions::default()` - Converted nested if-let to `Option::map_or_else` for PATH resolution 4. **Documentation**: Added missing `# Errors` and `# Panics` sections - payload.rs: encode_payload function - spawn/mod.rs: handle_exec function - vite_path lib.rs: current_dir function - absolute.rs: strip_prefix method - relative.rs: strip_prefix method 5. **vite_path/relative.rs**: Added `#[allow(clippy::unsafe_derive_deserialize)]` - Safe to derive Deserialize as validation happens at construction time 6. **vite_tui/app.rs**: - Changed `App::new()` from `Result<Self>` to `Self` (no errors possible) - Replaced wildcard match arm with explicit `Action::Error(_)` variant All tests pass successfully after these changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Brooooooklyn
force-pushed
the
fix/clippy-very-low-priority
branch
from
October 17, 2025 06:22
0ff932c to
c703cea
Compare
wan9chi
pushed a commit
that referenced
this pull request
Mar 12, 2026
- feat: add pre/post lifecycle hooks for package.json scripts (#231) - feat: fast-fail execution when a task fails (#233) Also syncs run-config.ts types for new `enablePrePostScripts` option. https://claude.ai/code/session_0139LsSbe67hcD8NKKaK6Y8U
4 tasks
fengmk2
pushed a commit
that referenced
this pull request
Mar 12, 2026
## Summary - Bump vite-task dependency from `7e28617` to `28f371a` (latest main) - Picks up: - feat: add pre/post lifecycle hooks for package.json scripts (#231) - feat: fast-fail execution when a task fails (#233) - Syncs `run-config.ts` types for new `enablePrePostScripts` option ## Test plan - [x] `cargo check --all-targets --all-features` passes - [x] `cargo test -p vite-plus-cli` passes (22 tests) - [x] `run-config.ts` types synced - [ ] CI passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
style: fix clippy::redundant_clone warning
Remove unnecessary
to_owned()call in raw_exec.rs. Thenamevariableis already owned and being moved into the closure, so cloning it is
redundant.
Fixed 1 occurrence in:
All tests pass and clippy is clean with -D clippy::redundant_clone.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
style: fix clippy::pedantic and clippy::nursery warnings
This commit addresses warnings from the pedantic and nursery lint groups:
Auto-fixed (57 warnings):
.take()method callsManual fixes:
build.rs: Added underscores to long integer literals for readability
which.rs: Replaced unsafe transmute with proper pointer operations
std::ptr::copy_nonoverlappingfor safe byte copyingexec/mod.rs:
Default::default()with explicitParseShebangOptions::default()Option::map_or_elsefor PATH resolutionDocumentation: Added missing
# Errorsand# Panicssectionsvite_path/relative.rs: Added
#[allow(clippy::unsafe_derive_deserialize)]vite_tui/app.rs:
App::new()fromResult<Self>toSelf(no errors possible)Action::Error(_)variantAll tests pass successfully after these changes.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com