Skip to content

fix: don't return ads after the first page#36

Merged
rodorgas merged 2 commits into
mainfrom
fix/remove-ads-not-1st-page
Aug 7, 2025
Merged

fix: don't return ads after the first page#36
rodorgas merged 2 commits into
mainfrom
fix/remove-ads-not-1st-page

Conversation

@rodorgas

@rodorgas rodorgas commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request?

Don't return sponsored products after the first search page.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactor (non-breaking change which doesn't change any functionalities)
  • Bug fix (non-breaking change which fixes an issue)
  • Chore (changes configuration files, GitHub workflows, etc.)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@rodorgas rodorgas requested a review from amandascm August 7, 2025 14:55
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Aug 7, 2025

Copy link
Copy Markdown

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot

Copy link
Copy Markdown

Beep boop 🤖

I noticed you're not using the Docs Builder properly yet, if you need help to set that up please go to IO Documentation

@rodorgas rodorgas force-pushed the fix/remove-ads-not-1st-page branch from 9853d4a to e47b871 Compare August 7, 2025 15:00
@rodorgas rodorgas force-pushed the fix/remove-ads-not-1st-page branch from e47b871 to 2de657b Compare August 7, 2025 15:01

@amandascm amandascm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread node/utils/shouldFetchSponsoredProducts.ts
@rodorgas rodorgas merged commit 874eb74 into main Aug 7, 2025
2 of 4 checks passed
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Aug 7, 2025

Copy link
Copy Markdown

Your PR has been merged! App is being published. 🚀
Version 2.10.1 → 2.10.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.adserver-resolver@2.10.2

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants