Skip to content

fix: don't return ads after the first page #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rodorgas merged 2 commits into from
Aug 7, 2025
Merged

fix: don't return ads after the first page #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2de657b
feat: don't show ads after the first page
rodorgas Aug 7, 2025
234f38c
chore: bump version
rodorgas Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"vendor": "vtex",
"name": "adserver-resolver",
"version": "2.10.0",
"version": "2.10.1",
"title": "Ad Server Resolver",
"description": "Configurations for sponsored products on your store",
"builders": {
Expand Down
10 changes: 9 additions & 1 deletion node/utils/shouldFetchSponsoredProducts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ const shouldFetchOnProductClusers = async (ctx: Context) => {
return settings?.enableAdsOnCollections ?? true
}

const isFirstPage = (args: SearchParams) => {
return args.page === undefined || args.page.toString() === '1'
Comment thread
rodorgas marked this conversation as resolved.
}

/**
* Determine whether or not to fetch sponsored products based on a few parameters:
* 1. If the search is not sorted by relevance, don't fetch.
Expand All @@ -32,7 +36,11 @@ export const shouldFetchSponsoredProducts = async (
ctx: Context
) => {
if (!isSortedByRelevance(args)) return false
if (!queryHasProductClusters(args)) return true
if (!isFirstPage(args)) return false

if (!queryHasProductClusters(args)) {
return true
}

return shouldFetchOnProductClusers(ctx)
}
Loading