Skip to content

#79: integrate prompt-cache routing and overflow-safe observations on current main - #323

Merged
acoliver merged 17 commits into
mainfrom
pr303-findings-current-main-20261002
Oct 4, 2026
Merged

acoliver merged 17 commits into
mainfrom
pr303-findings-current-main-20261002

Conversation

@acoliver

@acoliver acoliver commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Current disposition, October 3, 2026

READY for a merge decision at e56e9fed. Original full review and its single findings-only follow-up completed F1/F2; final MSRV/stable/full/archive/extracted/native-read acceptance and candidate-identical-tree CI8pass completed. Local fresh-home audit aggregate1, first same-source vendor BrokenPipe and strict no-NO_PROXY diagnostic remain failed; historical cache evidence shows reads, not speedup. Shared/profile residual overlap and provenance limits remain. Terminal record: readiness-cache.md/json.

No merge has been performed. Head/base changes require affected source and check reconciliation. Evidence under branch-2/evalwork/results/pr-remediation-20261002/.

Preserved earlier delivery description

The description below is retained as a time-specific record. Any pending/completed wording there is superseded by the current disposition above, without changing failed-command evidence.

Replacement for #303

Head e56e9fed853b7dbaa75149a474fd320b336c0f96 replaces the old #303 delivery without rewriting/deleting its original branch/head 66225a9f. Native isolated port against main fc872110 retains unique cache routing, provider wire usage and per-call/weighted accounting. Shared #308 and residual-profile #319 changes were applied as explicitly mapped residual patches, not ancestor merges:17/17 shared paths matched;15 profile paths matched with three carrier/parser/docs seams reconciled. The old historical profile/process stack was not imported. The full old/new diffs, refs and history remain in branch-2/evalwork/results/pr-remediation-20261002/cache303-evidence.

Current main truthful Responses EOF/error/control/cancellation/no-replay behavior and all12 SSE fixtures are retained. No #78 dependency, compatibility reader, provider fallback, assertion/workflow weakening or production proxy change. Three inherited Anthropic test format lints are corrected with identical assertions and regenerated authoritative patch/pins.

Independent findings and repair

Full initial cache review at c9dc4706 requested F1 aggregate-counter overflow and F2 owning-renderer coherence. Native isolated repair keeps raw per-call counts, returns null for unrepresentable aggregate fields and ratio, and reports aggregate validity without saturating into a false exact measurement. The byte-identical original compiled overflow probe now emits one terminal envelope, two requests and preserved tool/session results instead of exit101/empty stdout. Registered compiled input/cache overflow and off/enabled tests cover terminal/persisted/replay behavior. The actual pure renderer matches the checked-in routing paragraph.

Owning MSRV root clippy/fmt/quality/compat, cache wire/accounting/modelAPI, Anthropic and Responses tests/clippy, provenance/licenses/registry/inventory passed on exact fixed source. Strict root no-NO_PROXY diagnostic remains nonzero for inherited loopback fixtures; actual checked-in root CI exempts loopback, direct vendor blackhole/no-NO_PROXY tests passed.

The single findings-only follow-up was interrupted by a provider SSE error after28events with no replay. Its partial evidence is not approval; same bounded scope completion is pending. Exact full MSRV/stable, aggregate/extracted source/package acceptance and final release/authenticated smoke are still running or incomplete. Fresh exact-head CI requested by this draft; not merge-ready.

Measurements and limits

Historical synthetic Codex/gpt-6-astra repeat-prefix observations were off0/8250 and enabled2816/8250 cached reads (34.13%); enabled was slower in both pairs. Four final successes, no TTFT/latency-benefit claim. Original scripts prohibited tools. No new tool-using cache measurement or provider/model substitution was invented. Missing historical binary/profile/raw-stderr qualifications remain; current fixtures and final read smoke are separate proofs.

No merge authorized or performed. Original #303 remains preserved until replacement mapping/closure is recorded; do not mistake this draft or successful CI for completed source review/acceptance.

@acoliver

acoliver commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Fresh exact-head CI37066091683 completed SUCCESS for e56e9fed:8pass/0fail/0pending/1tag-only publication skip, including Linux/macOS MSRV/stable and release/source-bundle acceptance. The same interrupted single findings-only reviewer session has now been continued without provider switch, credential action or new review cycle.

The original typed provider error after28events remains status5 evidence; no request replay or silent completion. Findings-only verdict and native final packaging report are still pending, so successful CI alone is not a merge-readiness declaration.

@acoliver

acoliver commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

The SAME single findings-only review is now terminal exit0 on exact e56e9fed: F1 aggregate overflow and F2 owning-renderer drift RESOLVED. It independently completed the original overflow reproduction,14 compiled enabled/off accounting cases and6 routing/accounting cases, preserved original scope/callers/vendor SSE assertions, and verified70 prior evidence files unchanged.

Original provider-error status5 after28events and the failed coordinator quoting launch remain retained; neither was silently replayed or relabeled approval. No additional review cycle is requested. Full current-head CI already passed8required checks. Native final package/archive/binary/read-smoke report is still active, so final merge-readiness reconciliation remains pending. Report: branch-2/evalwork/results/pr-remediation-20261002/followup-cache.md.

@acoliver

acoliver commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Final readiness reconciliation is terminal: READY for a merge decision at exact e56e9fed. Full original review and its single F1/F2 follow-up are complete; final exact-source MSRV/stable suites, archive/extracted acceptance and final native/localoauth read passed. Source archive SHA2569b4230a93100c0a0d6592e5566a3248200c759aca5ecaf47d1fc83d5f8a35a87; native binarySHA256b058d5c7289fd0e1e5454ddef35ef17b2191237fc21c9fb8f7db4da8aae15dda. Identical-tree remote CI passed8required checks including online audit and strict release/source.

Local fresh-home no-advisory-cache aggregate1, initial same-source vendor BrokenPipe101, strict no-NO_PROXY root diagnostic failures and original provider/quoting attempts remain failed. Historical cache evidence is synthetic/no-tools, enabled slower both pairs with2816/8250 cached reads; no speedup/current-live reproduction claim. Shared/profile residuals are included via mapped patches, not ancestors; preserve their serial delivery/overlap disposition. No repeated experiments or third review.

The evidence-reconciliation subagent timed out after writing MD; a separate report-only handoff completed JSON/terminal disposition without re-audit, preserving timeout. Reports: branch-2/evalwork/results/pr-remediation-20261002/publication/readiness-cache.{md,json}. No merge performed.

@acoliver
acoliver merged commit 4046b0c into main Oct 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant