Skip to content

chore(coderabbit): drop the inert auto_approve block - #336

Open
yakimoto wants to merge 1 commit into
mainfrom
chore/drop-inert-coderabbit-auto-approve
Open

yakimoto wants to merge 1 commit into
mainfrom
chore/drop-inert-coderabbit-auto-approve

Conversation

@yakimoto

@yakimoto yakimoto commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

auto_approve is not a key in CodeRabbit's live v2 schema (https://storage.googleapis.com/coderabbit_public_assets/schema.v2.json, verified 2026-08-02). The block that occupied this space in .coderabbit.yaml never did anything, and removing it changes no behaviour.

The real control satisfying branch protection is the branch protection rule itself requiring a review — not config in this file. This PR also replaces the surrounding comments, which previously asserted (incorrectly) that this block was what satisfied branch protection, with an accurate note.


Note

Low Risk
Config and comment-only change to CodeRabbit YAML; no application code, CI workflows, or secrets paths modified.

Overview
Removes the auto_approve section from .coderabbit.yaml and replaces misleading comments that claimed it satisfied branch protection.

The deleted block (enabled, max_changed_files, max_lines_changed, allowed_severities, excluded_paths for workflows, env files, and wrangler config) was not part of CodeRabbit’s live v2 schema, so it had no runtime effect. Branch protection still depends on GitHub’s required-review rules, not this file.

New inline comments document that removal is behavior-neutral and point to the verified schema URL.

Reviewed by Cursor Bugbot for commit f91445f. Configure here.


Summary by cubic

Removed the inert auto_approve block from .coderabbit.yaml; no behavior change. Updated comments to clarify branch protection is enforced by GitHub’s required reviews, not this file.

Written for commit f91445f. Summary will update on new commits.

Review in cubic

Note

Remove inert auto_approve block from CodeRabbit config

Removes the auto_approve configuration block from .coderabbit.yaml and replaces it with a comment noting that auto_approve is not part of the v2 schema. The block had no effect.

Macroscope summarized f91445f.

@cursor

cursor Bot commented Aug 2, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_000385e5-b2fc-4f2e-a3f2-3ba1043f2d5b)

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4838b030-6beb-4123-a4a5-c38a68cb9547

📥 Commits

Reviewing files that changed from the base of the PR and between ed0fd46 and f91445f.

📒 Files selected for processing (1)
  • .coderabbit.yaml

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp

macroscopeapp Bot commented Aug 2, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved f91445f

Removes an inert configuration block that was never functional according to CodeRabbit's schema. No runtime behavior changes since the removed config was already being ignored. Author owns this file.

You can customize Macroscope's approvability policy. Learn more.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread .coderabbit.yaml
Comment on lines +33 to +38
# ── auto_approve was REMOVED (inert) ──────────────────────────────────────
# `auto_approve` is not a key in CodeRabbit's live v2 schema
# (storage.googleapis.com/coderabbit_public_assets/schema.v2.json, verified 2026-08-02),
# so the block that used to sit here never did anything. It did NOT satisfy branch
# protection, and removing it changes no behaviour. The real control is branch protection
# requiring a review — not config in this file.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Removed block relied on for review satisfaction — verify approval path still exists

The deleted block's own comment claimed CodeRabbit's approving review was "the one missing link" for branch protection's required-review before automerge. The new comment asserts the key was inert and never satisfied branch protection. I confirmed the repo has an independent approval path: .github/workflows/auto-approve.yml calls the org reusable workflow wave-av/wave-foundation/.github/workflows/reusable-auto-approve.yml which submits an APPROVE review from wave-av-reviewbot and enables native auto-merge, gated on AUTO_APPROVE_ENABLED. So even if CodeRabbit had been approving, PRs are not left without any approval mechanism — but a reviewer should confirm the org variable is actually set to '1' for this repo, otherwise merges will now stall waiting on a human review.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@wave-bugbot

wave-bugbot Bot commented Aug 11, 2026

Copy link
Copy Markdown

🟢 WAVE BugBot — clear

No confident findings on the changed lines.

Local review · $0 inference · wave-dispatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant