Skip to content

chore(coderabbit): drop the inert auto_approve block #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yakimoto wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(coderabbit): drop the inert auto_approve block #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 6 additions & 23 deletions .coderabbit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,29 +30,12 @@ reviews:
labels:
- "!skip-review"

# Automated reviewer: on a clean review CodeRabbit posts an approving GitHub review, which satisfies
# branch protection's required-review (the one missing link — automerge.yml then merges labeled PRs
# once required checks are green). enforce_admins stays ON; nothing is bypassed. Safety lines below
# keep the high-blast-radius classes human-reviewed.
auto_approve:
enabled: true
conditions:
# Raised from 5/100 so normal code/doc/template PRs flow; the foundation file-size gate (≤800)
# is the real size discipline, so mirror it here.
max_changed_files: 25
max_lines_changed: 800
allowed_severities:
- low
- medium
# NEVER auto-approve these — they always get a human:
# workflows (a CI change can exfiltrate secrets / weaken gates)
# env/secret files
# deploy/infra config (wrangler) — production-cutover class
excluded_paths:
- ".github/workflows/**"
- "**/.env*"
- "**/wrangler.toml"
- "**/wrangler.jsonc"
# ── auto_approve was REMOVED (inert) ──────────────────────────────────────
# `auto_approve` is not a key in CodeRabbit's live v2 schema
# (storage.googleapis.com/coderabbit_public_assets/schema.v2.json, verified 2026-08-02),
# so the block that used to sit here never did anything. It did NOT satisfy branch
# protection, and removing it changes no behaviour. The real control is branch protection
# requiring a review — not config in this file.
Comment on lines +33 to +38

@devin-ai-integration devin-ai-integration Bot Aug 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Removed block relied on for review satisfaction — verify approval path still exists

The deleted block's own comment claimed CodeRabbit's approving review was "the one missing link" for branch protection's required-review before automerge. The new comment asserts the key was inert and never satisfied branch protection. I confirmed the repo has an independent approval path: .github/workflows/auto-approve.yml calls the org reusable workflow wave-av/wave-foundation/.github/workflows/reusable-auto-approve.yml which submits an APPROVE review from wave-av-reviewbot and enables native auto-merge, gated on AUTO_APPROVE_ENABLED. So even if CodeRabbit had been approving, PRs are not left without any approval mechanism — but a reviewer should confirm the org variable is actually set to '1' for this repo, otherwise merges will now stall waiting on a human review.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


review_status: true
request_changes_workflow: false
Expand Down
Loading