Repository navigation
[remote-playback] Fix specific manual tests - #64394
Open
markafoltz wants to merge 1 commit into
Open
markafoltz wants to merge 1 commit into
markafoltz wants to merge 1 commit into
Conversation
- utils.js: add promptOnClick(), which calls prompt() synchronously from a click handler so it runs with transient activation, plus waitForEvent() and logRemotePlaybackEvents(). - prompt-and-select-device-manual.html and state-attribute-changes-when-selecting-device-manual.html: replace the outer async_test, which passed as soon as the button was clicked, with a single promise_test that waits for metadata, calls prompt() from the click handler, and checks the result. state-attribute-changes previously called prompt() from a watchAvailability() callback, which may run after transient activation has expired. - prompt-and-watch-availability-no-device-manual.html: check availability in the watchAvailability() callback (which runs after the returned Promise resolves), call prompt() from the click handler, and accept NotFoundError (no UI shown) or NotAllowedError (UI shown and cancelled by the user). - prompt-and-watch-availability-with-device-manual.html: check that the watchAvailability() callback reports true before prompting (instead of once after prompt() resolves), only enable the prompt button once a device is available, and report the actual rejection reason if prompt() fails. - event-handlers-manual.html: use the onconnecting/onconnect/ ondisconnect event handler attributes, and split into two sequential tests: connecting via prompt(), and disconnecting via a second prompt(). Check the state when each event fires.
Collaborator
|
There are no reviewers for this pull request besides its author. Please reach out on the chat room to get help with this. Thank you! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a click handler so it runs with transient activation, plus
waitForEvent() and logRemotePlaybackEvents().
state-attribute-changes-when-selecting-device-manual.html: replace the
outer async_test, which passed as soon as the button was clicked, with
a single promise_test that waits for metadata, calls prompt() from the
click handler, and checks the result. state-attribute-changes
previously called prompt() from a watchAvailability() callback, which
may run after transient activation has expired.
availability in the watchAvailability() callback (which runs after the
returned Promise resolves), call prompt() from the click handler, and
accept NotFoundError (no UI shown) or NotAllowedError (UI shown and
cancelled by the user).
watchAvailability() callback reports true before prompting (instead of
once after prompt() resolves), only enable the prompt button once a
device is available, and report the actual rejection reason if
prompt() fails.
ondisconnect event handler attributes, and split into two sequential
tests: connecting via prompt(), and disconnecting via a second
prompt(). Check the state when each event fires.
Stack created with GitHub Stacks CLI • Give Feedback 💬
Part of stack https://github.com/web-platform-tests/wpt/stack/64397 (each PR shows only its own layer):
Context: Chrome failures in https://w3c.github.io/test-results/remote-playback/all.html are largely caused by the 5s test clip, which is below Chrome's 15s minimum for remote playback.