Repository navigation
[remote-playback] Test prompt() fulfillment order (w3c/remote-playback#160) - #64396
Draft
markafoltz wants to merge 1 commit into
Draft
markafoltz wants to merge 1 commit into
markafoltz wants to merge 1 commit into
Conversation
…k#160) Per w3c/remote-playback#160, the user agent queues tasks to fulfill the Promise returned by prompt() before firing the connecting event (when the user selects a device) or the disconnect event (when the user chooses to disconnect). - Add prompt-resolves-before-connecting-manual.html, which verifies that the Promise reactions run before the connecting event is fired, and that the state is "connecting" at both points. - event-handlers-manual.html: check that the Promise returned by the second prompt() resolves while still connected, before the disconnect event is fired. - Reference the new test from tests that do not check this order.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per w3c/remote-playback#160, the user agent queues tasks to fulfill the
Promise returned by prompt() before firing the connecting event (when
the user selects a device) or the disconnect event (when the user
chooses to disconnect).
the Promise reactions run before the connecting event is fired, and
that the state is "connecting" at both points.
second prompt() resolves while still connected, before the disconnect
event is fired.
Stack created with GitHub Stacks CLI • Give Feedback 💬
Part of stack https://github.com/web-platform-tests/wpt/stack/64397 (each PR shows only its own layer):
Context: Chrome failures in https://w3c.github.io/test-results/remote-playback/all.html are largely caused by the 5s test clip, which is below Chrome's 15s minimum for remote playback.
Keeping this PR as a draft until w3c/remote-playback#160 lands.