Repository navigation
fix: move sample apps to design-system 0.6.1 and drop covered workarounds - #6
Merged
Merged
Conversation
…unds Upgrade @whatsaaaa/design-system to ^0.6.1 in vue-event-registration and react-checkout, and replace what each app drew for itself with the system's pieces, the same in both apps: - per-theme marks and the ghost: ws-theme-dark / ws-theme-light, and the kit's ghost-on-dark.svg / ghost-on-light.svg in place of ghostSvg() through v-html / dangerouslySetInnerHTML - status line: ws-status-line__path and one ws-status-line__theme button, without the local container query, focus offsets, key hint padding and corner ring - --ws-size-control, --ws-size-check and --ws-size-step in place of space tokens used as sizes, and --ws-icon-check in place of the local tick - --ws-color-interactive-hover / -active in place of the color-mix hover - ws-code--wrap with --ws-code-hang in place of the local wrapping code block, and ws-visually-hidden in place of the local class - Vue: the review list is ws-pairs; Shiki loads lazily, as in React and as the usage guide now says for code off the first screen - React: the language switch is ws-segmented, the order summary ws-pairs ws-pairs--amounts, and base.css hides the spin buttons
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Context. The Vue (
vue-event-registration) and React (react-checkout) sample apps were restyled on@whatsaaaa/design-system0.1.x, as its first real consumers. Where the system lacked something, each app built a local workaround and recorded it. Those findings went back to the design system, which has since covered them: 0.5.0 and 0.6.0 added the theme and status line fixes and the missing pieces, and 0.6.1 (published 2026-11-15) the docs and small fixes.Once the design system's docs-and-fixes change merged and the release carrying it was published, switch the Vue and React sample apps to that release and remove the workarounds the system now covers.
What Changed
@whatsaaaa/design-systemto^0.6.1inreact-checkoutandvue-event-registration(package.json, lockfile,minimumReleaseAgeExclude). Removed the local CSS the system now covers:.visually-hidden, the status line path and theme rules, code line wrapping, summary rows, the React language switch, and the primary button hover workaround. Markup now uses the system'sws-visually-hidden,ws-status-line__path/__theme,ws-theme-dark/ws-theme-light,ws-pairs,ws-segmentedandws-code--wrapclasses, plus its size, interactive hover/active and check icon tokens.ghostSvgHTML injected throughdangerouslySetInnerHTMLorv-html.CodeBlockloads Shiki as a separate chunk and shows plain text until it arrives, or for good if it fails to load. The Confirm summary adds<wbr>after@and/so long emails and URLs break at those points. New Playwright tests cover both. The React e2e status line check now uses thews-status-line__themeselector.🤖 Generated with Claude Code
Workarounds still needed
0.6.1 does not cover these, so they stay in both apps. No new workarounds were added.
--icon-calendar): the system has no calendar icon.1rem, the danger icon at--ws-space-16, the radio dot at--ws-space-8): there is no icon size token. The usage guide says to draw the tick at 1rem.Kept on purpose, because the 0.6.1 guide now says to do them this way:
--ws-space-4.NORMAL/INSERTmode.Visible changes
I screenshotted both apps on
mainand on this branch, in both themes, at 320, 390 and 1440 px, and pixel-diffed them. The tab bar, marks, ghost, status line (focus rings included) and wrapping code blocks are pixel-identical. Every change that does show is one the 0.5.0 to 0.6.1 upgrade notes intend:--ws-icon-check: a 1.5 stroke instead of 2, and the tick on the success title is smaller.--ws-color-interactive-hover, and--ws-color-interactive-activewhile it is pressed.ws-segmented): the pressed language is raised with an interactive edge, not filled, and the labels are no longer semibold.ws-pairs--amounts): the total sits under a solid rule, and the rows are 3 px shorter.ws-pairs):@, not mid-word.Design-system follow-ups
ws-pairssizes its term column per list. A review step with several sections could share one term column across its lists, so the values line up as they did with the old local rows. This PR adds no local override for it.Risk Assessment
✅ Low: The change is mostly styling and markup: both apps move to design-system 0.6.1 and drop local rules the release now ships (I checked the installed 0.6.1 CSS, tokens and usage guide), and the fix round's ghost-rule removal and Vue lazy-Shiki tests are correct and match the React app.
Testing
I ran both apps' Playwright e2e suites against their production builds; both passed (Vue 29, React 45, one intentional desktop-only skip each). I then served both builds and took screenshots in Chromium, in dark and light at 1280 px and at 320 px, checking the tab bar ghost logo per theme, the status line theme name, keyboard theme toggling with focus kept, colored Shiki code blocks that wrap long values at 320 px, and that nothing scrolls sideways or logs console errors. A focused probe of the Vue Confirm step showed the new <wbr> fix makes emails break after "@" with the text unchanged for copying and for screen readers. The same probe on a build without the fix reproduced the old mid-word break, so the fix is confirmed. All servers were stopped, and the build outputs and test results were removed from the worktree.Evidence: Email line breaks with the fix vs without it
Evidence: Vue email-wrap probe results (after fix)
Evidence: Vue email-wrap probe results (before fix)
Evidence: Vue e2e run against production build
Evidence: React e2e run against production build
Evidence: Vue computed checks (images per theme, overflow, code colors, focus)
Evidence: React computed checks (images per theme, overflow, code colors, focus)
Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 2 issues found → auto-fixed ✅
vue-event-registration/src/ui/CodeBlock.vue:9- Simplification: this change adds a new way of loading Shiki in the Vue app. A module-level dynamicimport('./highlight')(CodeBlock.vue:9-15), a plain-text fallbackplain()(CodeBlock.vue:17-20), ashallowRefswap once the chunk arrives (CodeBlock.vue:36-41), and a.catch(() => undefined)that hides a failed chunk load. The intent does not call for any of this. It asks to switch both apps to design-system 0.6.1 and remove the workarounds the system now covers. Importing Shiki eagerly was never a design-system workaround; lazy loading is an optimization the 0.6.1 usage guide suggests. It also changes what users see: the submitted JSON now appears as plain text first and gains its colors later, and if the chunk fails to load it stays plain with no error. The React version of this path has an e2e test (react-checkout/e2e/checkout.spec.ts:115); the new Vue path has none. Recommended fix: drop it from this change and keep the synchronousimport { highlightJson } from './highlight', keeping only thews-code--wrap/.line/--ws-code-hangmarkup change. If you want lazy loading in Vue, it belongs in its own change.react-checkout/src/styles.css:80- Leftover workaround the system already covers:.ws-tab-bar__end .tab-bar__ghost { display: flex; }is all that remains of the old ghost rule, and design-system 0.6.1 terminal.css already sets.ws-tab-bar__end a { display: flex; align-items: center; }on the same<a>at every width (no narrow-screen override). The rule has no effect. Remove it in both places: react-checkout/src/styles.css:80-82 and vue-event-registration/src/styles.css:82-84. Thetab-bar__ghostclass then has no styles and can go from the ghost link too: react-checkout/src/ui/TabBar.tsx:37 and vue-event-registration/src/ui/TabBar.vue:34.🔧 Fix applied.
✅ Re-checked - no issues remain.
🔧 **Test** - 3 issues found → auto-fixed ✅
vue-event-registration/src/ui/CodeBlock.vue:9- The review round 1 decision says the user chose to fix 'vue-lazy-shiki-out-of-scope'. That finding's recommended fix was to drop the module-level dynamic import('./highlight'), the plain() fallback and the shallowRef swap, and go back to the synchronousimport { highlightJson } from './highlight'. The fix commit 73fed5e ('test Vue lazy Shiki') kept the lazy path and added two e2e tests for it (registration.spec.ts:206 and :236). Both tests pass, and the behavior works: plain text first, colors once the chunk loads, plain text with no errors if the chunk fails. But the change still has the out-of-scope lazy loading the user chose to remove. This test phase did not revert it, because that would override how the fixer resolved the decision. Please confirm whether the lazy path should be dropped as the decision says, or kept with its new tests.vue-event-registration/src/ui/SummaryList.vue:19- On the Vue Confirm step, each section is its own <dl class="ws-pairs">, and ws-pairs sizes its term column per list (fit-content(40%)). So values no longer line up between sections. At 1280 px, 'About you' values start at x=340 and 'Your visit' values at x=508 (vue-desktop-light-3-confirm-summary.png). Before this change, the local 2fr/3fr rows lined every section up at the same column. Fixing it would mean either a local override, which is a workaround the intent asks to remove, or a design-system change such as sharing columns across lists. That is a design call.vue-event-registration/src/ui/SummaryList.vue:22- At 320 px, the Confirm step breaks the email value mid-word as 'marko@example.co' / 'm' (vue-narrow-320-dark-2-confirm-summary.png). This was already there before this change: with the base's 2fr/3fr columns the cell is 148 px instead of 162 px and still wraps to 2 lines. The 0.6.1 usage guide says to put a <wbr /> after the '@' of a long email so it breaks there. SummaryList renders values as plain text, so it doesn't do that. A small follow-up could fix it.pnpm build && pnpm start, Vuepnpm build+vite preview).tab-bar__ghostrule)cd react-checkout && pnpm exec playwright test(runspnpm build && pnpm start, desktop + Pixel 7 projects): 45 passed, 1 skipped by design (key hints only show on a wide screen)cd vue-event-registration && pnpm exec playwright test(runspnpm buildthenvite preview, desktop + Pixel 7): 29 passed, 1 skipped by design. Includes the new lazy-Shiki loads-later and chunk-fails testsChecked the installed design-system package.json in both apps' node_modules: version 0.6.1node shots.mjs react http://localhost:4374 ...: screenshots and computed-style checks of the React prod server (dark and light at 1280 px, dark at 320 px with long values, Enter on the theme button with the keyboard)node shots.mjs vue http://localhost:4373 ...: the same pass for the Vue prod server (step indicator, Confirm summary, registration code block)node tick.mjs ...: 3x zoom screenshots and computed styles of the --ws-icon-check tick on a checked box and on a done step, in both themesMeasured the Vue Confirm-step email row at 320 px with the new ws-pairs columns and with the base's 2fr/3fr rule injected, to see whether the mid-word email break is new🔧 Fix applied.
✅ Re-checked - no issues remain.
cd vue-event-registration && pnpm exec playwright test --reporter=list(runspnpm build && vite previewas its webServer; desktop + Pixel 7 projects): 29 passed, 1 intentional mobile skip, EXIT=0cd react-checkout && pnpm exec playwright test --reporter=list(runspnpm build && pnpm start; desktop + Pixel 7): 45 passed, 1 intentional mobile skip, EXIT=0Served both production builds (vite preview --port 4373,PORT=4374 pnpm start) and rannode shots.mjs vue|react <url>in Chromium: screenshots and computed checks at 1280 px dark/light and 320 px dark with long values, plus keyboard theme togglingnode email-wrap.mjs http://localhost:4373: Vue Confirm step with a short and a long email plus a slash-separated textarea value, at 320 px and 1280 px in dark and light; records the text on each drawn line, textContent, innerText, the aria snapshot, sideways scroll and console errorsRegression check: built the Vue app with the pre-fix SummaryList.vue from 73fed5e into a temporary outDir, served it on port 4375 and ran the sameemail-wrap.mjs: the short email breaks mid-word asmarko@example.co/mRead installednode_modules/@whatsaaaa/design-system/package.jsonin both apps: version 0.6.1✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.