Skip to content

fix: move sample apps to design-system 0.6.1 and drop covered workarounds - #6

Merged
whatsaaaa merged 3 commits into
mainfrom
fm/ds-adopt-020
Nov 15, 2026
Merged

whatsaaaa merged 3 commits into
mainfrom
fm/ds-adopt-020

Conversation

@whatsaaaa

@whatsaaaa whatsaaaa commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Intent

Context. The Vue (vue-event-registration) and React (react-checkout) sample apps were restyled on @whatsaaaa/design-system 0.1.x, as its first real consumers. Where the system lacked something, each app built a local workaround and recorded it. Those findings went back to the design system, which has since covered them: 0.5.0 and 0.6.0 added the theme and status line fixes and the missing pieces, and 0.6.1 (published 2026-11-15) the docs and small fixes.

Once the design system's docs-and-fixes change merged and the release carrying it was published, switch the Vue and React sample apps to that release and remove the workarounds the system now covers.

What Changed

  • Bumped @whatsaaaa/design-system to ^0.6.1 in react-checkout and vue-event-registration (package.json, lockfile, minimumReleaseAgeExclude). Removed the local CSS the system now covers: .visually-hidden, the status line path and theme rules, code line wrapping, summary rows, the React language switch, and the primary button hover workaround. Markup now uses the system's ws-visually-hidden, ws-status-line__path/__theme, ws-theme-dark/ws-theme-light, ws-pairs, ws-segmented and ws-code--wrap classes, plus its size, interactive hover/active and check icon tokens.
  • In both apps, the theme switch is now a single status line button that holds both theme names, so it keeps focus when the theme changes. The tab bar ghost now comes from per-theme SVG assets instead of ghostSvg HTML injected through dangerouslySetInnerHTML or v-html.
  • Vue only: CodeBlock loads Shiki as a separate chunk and shows plain text until it arrives, or for good if it fails to load. The Confirm summary adds <wbr> after @ and / so long emails and URLs break at those points. New Playwright tests cover both. The React e2e status line check now uses the ws-status-line__theme selector.

🤖 Generated with Claude Code

Workarounds still needed

0.6.1 does not cover these, so they stay in both apps. No new workarounds were added.

  • The calendar icon on the Vue date picker (--icon-calendar): the system has no calendar icon.
  • Field rows stack below 64rem: the system still has one breakpoint, so a tablet gets one field per line.
  • Icon sizes (the tick at 1rem, the danger icon at --ws-space-16, the radio dot at --ws-space-8): there is no icon size token. The usage guide says to draw the tick at 1rem.

Kept on purpose, because the 0.6.1 guide now says to do them this way:

  • The mark pulled out by --ws-space-4.
  • The Vite plugin that inlines the head scripts.
  • The NORMAL / INSERT mode.
  • The danger tokens for errors.
  • Shiki loaded lazily, which the React app already did and the Vue app now does too.

Visible changes

I screenshotted both apps on main and on this branch, in both themes, at 320, 390 and 1440 px, and pixel-diffed them. The tab bar, marks, ghost, status line (focus rings included) and wrapping code blocks are pixel-identical. Every change that does show is one the 0.5.0 to 0.6.1 upgrade notes intend:

  • Ticks on a checked box, a done step and a success title use --ws-icon-check: a 1.5 stroke instead of 2, and the tick on the success title is smaller.
  • The primary button's hover uses --ws-color-interactive-hover, and --ws-color-interactive-active while it is pressed.
  • React language switch (ws-segmented): the pressed language is raised with an interactive edge, not filled, and the labels are no longer semibold.
  • React order summary (ws-pairs--amounts): the total sits under a solid rule, and the rows are 3 px shorter.
  • Vue Confirm step (ws-pairs):
    • Each section's term column is as wide as its longest term (at most 40%), instead of a fixed 40/60 split.
    • Each section is its own list, so values no longer start at the same column from one section to the next. At 1280 px, "About you" values start at x=340 and "Your visit" values at x=508.
    • Rows are shorter.
    • A long email breaks after its @, not mid-word.
  • Vue code block: Shiki now loads lazily, as in React, so the submitted JSON shows as plain text until its colors arrive. If the highlighter fails to load, the JSON stays plain.

Design-system follow-ups

  • Confirm-step alignment across sections: ws-pairs sizes its term column per list. A review step with several sections could share one term column across its lists, so the values line up as they did with the old local rows. This PR adds no local override for it.
  • No calendar icon (see above).
  • No icon size token (see above).
  • No breakpoint for field rows (see above): rows of fields would fit from about 40rem, but the system's only breakpoint is 64rem.

Risk Assessment

✅ Low: The change is mostly styling and markup: both apps move to design-system 0.6.1 and drop local rules the release now ships (I checked the installed 0.6.1 CSS, tokens and usage guide), and the fix round's ghost-rule removal and Vue lazy-Shiki tests are correct and match the React app.

Testing

I ran both apps' Playwright e2e suites against their production builds; both passed (Vue 29, React 45, one intentional desktop-only skip each). I then served both builds and took screenshots in Chromium, in dark and light at 1280 px and at 320 px, checking the tab bar ghost logo per theme, the status line theme name, keyboard theme toggling with focus kept, colored Shiki code blocks that wrap long values at 320 px, and that nothing scrolls sideways or logs console errors. A focused probe of the Vue Confirm step showed the new <wbr> fix makes emails break after "@" with the text unchanged for copying and for screen readers. The same probe on a build without the fix reproduced the old mid-word break, so the fix is confirmed. All servers were stopped, and the build outputs and test results were removed from the worktree.

  • Live validation: ✅ go - 7 of 7 scenarios driven live against the product
Scenario Result Live Evidence
Both apps build and run on design-system 0.6.1: production builds of the Vue and React apps pass their e2e suites (desktop + Pixel 7) ✅ pass live vue-event-registration-e2e.log (29 passed, EXIT=0); react-checkout-e2e.log (45 passed, EXIT=0); installed design-system package.json version 0.6.1 in both apps
Vue Confirm at 320 px: a user who typed marko@example.com sees it break after the @ ('marko@' / 'example.com'), not mid-word ✅ pass live vue-narrow-320-short-email-dark-confirm.png, vue-narrow-320-short-email-light-confirm.png, vue-email-wrap-check.json; e2e registration.spec.ts:424 '320 px ... fits the screen at every step' passed on…
Regression: the same Vue Confirm flow at 320 px on a build without the fix breaks the email mid-word ('marko@example.co' / 'm') ✅ pass live before-email-fix/vue-email-wrap-check.json, before-email-fix/vue-narrow-320-short-email-dark-confirm.png
Adversarial: a very long email and a slash-separated value on the Vue Confirm step at 320 px stay inside the screen, and the text a user copies or a screen reader reads is exactly what was typed ✅ pass live vue-narrow-320-long-email-light-confirm.png, vue-email-wrap-check.json (textContent and innerText equal the input; aria snapshot 'definition: aleksandra.konstantinovic@events.example.co.rs'; sideways…
Tab bar and ghost logo on 0.6.1: each theme shows exactly one mark and one ghost, colored for that theme and vertically aligned, in both apps ✅ pass live vue-checks.json / react-checks.json (marksShown 1, ghostsShown 1, ghost fill e0def4 in dark and 575279 in light, ghost link display flex, offset 0); vue-desktop-dark-1-start.png, react-desktop-light-1…
Status line on 0.6.1: Enter on the theme button switches dark to light and back, shows one theme name, swaps the ghost and keeps focus, in both apps ✅ pass live vue-keyboard-theme-focus-statusline.png, react-keyboard-theme-focus-statusline.png, *-checks.json keyboard-theme-focus (rose-pine to rose-pine-dawn, focus-visible solid outline, focus stays on ws-stat…
Code block on 0.6.1: after submitting, the JSON is syntax-highlighted and long values wrap with a hanging indent inside the block at 320 px, with no sideways scroll, in both apps ✅ pass live vue-narrow-320-dark-3-done-code.png, react-narrow-320-dark-codeblock.png, -desktop--codeblock.png; *-checks.json (5 code colors, overflow 0 for html/.page/.ws-code/pre, wrapped lines present, JSON p…

Vue Confirm at 320 px, dark: short email breaks after @ (after fix)

Vue Confirm at 320 px, light: long email breaks at @, no sideways overflow (after fix)

Vue Confirm at 320 px, dark: mid-word break before the fix

Evidence: Email line breaks with the fix vs without it
after fix (320 px): ["marko@", "example.com"] wbr=1 textContent="marko@example.com" aria="definition: marko@example.com"
before fix (320 px): ["marko@example.co", "m"] wbr=0
long email after: ["aleksandra.konstanti", "novic@", "events.example.co.rs"] (local part alone is wider than the column)
long email before: ["aleksandra.konstanti", "novic@events.examp", "le.co.rs"]
Evidence: Vue email-wrap probe results (after fix)
{
  "narrow-320-short-email-dark": {
    "email": "marko@example.com",
    "emailLines": [
      "marko@",
      "example.com"
    ],
    "emailTextContent": "marko@example.com",
    "emailInnerText": "marko@example.com",
    "emailWbrCount": 1,
    "emailAccessibleText": "- definition: marko@example.com",
    "needsLines": [
      "vegan/gluten-",
      "free/no-nuts, a ",
      "step-free route to ",
      "the hall"
    ],
    "needsTextContent": "vegan/gluten-free/no-nuts, a step-free route to the hall",
    "needsMatchesInput": true,
    "emailMatchesInput": true,
    "sidewaysScroll": 0,
    "ddOverflow": 0,
    "screenshot": "vue-narrow-320-short-email-dark-confirm.png",
    "errors": []
  },
  "narrow-320-short-email-light": {
    "email": "marko@example.com",
    "emailLines": [
      "marko@",
      "example.com"
    ],
    "emailTextContent": "marko@example.com",
    "emailInnerText": "marko@example.com",
    "emailWbrCount": 1,
    "emailAccessibleText": "- definition: marko@example.com",
    "needsLines": [
      "vegan/gluten-",
      "free/no-nuts, a ",
      "step-free route to ",
      "the hall"
    ],
    "needsTextContent": "vegan/gluten-free/no-nuts, a step-free route to the hall",
    "needsMatchesInput": true,
    "emailMatchesInput": true,
    "sidewaysScroll": 0,
    "ddOverflow": 0,
    "screenshot": "vue-narrow-320-short-email-light-confirm.png",
    "errors": []
  },
  "narrow-320-long-email-dark": {
    "email": "aleksandra.konstantinovic@events.example.co.rs",
    "emailLines": [
      "aleksandra.konstanti",
      "novic@",
      "events.example.co.rs"
    ],
    "emailTextContent": "aleksandra.konstantinovic@events.example.co.rs",
    "emailInnerText": "aleksandra.konstantinovic@events.example.co.rs",
    "emailWbrCount": 1,
    "emailAccessibleText": "- definition: aleksandra.konstantinovic@events.example.co.rs",
    "needsLines": [
      "vegan/gluten-",
      "free/no-nuts, a ",
      "step-free route to ",
      "the hall"
    ],
    "needsTextContent": "vegan/gluten-free/no-nuts, a step-free route to the hall",
    "needsMatchesInput": true,
    "emailMatchesInput": true,
    "sidewaysScroll": 0,
    "ddOverflow": 0,
    "screenshot": "vue-narrow-320-long-email-dark-confirm.png",
    "errors": []
  },
  "narrow-320-long-email-light": {
    "email": "aleksandra.konstantinovic@events.example.co.rs",
    "emailLines": [
      "aleksandra.konstanti",
      "novic@",
      "events.example.co.rs"
    ],
    "emailTextContent": "aleksandra.konstantinovic@events.example.co.rs",
    "emailInnerText": "aleksandra.konstantinovic@events.example.co.rs",
    "emailWbrCount": 1,
    "emailAccessibleText": "- definition: aleksandra.konstantinovic@events.example.co.rs",
    "needsLines": [
      "vegan/gluten-",
      "free/no-nuts, a ",
      "step-free route to ",
      "the hall"
    ],
    "needsTextContent": "vegan/gluten-free/no-nuts, a step-free route to the hall",
    "needsMatchesInput": true,
    "emailMatchesInput": true,
    "sidewaysScroll": 0,
    "ddOverflow": 0,
    "screenshot": "vue-narrow-320-long-email-light-confirm.png",
    "errors": []
  },
  "desktop-1280-long-email-dark": {
    "email": "aleksandra.konstantinovic@events.example.co.rs",
    "emailLines": [
      "aleksandra.konstantinovic@events.example.co.rs"
    ],
    "emailTextContent": "aleksandra.konstantinovic@events.example.co.rs",
    "emailInnerText": "aleksandra.konstantinovic@events.example.co.rs",
    "emailWbrCount": 1,
    "emailAccessibleText": "- definition: aleksandra.konstantinovic@events.example.co.rs",
    "needsLines": [
      "vegan/gluten-free/no-nuts, a step-free route to the hall"
    ],
    "needsTextContent": "vegan/gluten-free/no-nuts, a step-free route to the hall",
    "needsMatchesInput": true,
    "emailMatchesInput": true,
    "sidewaysScroll": 0,
    "ddOverflow": 0,
    "screenshot": "vue-desktop-1280-long-email-dark-confirm.png",
    "errors": []
  },
  "desktop-1280-long-email-light": {
    "email": "aleksandra.konstantinovic@events.example.co.rs",
    "emailLines": [
      "aleksandra.konstantinovic@events.example.co.rs"
    ],
    "emailTextContent": "aleksandra.konstantinovic@events.example.co.rs",
    "emailInnerText": "aleksandra.konstantinovic@events.example.co.rs",
    "emailWbrCount": 1,
    "emailAccessibleText": "- definition: aleksandra.konstantinovic@events.example.co.rs",
    "needsLines": [
      "vegan/gluten-free/no-nuts, a step-free route to the hall"
    ],
    "needsTextContent": "vegan/gluten-free/no-nuts, a step-free route to the hall",
    "needsMatchesInput": true,
    "emailMatchesInput": true,
    "sidewaysScroll": 0,
    "ddOverflow": 0,
    "screenshot": "vue-desktop-1280-long-email-light-confirm.png",
    "errors": []
  }
}
Evidence: Vue email-wrap probe results (before fix)
{
  "narrow-320-short-email-dark": {
    "email": "marko@example.com",
    "emailLines": [
      "marko@example.co",
      "m"
    ],
    "emailTextContent": "marko@example.com",
    "emailInnerText": "marko@example.com",
    "emailWbrCount": 0,
    "emailAccessibleText": "- definition: marko@example.com",
    "needsLines": [
      "vegan/gluten-",
      "free/no-nuts, a ",
      "step-free route to ",
      "the hall"
    ],
    "needsTextContent": "vegan/gluten-free/no-nuts, a step-free route to the hall",
    "needsMatchesInput": true,
    "emailMatchesInput": true,
    "sidewaysScroll": 0,
    "ddOverflow": 0,
    "screenshot": "vue-narrow-320-short-email-dark-confirm.png",
    "errors": []
  },
  "narrow-320-short-email-light": {
    "email": "marko@example.com",
    "emailLines": [
      "marko@example.co",
      "m"
    ],
    "emailTextContent": "marko@example.com",
    "emailInnerText": "marko@example.com",
    "emailWbrCount": 0,
    "emailAccessibleText": "- definition: marko@example.com",
    "needsLines": [
      "vegan/gluten-",
      "free/no-nuts, a ",
      "step-free route to ",
      "the hall"
    ],
    "needsTextContent": "vegan/gluten-free/no-nuts, a step-free route to the hall",
    "needsMatchesInput": true,
    "emailMatchesInput": true,
    "sidewaysScroll": 0,
    "ddOverflow": 0,
    "screenshot": "vue-narrow-320-short-email-light-confirm.png",
    "errors": []
  },
  "narrow-320-long-email-dark": {
    "email": "aleksandra.konstantinovic@events.example.co.rs",
    "emailLines": [
      "aleksandra.konstanti",
      "novic@events.examp",
      "le.co.rs"
    ],
    "emailTextContent": "aleksandra.konstantinovic@events.example.co.rs",
    "emailInnerText": "aleksandra.konstantinovic@events.example.co.rs",
    "emailWbrCount": 0,
    "emailAccessibleText": "- definition: aleksandra.konstantinovic@events.example.co.rs",
    "needsLines": [
      "vegan/gluten-",
      "free/no-nuts, a ",
      "step-free route to ",
      "the hall"
    ],
    "needsTextContent": "vegan/gluten-free/no-nuts, a step-free route to the hall",
    "needsMatchesInput": true,
    "emailMatchesInput": true,
    "sidewaysScroll": 0,
    "ddOverflow": 0,
    "screenshot": "vue-narrow-320-long-email-dark-confirm.png",
    "errors": []
  },
  "narrow-320-long-email-light": {
    "email": "aleksandra.konstantinovic@events.example.co.rs",
    "emailLines": [
      "aleksandra.konstanti",
      "novic@events.examp",
      "le.co.rs"
    ],
    "emailTextContent": "aleksandra.konstantinovic@events.example.co.rs",
    "emailInnerText": "aleksandra.konstantinovic@events.example.co.rs",
    "emailWbrCount": 0,
    "emailAccessibleText": "- definition: aleksandra.konstantinovic@events.example.co.rs",
    "needsLines": [
      "vegan/gluten-",
      "free/no-nuts, a ",
      "step-free route to ",
      "the hall"
    ],
    "needsTextContent": "vegan/gluten-free/no-nuts, a step-free route to the hall",
    "needsMatchesInput": true,
    "emailMatchesInput": true,
    "sidewaysScroll": 0,
    "ddOverflow": 0,
    "screenshot": "vue-narrow-320-long-email-light-confirm.png",
    "errors": []
  },
  "desktop-1280-long-email-dark": {
    "email": "aleksandra.konstantinovic@events.example.co.rs",
    "emailLines": [
      "aleksandra.konstantinovic@events.example.co.rs"
    ],
    "emailTextContent": "aleksandra.konstantinovic@events.example.co.rs",
    "emailInnerText": "aleksandra.konstantinovic@events.example.co.rs",
    "emailWbrCount": 0,
    "emailAccessibleText": "- definition: aleksandra.konstantinovic@events.example.co.rs",
    "needsLines": [
      "vegan/gluten-free/no-nuts, a step-free route to the hall"
    ],
    "needsTextContent": "vegan/gluten-free/no-nuts, a step-free route to the hall",
    "needsMatchesInput": true,
    "emailMatchesInput": true,
    "sidewaysScroll": 0,
    "ddOverflow": 0,
    "screenshot": "vue-desktop-1280-long-email-dark-confirm.png",
    "errors": []
  },
  "desktop-1280-long-email-light": {
    "email": "aleksandra.konstantinovic@events.example.co.rs",
    "emailLines": [
      "aleksandra.konstantinovic@events.example.co.rs"
    ],
    "emailTextContent": "aleksandra.konstantinovic@events.example.co.rs",
    "emailInnerText": "aleksandra.konstantinovic@events.example.co.rs",
    "emailWbrCount": 0,
    "emailAccessibleText": "- definition: aleksandra.konstantinovic@events.example.co.rs",
    "needsLines": [
      "vegan/gluten-free/no-nuts, a step-free route to the hall"
    ],
    "needsTextContent": "vegan/gluten-free/no-nuts, a step-free route to the hall",
    "needsMatchesInput": true,
    "emailMatchesInput": true,
    "sidewaysScroll": 0,
    "ddOverflow": 0,
    "screenshot": "vue-desktop-1280-long-email-light-confirm.png",
    "errors": []
  }
}
Evidence: Vue e2e run against production build
[WebServer] $ vue-tsc -b && vite build

Running 30 tests using 4 workers

  ✓   4 [desktop] › e2e/frame.spec.ts:144:3 › on a dark system › switches the theme with the t key while the keys are on (2.1s)
  ✓   1 [desktop] › e2e/frame.spec.ts:115:1 › switches the shortcut keys off and on, and remembers it (2.3s)
  ✓   2 [desktop] › e2e/frame.spec.ts:88:3 › on a light system › switches the theme, and remembers it (2.5s)
  ✓   7 [desktop] › e2e/registration.spec.ts:227:1 › shows the registration as plain text until its highlighter loads, then in color (2.5s)
  ✓   3 [desktop] › e2e/frame.spec.ts:184:5 › in the dark theme › keeps the status line whole on a narrow screen (5.5s)
  ✓   6 [desktop] › e2e/registration.spec.ts:103:1 › registers a business attendee with guests, step by step (4.1s)
  ✓   5 [desktop] › e2e/frame.spec.ts:184:5 › in the light theme › keeps the status line whole on a narrow screen (4.9s)
  ✓   8 [desktop] › e2e/registration.spec.ts:257:1 › shows the registration as plain text when its highlighter does not load (2.3s)
  ✓  10 [desktop] › e2e/registration.spec.ts:362:1 › clears what a condition hides (2.0s)
  ✓  11 [desktop] › e2e/registration.spec.ts:393:1 › moves with Enter and with the step indicator (1.6s)
  ✓   9 [desktop] › e2e/registration.spec.ts:274:1 › keeps the user on a step until its fields are valid (3.5s)
  ✓  12 [desktop] › e2e/registration.spec.ts:424:7 › on a 320 px screen, in the dark theme › fits the screen at every step, with its errors (4.5s)
  ✓  14 [desktop] › e2e/registration.spec.ts:424:7 › on a 390 px screen, in the dark theme › fits the screen at every step, with its errors (4.0s)
  ✓  15 [desktop] › e2e/registration.spec.ts:424:7 › on a 390 px screen, in the light theme › fits the screen at every step, with its errors (3.7s)
  ✓  13 [desktop] › e2e/registration.spec.ts:424:7 › on a 320 px screen, in the light theme › fits the screen at every step, with its errors (4.5s)
  ✓  16 [mobile] › e2e/frame.spec.ts:88:3 › on a light system › switches the theme, and remembers it (1.2s)
  -  18 [mobile] › e2e/frame.spec.ts:144:3 › on a dark system › switches the theme with the t key while the keys are on
  ✓  17 [mobile] › e2e/frame.spec.ts:115:1 › switches the shortcut keys off and on, and remembers it (2.0s)
  ✓  22 [mobile] › e2e/registration.spec.ts:227:1 › shows the registration as plain text until its highlighter loads, then in color (1.9s)
  ✓  20 [mobile] › e2e/frame.spec.ts:184:5 › in the light theme › keeps the status line whole on a narrow screen (4.1s)
  ✓  19 [mobile] › e2e/frame.spec.ts:184:5 › in the dark theme › keeps the status line whole on a narrow screen (4.4s)
  ✓  21 [mobile] › e2e/registration.spec.ts:103:1 › registers a business attendee with guests, step by step (3.8s)
  ✓  23 [mobile] › e2e/registration.spec.ts:257:1 › shows the registration as plain text when its highlighter does not load (2.2s)
  ✓  26 [mobile] › e2e/registration.spec.ts:393:1 › moves with Enter and with the step indicator (1.4s)
  ✓  25 [mobile] › e2e/registration.spec.ts:362:1 › clears what a condition hides (2.2s)
  ✓  24 [mobile] › e2e/registration.spec.ts:274:1 › keeps the user on a step until its fields are valid (3.9s)
  ✓  27 [mobile] › e2e/registration.spec.ts:424:7 › on a 320 px screen, in the dark theme › fits the screen at every step, with its errors (4.6s)
  ✓  28 [mobile] › e2e/registration.spec.ts:424:7 › on a 320 px screen, in the light theme › fits the screen at every step, with its errors (4.7s)
  ✓  29 [mobile] › e2e/registration.spec.ts:424:7 › on a 390 px screen, in the dark theme › fits the screen at every step, with its errors (4.3s)
  ✓  30 [mobile] › e2e/registration.spec.ts:424:7 › on a 390 px screen, in the light theme › fits the screen at every step, with its errors (4.3s)

  1 skipped
  29 passed (35.0s)
EXIT=0
Evidence: React e2e run against production build
[WebServer] $ tsc -b && vite build
[WebServer] $ tsx server/index.ts dist

Running 46 tests using 4 workers

  ✓   3 [desktop] › e2e/checkout.spec.ts:144:1 › stops an invalid order in the browser, before it reaches the server (3.2s)
  ✓   1 [desktop] › e2e/checkout.spec.ts:81:1 › keeps the order button faint while it is sent, under the pointer too (3.5s)
  ✓   4 [desktop] › e2e/checkout.spec.ts:32:1 › places an order that the server validates and prices again (3.8s)
  ✓   2 [desktop] › e2e/checkout.spec.ts:115:1 › shows the order as plain text when its highlighter does not load (4.0s)
  ✓   8 [desktop] › e2e/checkout.spec.ts:314:1 › the server rejects invalid data sent straight to its API (1.2s)
  ✓   6 [desktop] › e2e/checkout.spec.ts:210:1 › shows the server rejecting an order that got past the browser (2.3s)
  ✓   5 [desktop] › e2e/checkout.spec.ts:183:1 › shows the fields a condition asks for, and drops what it hides (2.5s)
  ✓   7 [desktop] › e2e/checkout.spec.ts:256:1 › speaks German in the browser and on the server, and keeps the input (2.7s)
  ✓   9 [desktop] › e2e/checkout.spec.ts:351:5 › on a 320 px screen, in the dark theme › fits the screen in English and in German, with its errors (3.1s)
  ✓  10 [desktop] › e2e/checkout.spec.ts:351:5 › on a 320 px screen, in the light theme › fits the screen in English and in German, with its errors (2.6s)
  ✓  11 [desktop] › e2e/checkout.spec.ts:351:5 › on a 390 px screen, in the dark theme › fits the screen in English and in German, with its errors (2.7s)
  ✓  12 [desktop] › e2e/checkout.spec.ts:351:5 › on a 390 px screen, in the light theme › fits the screen in English and in German, with its errors (3.1s)
  ✓  15 [desktop] › e2e/frame.spec.ts:85:3 › on a dark system › switches the theme with the t key while the keys are on (1.7s)
  ✓  13 [desktop] › e2e/frame.spec.ts:29:3 › on a light system › switches the theme, and remembers it (2.0s)
  ✓  14 [desktop] › e2e/frame.spec.ts:56:1 › switches the shortcut keys off and on, and remembers it (1.9s)
  ✓  18 [desktop] › e2e/frame.spec.ts:190:5 › in forced colors, on a light system › tells the pressed language and a ticked box from the others (1.5s)
  ✓  19 [desktop] › e2e/frame.spec.ts:220:5 › in forced colors, on a light system › shows the name of each language, pressed or not (2.4s)
  ✓  20 [desktop] › e2e/frame.spec.ts:238:5 › in forced colors, on a light system › rings the pressed language in focus as it rings the other (1.8s)
  ✓  21 [desktop] › e2e/frame.spec.ts:190:5 › in forced colors, on a dark system › tells the pressed language and a ticked box from the others (1.6s)
  ✓  22 [desktop] › e2e/frame.spec.ts:220:5 › in forced colors, on a dark system › shows the name of each language, pressed or not (2.0s)
  ✓  23 [desktop] › e2e/frame.spec.ts:238:5 › in forced colors, on a dark system › rings the pressed language in focus as it rings the other (1.4s)
  ✓  16 [desktop] › e2e/frame.spec.ts:125:5 › in the dark theme › keeps the status line whole on a narrow screen (6.8s)
  ✓  17 [desktop] › e2e/frame.spec.ts:125:5 › in the light theme › keeps the status line whole on a narrow screen (6.6s)
  ✓  25 [mobile] › e2e/checkout.spec.ts:81:1 › keeps the order button faint while it is sent, under the pointer too (3.4s)
  ✓  24 [mobile] › e2e/checkout.spec.ts:32:1 › places an order that the server validates and prices again (4.0s)
  ✓  27 [mobile] › e2e/checkout.spec.ts:144:1 › stops an invalid order in the browser, before it reaches the server (3.0s)
  ✓  26 [mobile] › e2e/checkout.spec.ts:115:1 › shows the order as plain text when its highlighter does not load (4.1s)
  ✓  31 [mobile] › e2e/checkout.spec.ts:314:1 › the server rejects invalid data sent straight to its API (1.2s)
  ✓  28 [mobile] › e2e/checkout.spec.ts:183:1 › shows the fields a condition asks for, and drops what it hides (3.0s)
  ✓  29 [mobile] › e2e/checkout.spec.ts:210:1 › shows the server rejecting an order that got past the browser (2.7s)
  ✓  30 [mobile] › e2e/checkout.spec.ts:256:1 › speaks German in the browser and on the server, and keeps the input (2.9s)
  ✓  32 [mobile] › e2e/checkout.spec.ts:351:5 › on a 320 px screen, in the dark theme › fits the screen in English and in German, with its errors (3.2s)
  ✓  33 [mobile] › e2e/checkout.spec.ts:351:5 › on a 320 px screen, in the light theme › fits the screen in English and in German, with its errors (2.7s)
  ✓  34 [mobile] › e2e/checkout.spec.ts:351:5 › on a 390 px screen, in the dark theme › fits the screen in English and in German, with its errors (2.8s)
  ✓  35 [mobile] › e2e/checkout.spec.ts:351:5 › on a 390 px screen, in the light theme › fits the screen in English and in German, with its errors (2.4s)
  -  38 [mobile] › e2e/frame.spec.ts:85:3 › on a dark system › switches the theme with the t key while the keys are on
  ✓  37 [mobile] › e2e/frame.spec.ts:56:1 › switches the shortcut keys off and on, and remembers it (1.7s)
  ✓  36 [mobile] › e2e/frame.spec.ts:29:3 › on a light system › switches the theme, and remembers it (1.8s)
  ✓  41 [mobile] › e2e/frame.spec.ts:190:5 › in forced colors, on a light system › tells the pressed language and a ticked box from the others (1.1s)
  ✓  42 [mobile] › e2e/frame.spec.ts:220:5 › in forced colors, on a light system › shows the name of each language, pressed or not (2.0s)
  ✓  43 [mobile] › e2e/frame.spec.ts:238:5 › in forced colors, on a light system › rings the pressed language in focus as it rings the other (1.4s)
  ✓  44 [mobile] › e2e/frame.spec.ts:190:5 › in forced colors, on a dark system › tells the pressed language and a ticked box from the others (1.2s)
  ✓  46 [mobile] › e2e/frame.spec.ts:238:5 › in forced colors, on a dark system › rings the pressed language in focus as it rings the other (1.1s)
  ✓  45 [mobile] › e2e/frame.spec.ts:220:5 › in forced colors, on a dark system › shows the name of each language, pressed or not (2.0s)
  ✓  39 [mobile] › e2e/frame.spec.ts:125:5 › in the dark theme › keeps the status line whole on a narrow screen (5.7s)
  ✓  40 [mobile] › e2e/frame.spec.ts:125:5 › in the light theme › keeps the status line whole on a narrow screen (5.6s)

  1 skipped
  45 passed (42.0s)
EXIT=0

Vue start page at 1280 px, dark (tab bar, ghost, status line)

React start page at 1280 px, light (tab bar, ghost, status line)

Vue done page at 320 px: highlighted JSON wraps long values

React order code block at 320 px: wrapped, highlighted

Vue keyboard theme toggle keeps focus (status line)

React keyboard theme toggle keeps focus (status line)

Evidence: Vue computed checks (images per theme, overflow, code colors, focus)
{
  "desktop-dark": {
    "images": {
      "dataTheme": null,
      "marksShown": 1,
      "ghostsShown": 1,
      "shownGhostSrc": "data:image/svg+xml,%3csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%2020%2024'%20width='20'%20height='24'%20role='img'%20aria-label='whatsaaaa%20ghost'%3e%3ctitle%3ewhatsaaaa%20ghost%3c/title%3e%3cg%20shape-rendering='crispEdges'%3e%3cpath%20d='M4%200h12v2h-12zM2%202h16v2h-16zM0%204h20v2h-20zM0%206h4v2h-4zM8%206h4v2h-4zM16%206h4v2h-4zM0%208h4v2h-4zM8%208h4v2h-4zM16%208h4v2h-4zM0%2010h20v2h-20zM0%2012h4v2h-4zM6%2012h2v2h-2zM12%2012h2v2h-2zM16%2012h4v2h-4zM0%2014h6v2h-6zM14%2014h6v2h-6zM0%2016h8v2h-8zM12%2016h8v2h-8zM0%2018h20v2h-20zM0%2020h8v2h-8zM12%2020h8v2h-8zM2%2022h4v2h-4zM14%2022h4v2h-4z'%20fill='%23e0def4'/%3e%3cpath%20d='M8%2014h4v2h-4zM8%2016h4v2h-4z'%20fill='%23eb6f92'/%3e%3c/g%3e%3c/svg%3e",
      "ghostLinkDisplay": "flex",
      "ghostLinkHeight": 24,
      "ghostImgHeight": 24,
      "ghostVerticalOffsetInLink": 0,
      "themeNamesShown": [
        "rose-pine"
      ]
    },
    "codeColors": 5,
    "overflow": {
      "html": 0,
      ".page": 0,
      ".page__main": 0,
      ".ws-status-line": 0,
      ".ws-code": 0,
      ".ws-code > pre": 0
    },
    "summaryShot": true,
    "errors": []
  },
  "desktop-light": {
    "images": {
      "dataTheme": null,
      "marksShown": 1,
      "ghostsShown": 1,
      "shownGhostSrc": "data:image/svg+xml,%3csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%2020%2024'%20width='20'%20height='24'%20role='img'%20aria-label='whatsaaaa%20ghost'%3e%3ctitle%3ewhatsaaaa%20ghost%3c/title%3e%3cg%20shape-rendering='crispEdges'%3e%3cpath%20d='M4%200h12v2h-12zM2%202h16v2h-16zM0%204h20v2h-20zM0%206h4v2h-4zM8%206h4v2h-4zM16%206h4v2h-4zM0%208h4v2h-4zM8%208h4v2h-4zM16%208h4v2h-4zM0%2010h20v2h-20zM0%2012h4v2h-4zM6%2012h2v2h-2zM12%2012h2v2h-2zM16%2012h4v2h-4zM0%2014h6v2h-6zM14%2014h6v2h-6zM0%2016h8v2h-8zM12%2016h8v2h-8zM0%2018h20v2h-20zM0%2020h8v2h-8zM12%2020h8v2h-8zM2%2022h4v2h-4zM14%2022h4v2h-4z'%20fill='%23575279'/%3e%3cpath%20d='M8%2014h4v2h-4zM8%2016h4v2h-4z'%20fill='%23b4637a'/%3e%3c/g%3e%3c/svg%3e",
      "ghostLinkDisplay": "flex",
      "ghostLinkHeight": 24,
      "ghostImgHeight": 24,
      "ghostVerticalOffsetInLink": 0,
      "themeNamesShown": [
        "rose-pine-dawn"
      ]
    },
    "codeColors": 5,
    "overflow": {
      "html": 0,
      ".page": 0,
      ".page__main": 0,
      ".ws-status-line": 0,
      ".ws-code": 0,
      ".ws-code > pre": 0
    },
    "summaryShot": true,
    "errors": []
  },
  "narrow-320-dark-long": {
    "overflow": {
      "html": 0,
      ".page": 0,
      ".page__main": 0,
      ".ws-status-line": 0,
      ".ws-code": 0,
      ".ws-code > pre": 0
    },
    "wrapped": [
      {
        "text": "\"lastName\": \"Petrović-Aleksandrović-Konstantinović",
        "rows": 4,
        "paddingLeft": "31.2px",
        "textIndent": "-31.2px"
      },
      {
        "text": "\"email\": \"marko@example.com\",",
        "rows": 2,
        "paddingLeft": "31.2px",
        "textIndent": "-31.2px"
      }
    ],
    "parsedKeys": [
      "firstName",
      "lastName",
      "email",
      "ticketType",
      "arrival",
      "departure",
      "sessions",
      "needsAssistance",
      "guests",
      "company",
      "billingAddress",
      "acceptTerms",
      "newsletter"
    ],
    "errors": []
  },
  "keyboard-theme-focus": {
    "before": {
      "dataTheme": null,
      "marksShown": 1,
      "ghostsShown": 1,
      "shownGhostSrc": "data:image/svg+xml,%3csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%2020%2024'%20width='20'%20height='24'%20role='img'%20aria-label='whatsaaaa%20ghost'%3e%3ctitle%3ewhatsaaaa%20ghost%3c/title%3e%3cg%20shape-rendering='crispEdges'%3e%3cpath%20d='M4%200h12v2h-12zM2%202h16v2h-16zM0%204h20v2h-20zM0%206h4v2h-4zM8%206h4v2h-4zM16%206h4v2h-4zM0%208h4v2h-4zM8%208h4v2h-4zM16%208h4v2h-4zM0%2010h20v2h-20zM0%2012h4v2h-4zM6%2012h2v2h-2zM12%2012h2v2h-2zM16%2012h4v2h-4zM0%2014h6v2h-6zM14%2014h6v2h-6zM0%2016h8v2h-8zM12%2016h8v2h-8zM0%2018h20v2h-20zM0%2020h8v2h-8zM12%2020h8v2h-8zM2%2022h4v2h-4zM14%2022h4v2h-4z'%20fill='%23e0def4'/%3e%3cpath%20d='M8%2014h4v2h-4zM8%2016h4v2h-4z'%20fill='%23eb6f92'/%3e%3c/g%3e%3c/svg%3e",
      "ghostLinkDisplay": "flex",
      "ghostLinkHeight": 24,
      "ghostImgHeight": 24,
      "ghostVerticalOffsetInLink": 0,
      "themeNamesShown": [
        "rose-pine"
      ]
    },
    "after": {
      "dataTheme": "light",
      "marksShown": 1,
      "ghostsShown": 1,
      "shownGhostSrc": "data:image/svg+xml,%3csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%2020%2024'%20width='20'%20height='24'%20role='img'%20aria-label='whatsaaaa%20ghost'%3e%3ctitle%3ewhatsaaaa%20ghost%3c/title%3e%3cg%20shape-rendering='crispEdges'%3e%3cpath%20d='M4%200h12v2h-12zM2%202h16v2h-16zM0%204h20v2h-20zM0%206h4v2h-4zM8%206h4v2h-4zM16%206h4v2h-4zM0%208h4v2h-4zM8%208h4v2h-4zM16%208h4v2h-4zM0%2010h20v2h-20zM0%2012h4v2h-4zM6%2012h2v2h-2zM12%2012h2v2h-2zM16%2012h4v2h-4zM0%2014h6v2h-6zM14%2014h6v2h-6zM0%2016h8v2h-8zM12%2016h8v2h-8zM0%2018h20v2h-20zM0%2020h8v2h-8zM12%2020h8v2h-8zM2%2022h4v2h-4zM14%2022h4v2h-4z'%20fill='%23575279'/%3e%3cpath%20d='M8%2014h4v2h-4zM8%2016h4v2h-4z'%20fill='%23b4637a'/%3e%3c/g%3e%3c/svg%3e",
      "ghostLinkDisplay": "flex",
      "ghostLinkHeight": 24,
      "ghostImgHeight": 24,
      "ghostVerticalOffsetInLink": 0,
      "themeNamesShown": [
        "rose-pine-dawn"
      ]
    },
    "focus": {
      "activeClass": "ws-status-line__theme",
      "accessibleText": "Switch theme, now rose-pinerose-pine-dawn",
      "focusVisible": true,
      "outline": "solid"
    },
    "focusAfterSecondToggle": "ws-status-line__theme",
    "errors": []
  }
}
Evidence: React computed checks (images per theme, overflow, code colors, focus)
{
  "desktop-dark": {
    "images": {
      "dataTheme": null,
      "marksShown": 1,
      "ghostsShown": 1,
      "shownGhostSrc": "data:image/svg+xml,%3csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%2020%2024'%20width='20'%20height='24'%20role='img'%20aria-label='whatsaaaa%20ghost'%3e%3ctitle%3ewhatsaaaa%20ghost%3c/title%3e%3cg%20shape-rendering='crispEdges'%3e%3cpath%20d='M4%200h12v2h-12zM2%202h16v2h-16zM0%204h20v2h-20zM0%206h4v2h-4zM8%206h4v2h-4zM16%206h4v2h-4zM0%208h4v2h-4zM8%208h4v2h-4zM16%208h4v2h-4zM0%2010h20v2h-20zM0%2012h4v2h-4zM6%2012h2v2h-2zM12%2012h2v2h-2zM16%2012h4v2h-4zM0%2014h6v2h-6zM14%2014h6v2h-6zM0%2016h8v2h-8zM12%2016h8v2h-8zM0%2018h20v2h-20zM0%2020h8v2h-8zM12%2020h8v2h-8zM2%2022h4v2h-4zM14%2022h4v2h-4z'%20fill='%23e0def4'/%3e%3cpath%20d='M8%2014h4v2h-4zM8%2016h4v2h-4z'%20fill='%23eb6f92'/%3e%3c/g%3e%3c/svg%3e",
      "ghostLinkDisplay": "flex",
      "ghostLinkHeight": 24,
      "ghostImgHeight": 24,
      "ghostVerticalOffsetInLink": 0,
      "themeNamesShown": [
        "rose-pine"
      ]
    },
    "codeColors": 5,
    "overflow": {
      "html": 0,
      ".page": 0,
      ".page__main": 0,
      ".ws-status-line": 0,
      ".ws-code": 0,
      ".ws-code > pre": 0
    },
    "errors": []
  },
  "desktop-light": {
    "images": {
      "dataTheme": null,
      "marksShown": 1,
      "ghostsShown": 1,
      "shownGhostSrc": "data:image/svg+xml,%3csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%2020%2024'%20width='20'%20height='24'%20role='img'%20aria-label='whatsaaaa%20ghost'%3e%3ctitle%3ewhatsaaaa%20ghost%3c/title%3e%3cg%20shape-rendering='crispEdges'%3e%3cpath%20d='M4%200h12v2h-12zM2%202h16v2h-16zM0%204h20v2h-20zM0%206h4v2h-4zM8%206h4v2h-4zM16%206h4v2h-4zM0%208h4v2h-4zM8%208h4v2h-4zM16%208h4v2h-4zM0%2010h20v2h-20zM0%2012h4v2h-4zM6%2012h2v2h-2zM12%2012h2v2h-2zM16%2012h4v2h-4zM0%2014h6v2h-6zM14%2014h6v2h-6zM0%2016h8v2h-8zM12%2016h8v2h-8zM0%2018h20v2h-20zM0%2020h8v2h-8zM12%2020h8v2h-8zM2%2022h4v2h-4zM14%2022h4v2h-4z'%20fill='%23575279'/%3e%3cpath%20d='M8%2014h4v2h-4zM8%2016h4v2h-4z'%20fill='%23b4637a'/%3e%3c/g%3e%3c/svg%3e",
      "ghostLinkDisplay": "flex",
      "ghostLinkHeight": 24,
      "ghostImgHeight": 24,
      "ghostVerticalOffsetInLink": 0,
      "themeNamesShown": [
        "rose-pine-dawn"
      ]
    },
    "codeColors": 5,
    "overflow": {
      "html": 0,
      ".page": 0,
      ".page__main": 0,
      ".ws-status-line": 0,
      ".ws-code": 0,
      ".ws-code > pre": 0
    },
    "errors": []
  },
  "narrow-320-dark-long": {
    "overflow": {
      "html": 0,
      ".page": 0,
      ".page__main": 0,
      ".ws-status-line": 0,
      ".ws-code": 0,
      ".ws-code > pre": 0
    },
    "wrapped": [
      {
        "text": "\"email\": \"jelena@example.com\",",
        "rows": 2,
        "paddingLeft": "31.2px",
        "textIndent": "-31.2px"
      },
      {
        "text": "\"fullName\": \"Jelena Jovanović-Aleksandrović-Konsta",
        "rows": 5,
        "paddingLeft": "46.8px",
        "textIndent": "-46.8px"
      },
      {
        "text": "\"street\": \"Bulevar kralja Aleksandra 1234567890123",
        "rows": 4,
        "paddingLeft": "46.8px",
        "textIndent": "-46.8px"
      }
    ],
    "parsedKeys": [
      "email",
      "lines",
      "delivery",
      "shipping",
      "paymentMethod",
      "acceptTerms"
    ],
    "errors": []
  },
  "keyboard-theme-focus": {
    "before": {
      "dataTheme": null,
      "marksShown": 1,
      "ghostsShown": 1,
      "shownGhostSrc": "data:image/svg+xml,%3csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%2020%2024'%20width='20'%20height='24'%20role='img'%20aria-label='whatsaaaa%20ghost'%3e%3ctitle%3ewhatsaaaa%20ghost%3c/title%3e%3cg%20shape-rendering='crispEdges'%3e%3cpath%20d='M4%200h12v2h-12zM2%202h16v2h-16zM0%204h20v2h-20zM0%206h4v2h-4zM8%206h4v2h-4zM16%206h4v2h-4zM0%208h4v2h-4zM8%208h4v2h-4zM16%208h4v2h-4zM0%2010h20v2h-20zM0%2012h4v2h-4zM6%2012h2v2h-2zM12%2012h2v2h-2zM16%2012h4v2h-4zM0%2014h6v2h-6zM14%2014h6v2h-6zM0%2016h8v2h-8zM12%2016h8v2h-8zM0%2018h20v2h-20zM0%2020h8v2h-8zM12%2020h8v2h-8zM2%2022h4v2h-4zM14%2022h4v2h-4z'%20fill='%23e0def4'/%3e%3cpath%20d='M8%2014h4v2h-4zM8%2016h4v2h-4z'%20fill='%23eb6f92'/%3e%3c/g%3e%3c/svg%3e",
      "ghostLinkDisplay": "flex",
      "ghostLinkHeight": 24,
      "ghostImgHeight": 24,
      "ghostVerticalOffsetInLink": 0,
      "themeNamesShown": [
        "rose-pine"
      ]
    },
    "after": {
      "dataTheme": "light",
      "marksShown": 1,
      "ghostsShown": 1,
      "shownGhostSrc": "data:image/svg+xml,%3csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%2020%2024'%20width='20'%20height='24'%20role='img'%20aria-label='whatsaaaa%20ghost'%3e%3ctitle%3ewhatsaaaa%20ghost%3c/title%3e%3cg%20shape-rendering='crispEdges'%3e%3cpath%20d='M4%200h12v2h-12zM2%202h16v2h-16zM0%204h20v2h-20zM0%206h4v2h-4zM8%206h4v2h-4zM16%206h4v2h-4zM0%208h4v2h-4zM8%208h4v2h-4zM16%208h4v2h-4zM0%2010h20v2h-20zM0%2012h4v2h-4zM6%2012h2v2h-2zM12%2012h2v2h-2zM16%2012h4v2h-4zM0%2014h6v2h-6zM14%2014h6v2h-6zM0%2016h8v2h-8zM12%2016h8v2h-8zM0%2018h20v2h-20zM0%2020h8v2h-8zM12%2020h8v2h-8zM2%2022h4v2h-4zM14%2022h4v2h-4z'%20fill='%23575279'/%3e%3cpath%20d='M8%2014h4v2h-4zM8%2016h4v2h-4z'%20fill='%23b4637a'/%3e%3c/g%3e%3c/svg%3e",
      "ghostLinkDisplay": "flex",
      "ghostLinkHeight": 24,
      "ghostImgHeight": 24,
      "ghostVerticalOffsetInLink": 0,
      "themeNamesShown": [
        "rose-pine-dawn"
      ]
    },
    "focus": {
      "activeClass": "ws-status-line__theme",
      "accessibleText": "Switch theme, now rose-pinerose-pine-dawn",
      "focusVisible": true,
      "outline": "solid"
    },
    "focusAfterSecondToggle": "ws-status-line__theme",
    "errors": []
  }
}
  • Outcome: 🔧 3 issues found → auto-fixed ✅ across 2 runs (13m26s)

Pipeline

Updates from git push no-mistakes

✅ **Intent** - passed

✅ No issues found.

✅ **Rebase** - passed

✅ No issues found.

🔧 **Review** - 2 issues found → auto-fixed ✅
  • ⚠️ vue-event-registration/src/ui/CodeBlock.vue:9 - Simplification: this change adds a new way of loading Shiki in the Vue app. A module-level dynamic import(&#39;./highlight&#39;) (CodeBlock.vue:9-15), a plain-text fallback plain() (CodeBlock.vue:17-20), a shallowRef swap once the chunk arrives (CodeBlock.vue:36-41), and a .catch(() =&gt; undefined) that hides a failed chunk load. The intent does not call for any of this. It asks to switch both apps to design-system 0.6.1 and remove the workarounds the system now covers. Importing Shiki eagerly was never a design-system workaround; lazy loading is an optimization the 0.6.1 usage guide suggests. It also changes what users see: the submitted JSON now appears as plain text first and gains its colors later, and if the chunk fails to load it stays plain with no error. The React version of this path has an e2e test (react-checkout/e2e/checkout.spec.ts:115); the new Vue path has none. Recommended fix: drop it from this change and keep the synchronous import { highlightJson } from &#39;./highlight&#39;, keeping only the ws-code--wrap / .line / --ws-code-hang markup change. If you want lazy loading in Vue, it belongs in its own change.
  • ℹ️ react-checkout/src/styles.css:80 - Leftover workaround the system already covers: .ws-tab-bar__end .tab-bar__ghost { display: flex; } is all that remains of the old ghost rule, and design-system 0.6.1 terminal.css already sets .ws-tab-bar__end a { display: flex; align-items: center; } on the same &lt;a&gt; at every width (no narrow-screen override). The rule has no effect. Remove it in both places: react-checkout/src/styles.css:80-82 and vue-event-registration/src/styles.css:82-84. The tab-bar__ghost class then has no styles and can go from the ghost link too: react-checkout/src/ui/TabBar.tsx:37 and vue-event-registration/src/ui/TabBar.vue:34.

🔧 Fix applied.
✅ Re-checked - no issues remain.

🔧 **Test** - 3 issues found → auto-fixed ✅
  • ⚠️ vue-event-registration/src/ui/CodeBlock.vue:9 - The review round 1 decision says the user chose to fix 'vue-lazy-shiki-out-of-scope'. That finding's recommended fix was to drop the module-level dynamic import('./highlight'), the plain() fallback and the shallowRef swap, and go back to the synchronous import { highlightJson } from &#39;./highlight&#39;. The fix commit 73fed5e ('test Vue lazy Shiki') kept the lazy path and added two e2e tests for it (registration.spec.ts:206 and :236). Both tests pass, and the behavior works: plain text first, colors once the chunk loads, plain text with no errors if the chunk fails. But the change still has the out-of-scope lazy loading the user chose to remove. This test phase did not revert it, because that would override how the fixer resolved the decision. Please confirm whether the lazy path should be dropped as the decision says, or kept with its new tests.
  • ℹ️ vue-event-registration/src/ui/SummaryList.vue:19 - On the Vue Confirm step, each section is its own <dl class="ws-pairs">, and ws-pairs sizes its term column per list (fit-content(40%)). So values no longer line up between sections. At 1280 px, 'About you' values start at x=340 and 'Your visit' values at x=508 (vue-desktop-light-3-confirm-summary.png). Before this change, the local 2fr/3fr rows lined every section up at the same column. Fixing it would mean either a local override, which is a workaround the intent asks to remove, or a design-system change such as sharing columns across lists. That is a design call.
  • ℹ️ vue-event-registration/src/ui/SummaryList.vue:22 - At 320 px, the Confirm step breaks the email value mid-word as 'marko@example.co' / 'm' (vue-narrow-320-dark-2-confirm-summary.png). This was already there before this change: with the base's 2fr/3fr columns the cell is 148 px instead of 162 px and still wraps to 2 lines. The 0.6.1 usage guide says to put a <wbr /> after the '@' of a long email so it breaks there. SummaryList renders values as plain text, so it doesn't do that. A small follow-up could fix it.
  • Live validation: ✅ go - 9 of 9 scenarios driven live against the product
Scenario Result Live Evidence
Both apps install design-system 0.6.1 and their production builds start (React pnpm build &amp;&amp; pnpm start, Vue pnpm build + vite preview) ✅ pass live design-system package.json version 0.6.1 in both node_modules; react-checkout-e2e.log and vue-event-registration-e2e.log show the webServer build and serve, then the tests run
React shopper places an order end-to-end (summary updates, server confirms, highlighted order.json shown) on desktop and Pixel 7 ✅ pass live react-checkout-e2e.log (checkout.spec.ts places an order..., keeps the order button faint..., speaks German...); react-desktop-light-4-done-code.png
Vue attendee registers step by step and sees the submitted JSON, on desktop and Pixel 7 ✅ pass live vue-event-registration-e2e.log (registers a business attendee with guests...); vue-desktop-dark-4-done-code.png
Theme switch: in each theme exactly one cut of the tab bar mark, the ghost and the theme name shows; switching with Enter on the status line theme button keeps the focus there ✅ pass live react-checks.json / vue-checks.json keyboard-theme-focus: marksShown 1, ghostsShown 1, themeNamesShown [rose-pine] then [rose-pine-dawn], activeElement ws-status-line__theme, focus-visible ring; *-key…
Ghost link without the removed local rule still lays out as a 24 px flex box with its image flush (adversarial check of the dropped .tab-bar__ghost rule) ✅ pass live react-checks.json / vue-checks.json: ghostLinkDisplay flex, ghostLinkHeight 24, ghostImgHeight 24, offset 0; -desktop--tabbar.png
Narrow screen (320 px) with long values: status line stays whole, the code block wraps long lines inside itself with a hanging indent, nothing scrolls sideways ✅ pass live react/vue-checks.json narrow-320-dark-long: overflow 0 for html/.page/.page__main/.ws-status-line/.ws-code/pre; wrapped lines with padding-left = -text-indent; react-narrow-320-dark-codeblock.png, vue…
Vue registration JSON shows as plain text until the Shiki chunk loads, then in color; it stays plain with no page error when the chunk is blocked (adversarial) ✅ pass live vue-event-registration-e2e.log: registration.spec.ts:206 and :236 passed on desktop and mobile (route holds or aborts assets/highlight-*.js on the prod build)
React order JSON stays plain text when its highlighter chunk is blocked (adversarial) ✅ pass live react-checkout-e2e.log: checkout.spec.ts:115 passed on desktop and mobile
Design-system ticks, step circles and pairs replace the local workarounds and render correctly in both themes (checked box, done step, ws-pairs summary) ✅ pass live vue-tick-checks.json (tick 16px in a 20px box / 24px circle); vue-zoom-light-checked-box.png, vue-zoom-light-steps.png; react-desktop-dark-2-summary.png; vue-desktop-light-3-confirm-summary.png
  • cd react-checkout &amp;&amp; pnpm exec playwright test (runs pnpm build &amp;&amp; pnpm start, desktop + Pixel 7 projects): 45 passed, 1 skipped by design (key hints only show on a wide screen)
  • cd vue-event-registration &amp;&amp; pnpm exec playwright test (runs pnpm build then vite preview, desktop + Pixel 7): 29 passed, 1 skipped by design. Includes the new lazy-Shiki loads-later and chunk-fails tests
  • Checked the installed design-system package.json in both apps' node_modules: version 0.6.1
  • node shots.mjs react http://localhost:4374 ...: screenshots and computed-style checks of the React prod server (dark and light at 1280 px, dark at 320 px with long values, Enter on the theme button with the keyboard)
  • node shots.mjs vue http://localhost:4373 ...: the same pass for the Vue prod server (step indicator, Confirm summary, registration code block)
  • node tick.mjs ...: 3x zoom screenshots and computed styles of the --ws-icon-check tick on a checked box and on a done step, in both themes
  • Measured the Vue Confirm-step email row at 320 px with the new ws-pairs columns and with the base's 2fr/3fr rule injected, to see whether the mid-word email break is new

🔧 Fix applied.
✅ Re-checked - no issues remain.

  • Live validation: ✅ go - 7 of 7 scenarios driven live against the product
Scenario Result Live Evidence
Both apps build and run on design-system 0.6.1: production builds of the Vue and React apps pass their e2e suites (desktop + Pixel 7) ✅ pass live vue-event-registration-e2e.log (29 passed, EXIT=0); react-checkout-e2e.log (45 passed, EXIT=0); installed design-system package.json version 0.6.1 in both apps
Vue Confirm at 320 px: a user who typed marko@example.com sees it break after the @ ('marko@' / 'example.com'), not mid-word ✅ pass live vue-narrow-320-short-email-dark-confirm.png, vue-narrow-320-short-email-light-confirm.png, vue-email-wrap-check.json; e2e registration.spec.ts:424 '320 px ... fits the screen at every step' passed on…
Regression: the same Vue Confirm flow at 320 px on a build without the fix breaks the email mid-word ('marko@example.co' / 'm') ✅ pass live before-email-fix/vue-email-wrap-check.json, before-email-fix/vue-narrow-320-short-email-dark-confirm.png
Adversarial: a very long email and a slash-separated value on the Vue Confirm step at 320 px stay inside the screen, and the text a user copies or a screen reader reads is exactly what was typed ✅ pass live vue-narrow-320-long-email-light-confirm.png, vue-email-wrap-check.json (textContent and innerText equal the input; aria snapshot 'definition: aleksandra.konstantinovic@events.example.co.rs'; sideways…
Tab bar and ghost logo on 0.6.1: each theme shows exactly one mark and one ghost, colored for that theme and vertically aligned, in both apps ✅ pass live vue-checks.json / react-checks.json (marksShown 1, ghostsShown 1, ghost fill e0def4 in dark and 575279 in light, ghost link display flex, offset 0); vue-desktop-dark-1-start.png, react-desktop-light-1…
Status line on 0.6.1: Enter on the theme button switches dark to light and back, shows one theme name, swaps the ghost and keeps focus, in both apps ✅ pass live vue-keyboard-theme-focus-statusline.png, react-keyboard-theme-focus-statusline.png, *-checks.json keyboard-theme-focus (rose-pine to rose-pine-dawn, focus-visible solid outline, focus stays on ws-stat…
Code block on 0.6.1: after submitting, the JSON is syntax-highlighted and long values wrap with a hanging indent inside the block at 320 px, with no sideways scroll, in both apps ✅ pass live vue-narrow-320-dark-3-done-code.png, react-narrow-320-dark-codeblock.png, -desktop--codeblock.png; *-checks.json (5 code colors, overflow 0 for html/.page/.ws-code/pre, wrapped lines present, JSON p…
  • cd vue-event-registration &amp;&amp; pnpm exec playwright test --reporter=list (runs pnpm build &amp;&amp; vite preview as its webServer; desktop + Pixel 7 projects): 29 passed, 1 intentional mobile skip, EXIT=0
  • cd react-checkout &amp;&amp; pnpm exec playwright test --reporter=list (runs pnpm build &amp;&amp; pnpm start; desktop + Pixel 7): 45 passed, 1 intentional mobile skip, EXIT=0
  • Served both production builds (vite preview --port 4373, PORT=4374 pnpm start) and ran node shots.mjs vue|react &lt;url&gt; in Chromium: screenshots and computed checks at 1280 px dark/light and 320 px dark with long values, plus keyboard theme toggling
  • node email-wrap.mjs http://localhost:4373: Vue Confirm step with a short and a long email plus a slash-separated textarea value, at 320 px and 1280 px in dark and light; records the text on each drawn line, textContent, innerText, the aria snapshot, sideways scroll and console errors
  • Regression check: built the Vue app with the pre-fix SummaryList.vue from 73fed5e into a temporary outDir, served it on port 4375 and ran the same email-wrap.mjs: the short email breaks mid-word as marko@example.co / m
  • Read installed node_modules/@whatsaaaa/design-system/package.json in both apps: version 0.6.1
✅ **Document** - passed

✅ No issues found.

✅ **Lint** - passed

✅ No issues found.

✅ **Push** - passed

✅ No issues found.

…unds

Upgrade @whatsaaaa/design-system to ^0.6.1 in vue-event-registration and
react-checkout, and replace what each app drew for itself with the
system's pieces, the same in both apps:

- per-theme marks and the ghost: ws-theme-dark / ws-theme-light, and the
  kit's ghost-on-dark.svg / ghost-on-light.svg in place of ghostSvg()
  through v-html / dangerouslySetInnerHTML
- status line: ws-status-line__path and one ws-status-line__theme button,
  without the local container query, focus offsets, key hint padding and
  corner ring
- --ws-size-control, --ws-size-check and --ws-size-step in place of space
  tokens used as sizes, and --ws-icon-check in place of the local tick
- --ws-color-interactive-hover / -active in place of the color-mix hover
- ws-code--wrap with --ws-code-hang in place of the local wrapping code
  block, and ws-visually-hidden in place of the local class
- Vue: the review list is ws-pairs; Shiki loads lazily, as in React and
  as the usage guide now says for code off the first screen
- React: the language switch is ws-segmented, the order summary
  ws-pairs ws-pairs--amounts, and base.css hides the spin buttons
@whatsaaaa
whatsaaaa merged commit 0d46d38 into main Nov 15, 2026
2 checks passed
@whatsaaaa
whatsaaaa deleted the fm/ds-adopt-020 branch November 15, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant