Repository navigation
fix: adopt @whatsaaaa/design-system 0.6.1 and drop covered workarounds - #4
Merged
Merged
Conversation
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Context. whatsaaaa.github.io, the personal landing page, was built on
@whatsaaaa/design-system0.1.0, one of its first real consumers. Where the system lacked something, the site built a local workaround and recorded it. Those findings went back to the design system, which has since covered them: 0.5.0 and 0.6.0 added the theme and status line fixes and the missing pieces, and 0.6.1 (published 2026-11-15) the docs and small fixes.Once the design system's docs-and-fixes change merged and the release carrying it was published, switch the website to that release and remove the workarounds the system now covers.
What Changed
@whatsaaaa/design-systemfrom^0.1.0to^0.6.1inpackage.jsonand the lockfile, and moves the transitivepostcss-selector-parserfrom the deprecated 7.2.0 to 7.2.1.ws-status-line__themebutton that shows the name of the active theme. The path wrapper becomesws-status-line__path, so the local container-query styles are gone. InBase.astro, the inlinetheme-colormeta tags, their MutationObserver script and the focus-keeping toggle handler are removed, andthemeInitScriptnow colors the browser's own bars. Theme switch clicks now call onlytoggleTheme()..ws-statedot baseline inEntry.astro. TheGhostcomponent gets acompactPxprop, passed tows-ghostascompact-px. The landing page usescompactPx={4}in place of its own sprite sizing for screens below 64rem. Its role line now uses the--ws-text-taglineand--ws-text-tagline-compacttype tokens in place of hand-set font sizes.🤖 Generated with Claude Code
Workarounds still needed
0.6.1 does not cover these, so the site keeps them:
form-builder.mdwould be cut to about five characters. With it, every status line item is exactly as wide as on main.cat ~/projects/<name>.mdprompt on detail pages, notws-crumb. 0.6.1 documents the crumb, but the guide does not require it, and switching would be a restyle.minimumReleaseAgeExclude: ['@whatsaaaa/design-system']stays, because 0.6.1 was published on 2026-11-15.Visible changes
Screenshots of the home page and
/projects/form-builder/on main and on this branch, in both themes, at 320, 390 and 1440 px, compared pixel by pixel:whoamighost fromcompact-px="4"is pixel-identical.theme-colortag (see below).Design-system follow-ups
Gaps in the system, left as gaps rather than new local workarounds:
theme-colorwithout JavaScript. Following 0.6.1 ("the head needs no tag of its own"), the served HTML has notheme-colortag; the head script adds it at runtime. Visitors with JavaScript off, and link unfurlers that read the raw HTML (such as Discord's embed stripe), get no theme color. The review gate accepted this as a gap of the design system.2ch + 1.75rem).Also in this PR:
postcss-selector-parser, a dev dependency ofeslint-plugin-astro, goes from 7.2.0 to 7.2.1 in the lockfile only. pnpm warned that 7.2.0 is deprecated.Risk Assessment
✅ Low: A bounded dependency bump plus removal of local CSS/JS workarounds. Each removed one has an equivalent rule or behavior in the published 0.6.1 package: state baseline, prompt chevron, focus offsets for tabs and keys, status-line path container query, the single theme button with visually-hidden label, ghost compact-px, tagline tokens, and theme-color script. Lockfile integrity hashes match the registry.
Testing
I built and served the 0.6.1 site and the base commit (0.1.0 plus workarounds) side by side, then drove both in headless Chrome. All checks passed: the theme button (click, keyboard, keeping focus, accessible name, phone width, JavaScript off), the browser bar color following both hand-picked and system themes, the status line path at every width from 260 to 560px, focus rings, ghost size, prompt wrapping, and all 10 pages loading without errors. I compared each removed workaround against the base in target/base screenshots, then stopped the preview servers and deleted the temporary build folders.
pnpm buildbuilt 10 pages; S7-all-pages in results.json (10 routes, no errors); s7-project-page-dark.pngtshortcut still worksEvidence: Driver results (all checks, with measured values)
Evidence: Driver console output
Evidence: Playwright driver script
Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
src/layouts/Base.astro:43- The served HTML no longer has a<meta name="theme-color">. The base version rendered two static tags, one per theme, with media queries and hex colors from the tokens resolver. Now the design system's head script creates the tag at runtime, on the first animation frame (dist/theme/color.js). For JS-enabled browsers this is covered: the tag is set before first paint and followsdata-theme, the class, and system changes, which is the reason for the removal. Two consumers that don't run the script lose the color: visitors with JS disabled, and link unfurlers that read theme-color from the raw HTML (Discord, for example, uses it for the embed's side stripe). This follows the 0.6.1 usage docs ("the head needs no tag of its own and no color in it"), so it is a deliberate tradeoff. The only remedy would be keeping static tags with resolver-derived colors, which brings back part of the removed workaround. Confirm whether losing the no-JS/unfurl color is acceptable.✅ **Test** - passed
✅ No issues found.
pnpm buildbuilt 10 pages; S7-all-pages in results.json (10 routes, no errors); s7-project-page-dark.pngtshortcut still workspnpm install --frozen-lockfile(resolves @whatsaaaa/design-system 0.6.1) andpnpm build: 10 pages builtBase commit 5ee1238 rebuilt in a temporary folder (git archive+pnpm install --frozen-lockfile+pnpm build, exit 0) for a side-by-side comparisonastro previewon 127.0.0.1:4401 (target) and 127.0.0.1:4402 (base)node drive.mjs(Playwright + Chrome for Testing 1254): 12 checks across 8 scenario groups, 0 failures, exit 0Theme button: Tab to it, Enter, Space, thetshortcut, a reload, and a tap at 375px, checking data-theme, localStorage, which name shows, where the focus is, and the accessible nametheme-color: no static tag in the served HTML; system dark and light with no choice; the system theme changing while the page is open; a stored light theme on a dark system resisting a system changeJavaScript disabled with dark and light system themes: the theme button shows the right nameStatus line path sweep from 260 to 560px in 4px steps on target and base: ellipsis, hiding whole, overflow, and the theme button staying insideFocus rings via Tab on a tab, a key hint, the keys switch and the theme button: outline-offset equals the negative outline width, with crops from target and baseGhost sprite size at 1280, 1024, 1023 and 375px; tagline computed font on target and baseWrapped prompt (long text injected in the test browser) and Entry state dot: target vs base screenshotsAll 10 routes: status line, theme button, path and a single theme-color tag present, no console or page errorsnode montage.mjs: combined target and base screenshots into the compare-*.png images✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.