Skip to content

test(jobs): widen terminal-job wait for loaded CI runners #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willgriffin merged 1 commit into from
Oct 29, 2026
+7 −2
Merged

test(jobs): widen terminal-job wait for loaded CI runners #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions apps/site/src/lib/server/job-workspace-runner.integration.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,10 @@ function twoJobBarrier(): () => Promise<void> {
};
}

// Ceiling only: the wait resolves as soon as the job reaches a terminal event,
// so the generous budget costs nothing locally but survives a loaded CI runner.
const TERMINAL_JOB_BUDGET_MS = 25_000;

async function waitForTerminalJob(
runner: TaskRunner,
jobId: string,
Expand All @@ -176,7 +180,7 @@ async function waitForTerminalJob(
timeout = setTimeout(() => {
cleanup();
reject(new Error(`Timed out waiting for queued job ${jobId}.`));
}, 3_000);
}, TERMINAL_JOB_BUDGET_MS);
},
(error) => {
cleanup();
Expand Down Expand Up @@ -205,7 +209,8 @@ async function waitForTerminalJob(
}

describe('TaskRunner workspace-subject dispatch (SQLite)', {
timeout: 20_000,
// 10s native startup handshake + terminal wait budget + headroom.
timeout: 45_000,
}, () => {
let database: DatabaseInterface | undefined;
let directory: string | undefined;
Expand Down
Loading