Repository navigation
test(jobs): widen terminal-job wait for loaded CI runners - #277
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #276
The 3s terminal wait in
waitForTerminalJob(job-workspace-runner.integration.spec.ts) timed out on the loaded shared runner (suite takes 11-15 min there), failing main CI on the permission-fence case.TERMINAL_JOB_BUDGET_MS). It resolves on the firstjob:completed/job:failedevent for the job, and listeners are attached beforerunner.start(), so a job finishing early is never missed and local speed is unchanged.Validation: spec 15/15; root
pnpm format-check,lint,check,test,build,knowledge:checkall green.Review-cycle: standard risk, one balanced reviewer (codex-sol), CLEAN after evidence continuation.