Repository navigation
Show "Keep only this" only when it changes something - #17
Merged
Merged
Conversation
It is hidden on the copy that is already the only one kept (its space is kept, so rows stay aligned, and it is not focusable). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EgB2BE6SAL3zHCu6oLk3Tw
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
🟢 Approval recommended
The focused visibility change matches the intended behavior, with no unresolved findings.
No open issues 🎉
What changed in this PR
Hides “Keep only this” when a bookmark is already the only kept copy in its duplicate group.
Changes:
- Updates button visibility whenever the selection changes.
- Preserves row alignment and prevents hidden buttons from receiving focus.
| File | Description |
|---|---|
| tab-duplicates.js | Tracks each row’s group and toggles button visibility. |
| style.css | Hides redundant buttons while preserving their space. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Keep only this" appeared on hover on every copy, including the one that is already the only copy kept, where it does nothing.
It is now hidden (
visibility: hidden, so rows stay aligned and the button is not focusable) on a copy that is kept while all the other copies of its group are selected for deletion. It is shown on every other copy, and the state updates with each selection change.Checked in Chromium with a 3-copy group:
The 21-check duplicates UI run still passes.
Generated by Claude Code