web(837): converge theme residue — badge, card action, placeholders, review tokens - #839
Merged
Merged
Conversation
…review tokens Board card primary actions ride Button brand (spot) like every other primary app-wide; the neutral default was the single outlier and painted near-black in light theme. Sidebar attention badge moves from bg-primary to badge-attention with a new badge-attention-fg digit token (8.26 both themes). Input placeholders and the repo-picker placeholder row move from text-dim (light 2.14:1) to text-tertiary (light 6.47:1), matching the resources search precedent. Review-face danger/amber stops using undefined --color-* vars with raw fallbacks and rides --destructive, --badge-attention and --danger-soft. closes #837
This was referenced Oct 4, 2026
xiechimon
added a commit
that referenced
this pull request
Oct 4, 2026
…842) The drive-project-new-form probe still expected the pre-theme-flip indigo focus edge while the form renders the spot-system --focus-ring. Point FOCUS_RING at dark rgb(203,166,247) and, as same-cause residue from #839, DANGER at dark destructive rgb(224,90,90); sync the feature map entries and rename the focus screenshot to 03-focus-ring-spot. closes #840
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Theme residue convergence for #837: every primary action now rides the
brand spot, the attention badge reads orange, placeholders clear 4.5 in
both themes, and the review face stops using undefined color vars.
Deliberately untouched: machine dot (status semantics, verified), mention
type hues (category encoding), external logo fills.
Evidence
After-state on a scratch stack (server :8795 → web :5277), same sweep
script before/after; rendered pairs in
docs/verify/837/contrast-837.txt.Checks:
pnpm lintexit 0;pnpm typecheckgreen on all four packages;e2e:affected767 passed, 0 failed (E2E_PORT=8410).Merge Danger
Door: two-way — token/alias swaps on face-owned selectors, no behavior
change; revert is one commit.
Blast Radius: board card button, sidebar badge, six placeholder rules,
five review-face declarations. No shared component API change (one additive
token
--badge-attention-fg).