Conversation
The PNG files were committed as regular blobs, not LFS pointers, causing 'should have been pointers' warnings on clone. Since these are small files, removing LFS tracking is the simplest fix. Fixes #18
The path calculation had one extra .parent call, resolving to the filesystem root instead of /app. This caused PermissionError in Docker where the container runs as non-root user. Fixes #19
Qodana for Python170 new problems were found
☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes two small but important changes related to repository configuration and the SSH key management logic.
Repository configuration:
.pngfiles from.gitattributes, meaning.pngfiles will no longer be tracked using Git LFS.Key management logic:
KeyManagerclass (backend/openmlr/keys/manager.py) to be one level higher, making the path more consistent with the project structure.