Skip to content

Fixes for git cloning and docker run issues #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xprilion merged 2 commits into from
Apr 27, 2026
Merged

Fixes for git cloning and docker run issues #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e971857
Remove LFS tracking for PNG files
xprilion Apr 27, 2026
4281caf
Fix KeyManager path to use /app/.keys instead of /.keys
xprilion Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitattributes
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion backend/openmlr/keys/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"""Manages SSH private keys stored in a dedicated directory."""

def __init__(self, keys_dir: str | Path = None):
self.keys_dir = Path(keys_dir) if keys_dir else Path(__file__).parent.parent.parent.parent.parent / ".keys"
self.keys_dir = Path(keys_dir) if keys_dir else Path(__file__).parent.parent.parent.parent / ".keys"
self._ensure_dir()

def _ensure_dir(self) -> None:
Expand Down Expand Up @@ -115,7 +115,7 @@

return key_path, pub_path

def validate_key(self, private_key_pem: str | bytes) -> dict:

Check notice on line 118 in backend/openmlr/keys/manager.py

View workflow job for this annotation

GitHub Actions / Qodana for Python

Method is not declared static 

Method `validate_key` may be 'static'
"""Validate an SSH private key and return metadata."""
if isinstance(private_key_pem, str):
private_key_pem = private_key_pem.encode("utf-8")
Expand All @@ -123,7 +123,7 @@
# Try to load as OpenSSH format
try:
key = crypto_serialization.load_ssh_private_key(private_key_pem, password=None)
except Exception:

Check notice on line 126 in backend/openmlr/keys/manager.py

View workflow job for this annotation

GitHub Actions / Qodana for Python

Unclear exception clauses 

Too broad exception clause
# Try PEM format
try:
key = crypto_serialization.load_pem_private_key(private_key_pem, password=None)
Expand Down
Loading