fix: project loop missing partial / update project single pluralization#31
Merged
Conversation
|
Coverage report for commit: 6432cb5 Summary - Lines: 78.72% | Methods: 22.22%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project templates to (1) fix the FacetWP project loop “no results” rendering by switching to the shared no-results component, and (2) adjust pluralization/accessibility in the single project view.
Changes:
- Replace a missing FacetWP “no results” partial include with the existing
<x-facetwp.no-results />component. - Update pluralization logic for “Deelproject(en)” and “Gerelateerd(e) project(en)” headings on the single project template.
- Mark a decorative arrow icon as hidden from assistive technology via
aria-hidden="true".
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| stubs/resources/views/single-project.blade.php | Adjusts pluralized headings and adds aria-hidden to a decorative icon; introduces an HTML validity issue and mixes WP/Laravel i18n APIs. |
| stubs/resources/views/blocks/FacetWP/loops/project-loop.blade.php | Switches “no results” rendering from a missing include to the shared no-results component. |
Comments suppressed due to low confidence (1)
stubs/resources/views/single-project.blade.php:54
- Same issue as above: trans_choice() is being combined with WordPress __() for pluralization, which can bypass WP’s plural translation handling. Consider using _n() with the count and 'sage' textdomain (or separate singular/plural __() calls) for related projects as well.
@if ($postData->related()->isNotEmpty())
<h2 class="alignwide">
{{ trans_choice(__('Gerelateerd project|Gerelateerde projecten', 'sage'), $postData->related()->count()) }}
</h2>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
WybeBosch
previously approved these changes
May 21, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
YvetteNikolov
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.