Skip to content

fix: project loop missing partial / update project single pluralization#31

Merged
Yannicvanveen merged 3 commits into
mainfrom
feat/project-fixes
May 21, 2026
Merged

fix: project loop missing partial / update project single pluralization#31
Yannicvanveen merged 3 commits into
mainfrom
feat/project-fixes

Conversation

@Yannicvanveen
Copy link
Copy Markdown
Contributor

No description provided.

@Yannicvanveen Yannicvanveen requested a review from a team as a code owner May 21, 2026 11:53
Copilot AI review requested due to automatic review settings May 21, 2026 11:53
@Yannicvanveen Yannicvanveen requested a review from a team as a code owner May 21, 2026 11:53
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Coverage report for commit: 6432cb5
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 75.0%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ ████░░░░░░░░░░░░░░░░░░░ │ 12.5%
 100% │ ████░░░░░░░░░░░░░░░░░░░ │ 12.5%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 78.72% | Methods: 22.22%
FilesLinesMethodsBranches
src/Console
   ChildThemeScaffoldCommand.php87.50%-100.00%
   ElasticsearchScaffoldCommand.php--100.00%
   EventScaffoldCommand.php--100.00%
   KnowledgebaseScaffoldCommand.php--100.00%
   NewsScaffoldCommand.php--100.00%
   PersonScaffoldCommand.php--100.00%
   ProjectScaffoldCommand.php--100.00%
src
   ScaffoldServiceProvider.php100.00%100.00%100.00%

🤖 comment via lucassabreu/comment-coverage-clover

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project templates to (1) fix the FacetWP project loop “no results” rendering by switching to the shared no-results component, and (2) adjust pluralization/accessibility in the single project view.

Changes:

  • Replace a missing FacetWP “no results” partial include with the existing <x-facetwp.no-results /> component.
  • Update pluralization logic for “Deelproject(en)” and “Gerelateerd(e) project(en)” headings on the single project template.
  • Mark a decorative arrow icon as hidden from assistive technology via aria-hidden="true".

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
stubs/resources/views/single-project.blade.php Adjusts pluralized headings and adds aria-hidden to a decorative icon; introduces an HTML validity issue and mixes WP/Laravel i18n APIs.
stubs/resources/views/blocks/FacetWP/loops/project-loop.blade.php Switches “no results” rendering from a missing include to the shared no-results component.
Comments suppressed due to low confidence (1)

stubs/resources/views/single-project.blade.php:54

  • Same issue as above: trans_choice() is being combined with WordPress __() for pluralization, which can bypass WP’s plural translation handling. Consider using _n() with the count and 'sage' textdomain (or separate singular/plural __() calls) for related projects as well.
		@if ($postData->related()->isNotEmpty())
			<h2 class="alignwide">
				{{ trans_choice(__('Gerelateerd project|Gerelateerde projecten', 'sage'), $postData->related()->count()) }}
			</h2>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread stubs/resources/views/single-project.blade.php Outdated
Comment thread stubs/resources/views/single-project.blade.php Outdated
WybeBosch
WybeBosch previously approved these changes May 21, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Yannicvanveen Yannicvanveen merged commit 204ef03 into main May 21, 2026
5 checks passed
@Yannicvanveen Yannicvanveen deleted the feat/project-fixes branch May 21, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants