Skip to content

fix: project loop missing partial / update project single pluralization #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yannicvanveen merged 3 commits into from
May 21, 2026
Merged

fix: project loop missing partial / update project single pluralization #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3991fad
fix: project loop missing partial / update project single pluralization
Yannicvanveen May 21, 2026
4c5fad3
Fix duplicate h2 closing tag
Yannicvanveen May 21, 2026
6432cb5
fix: use correct func for pluralization
Yannicvanveen May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stubs/resources/views/blocks/FacetWP/loops/project-loop.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
@forelse ($postDataCollection as $postData)
<x-card.project :postData="$postData" :direction="Direction::FLUID" />
@empty
@include('blocks.FacetWP.partials.no-results')
<x-facetwp.no-results />
@endforelse
</div>
9 changes: 3 additions & 6 deletions stubs/resources/views/single-project.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<div>{{ __('Hoofdproject', 'sage') }}</div>
<a href="#deelprojecten">
{{ __('Naar alle deelprojecten', 'sage') }}
<i class="fa-light fa-arrow-down ml-4"></i>
<i class="fa-light fa-arrow-down ml-4" aria-hidden="true"></i>
</a>
@endif
@if ($postData->isChild() && !$postData->isInformationPost)
Expand All @@ -38,8 +38,7 @@

<x-slot:bottom>
@if ($postData->isParent())
<h2 id="deelprojecten" class="alignwide">
{{ $postData->children()->count() > 1 ? __('Deelprojecten', 'sage') : __('Deelproject', 'sage') }}:</h2>
<h2 id="deelprojecten" class="alignwide">{{ _n('Deelproject', 'Deelprojecten', $postData->children()->count(), 'sage') }}</h2>
<div class="auto-grid container mt-5">
@foreach ($postData->children() as $child)
<x-card.project :postData="$child" />
Expand All @@ -48,9 +47,7 @@
@endif

@if ($postData->related()->isNotEmpty())
<h2 class="alignwide">
{{ $postData->related()->count() > 1 ? __('Gerelateerde projecten', 'sage') : __('Gerelateerd project', 'sage') }}
</h2>
<h2 class="alignwide">{{ _n('Gerelateerd project', 'Gerelateerde projecten', $postData->related()->count(), 'sage') }}</h2>
<div class="auto-grid container mt-5">
@foreach ($postData->related() as $related)
<x-card.project :postData="$related" />
Expand Down
Loading