Skip to content

Journalled Device Server: handle backend exceptions#6553

Open
sharpeye wants to merge 1 commit into
mainfrom
users/sharpeye/jd-handle-backend-exceptions
Open

Journalled Device Server: handle backend exceptions#6553
sharpeye wants to merge 1 commit into
mainfrom
users/sharpeye/jd-handle-backend-exceptions

Conversation

@sharpeye

@sharpeye sharpeye commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Handle exceptions thrown by the Journalled Device backend while processing requests.

Previously, a synchronous backend exception escaped the request-handling path and was treated as a protocol-level failure. The server now catches such exceptions, converts them into failed futures, and returns them to the client as request errors.

@sharpeye sharpeye added tsan Launch builds with thread sanitizer along with regular build storage Add this label to run tests only from cloud/storage/ directory labels Jul 17, 2026
@sharpeye sharpeye changed the title Journalled Devices server: handle backend exceptions Journalled Device Server: handle backend exceptions Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/storage/ (test time: 59s): all tests PASSED for commit 096f165.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
840 840 0 0 0 0 0

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-tsan have completed.

Tip

Planned checks for linux-x86_64-release-tsan.

🟢 linux-x86_64-release-tsan target: cloud/storage/ (test time: 106s): all tests PASSED for commit 096f165.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
718 718 0 0 0 0 0

@sharpeye
sharpeye marked this pull request as ready for review July 20, 2026 14:45

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 096f16563f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread cloud/storage/core/libs/journalled_device_tcp_server/server.cpp Outdated
@sharpeye
sharpeye force-pushed the users/sharpeye/jd-handle-backend-exceptions branch from 096f165 to c478f08 Compare July 21, 2026 13:28
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/storage/ (test time: 72s): all tests PASSED for commit c478f08.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
840 840 0 0 0 0 0

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-tsan have completed.

Tip

Planned checks for linux-x86_64-release-tsan.

🟢 linux-x86_64-release-tsan target: cloud/storage/ (test time: 128s): all tests PASSED for commit c478f08.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
718 718 0 0 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

storage Add this label to run tests only from cloud/storage/ directory tsan Launch builds with thread sanitizer along with regular build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants