Skip to content

Journalled Device Server: handle backend exceptions #6553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sharpeye wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Journalled Device Server: handle backend exceptions #6553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
155 changes: 95 additions & 60 deletions cloud/storage/core/libs/journalled_device_tcp_server/server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,63 @@ namespace {

////////////////////////////////////////////////////////////////////////////////

#define STORAGE_JD_SERVER(xxx, ...) \
xxx(AcquireDevices, __VA_ARGS__) \
xxx(ReleaseDevices, __VA_ARGS__) \
xxx(ReadPages, __VA_ARGS__) \
xxx(WriteLogRecord, __VA_ARGS__)

// STORAGE_JD_SERVER

template <
typename TProtoRequest,
typename TProtoResponse,
TFuture<TProtoResponse> (IServerBackend::*M)(TInstant, TProtoRequest),
TProtoRequest* (NProto::TDeviceProtocolRequest::*F1)(),
TProtoResponse* (NProto::TDeviceProtocolResponse::*F2)()>
struct TServerMethod
{
using TRequest = TProtoRequest;
using TResponse = TProtoResponse;

static auto Execute(
IServerBackend& backend,
TInstant now,
TRequest&& request) -> TFuture<TResponse>
{
return (backend.*M)(now, std::move(request));
}

static auto MutableProto(NProto::TDeviceProtocolRequest& request)
-> TRequest&
{
return *(request.*F1)();
}

static auto MutableProto(NProto::TDeviceProtocolResponse& response)
-> TResponse&
{
return *(response.*F2)();
}
};

#define STORAGE_DECLARE_METHOD(name, ...) \
struct T##name##Method \
: TServerMethod< \
NProto::T##name##Request, \
NProto::T##name##Response, \
&IServerBackend::name, \
&NProto::TDeviceProtocolRequest::Mutable##name, \
&NProto::TDeviceProtocolResponse::Mutable##name> \
{ \
constexpr static TStringBuf Name = #name; \
}; \
// STORAGE_DECLARE_METHOD

STORAGE_JD_SERVER(STORAGE_DECLARE_METHOD)

////////////////////////////////////////////////////////////////////////////////

struct TConnection
{
TSocketHolder Socket;
Expand Down Expand Up @@ -120,6 +177,40 @@ class TServer final
void HandleRequest(
NProto::TDeviceProtocolRequest& request,
TConnectionPtr conn);

template <typename TMethod>
void ProcessRequest(
TConnectionPtr conn,
NProto::TDeviceProtocolRequest&& request)
{
using TResponse = typename TMethod::TResponse;

TFuture<TResponse> future;

const ui64 requestId = request.GetRequestId();

try {
auto& proto = TMethod::MutableProto(request);

future = TMethod::Execute(*Backend, Now(), std::move(proto));
} catch (...) {
STORAGE_ERROR(
TMethod::Name << " failed: " << CurrentExceptionMessage());

future = MakeErrorFuture<TResponse>(std::current_exception());
}

future.Subscribe(
[conn, requestId](const auto& future)
{
NProto::TDeviceProtocolResponse response;
response.SetRequestId(requestId);
TMethod::MutableProto(response).CopyFrom(
SafeExecute<TResponse>([&] { return future.GetValue(); }));

conn->ResponseQueue.Enqueue(std::move(response));
});
}
};

////////////////////////////////////////////////////////////////////////////////
Expand Down Expand Up @@ -314,75 +405,19 @@ void TServer::HandleRequest(

switch (request.GetRequestCase()) {
case ERequestCase::kAcquireDevices: {
auto future = Backend->AcquireDevices(
Now(),
std::move(*request.MutableAcquireDevices()));

future.Subscribe(
[conn, requestId](
const TFuture<NProto::TAcquireDevicesResponse>& future)
{
NProto::TDeviceProtocolResponse response;
response.SetRequestId(requestId);
response.MutableAcquireDevices()->CopyFrom(
future.GetValue());

conn->ResponseQueue.Enqueue(std::move(response));
});

ProcessRequest<TAcquireDevicesMethod>(conn, std::move(request));
break;
}
case ERequestCase::kReleaseDevices: {
auto future = Backend->ReleaseDevices(
Now(),
std::move(*request.MutableReleaseDevices()));

future.Subscribe(
[conn, requestId](
const TFuture<NProto::TReleaseDevicesResponse>& future)
{
NProto::TDeviceProtocolResponse response;
response.SetRequestId(requestId);
response.MutableReleaseDevices()->CopyFrom(
future.GetValue());

conn->ResponseQueue.Enqueue(std::move(response));
});
ProcessRequest<TReleaseDevicesMethod>(conn, std::move(request));
break;
}
case ERequestCase::kReadPages: {
auto future = Backend->ReadPages(
Now(),
std::move(*request.MutableReadPages()));

future.Subscribe(
[conn,
requestId](const TFuture<NProto::TReadPagesResponse>& future)
{
NProto::TDeviceProtocolResponse response;
response.SetRequestId(requestId);
response.MutableReadPages()->CopyFrom(future.GetValue());

conn->ResponseQueue.Enqueue(std::move(response));
});
ProcessRequest<TReadPagesMethod>(conn, std::move(request));
break;
}
case ERequestCase::kWriteLogRecord: {
auto future = Backend->WriteLogRecord(
Now(),
std::move(*request.MutableWriteLogRecord()));

future.Subscribe(
[conn, requestId](
const TFuture<NProto::TWriteLogRecordResponse>& future)
{
NProto::TDeviceProtocolResponse response;
response.SetRequestId(requestId);
response.MutableWriteLogRecord()->CopyFrom(
future.GetValue());

conn->ResponseQueue.Enqueue(std::move(response));
});
ProcessRequest<TWriteLogRecordMethod>(conn, std::move(request));
break;
}
default: {
Expand Down
Loading
Loading