docs: plan Phase-3 diagnostic signal modeling (with fault-injection hooks) - #4
Merged
Merged
Conversation
…ooks) Queues the modeled diagnostic signals (oilPressure, exhaustTemperature, starter bank, navigation.gnss.*, rateOfTurn) that only aid anomaly detection WITH fault modes. Specs a shared FaultState injection mechanism (env + command path) so demos can trigger the exact anomaly each diagnostic catches, the per-signal nominal model + fault hook, the engine->snapshot->sink->writer wiring (per PR #3), tests, and a value-ordered implementation sequence. Unblocks navigator diagnostics P2/E2/H2/P4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queues the remaining diagnostic signals deliberately deferred from #3 — the modeled ones (
propulsion.main.oilPressure/exhaustTemperature,electrical.batteries.starter.*,navigation.gnss.*,navigation.rateOfTurn) that only aid anomaly detection if they can deviate.Key design: a shared fault-injection hook (
FaultState, settable via env + the existing command path) so the demo can trigger the exact anomaly each diagnostic catches (e.g.raw_water_blocked→ exhaust+coolant rise at steady RPM → engine-overheat-cause). Per-signal nominal model + fault, engine→snapshot→sink→writer wiring (per #3), tests with reproducible fixtures, and a value-ordered sequence (oil/exhaust+raw-water first).Unblocks the navigator diagnostic catalog's Phase-3 rules (P2 engine-overheat cause, E2 charging-fault root-cause, H2 gps-degraded, P4 fouling). Docs-only; nothing deployed.
🤖 Generated with Claude Code