Closed
Code review: GAS translation provider and surrounding infrastructure#3
Conversation
Copilot
AI
changed the title
[WIP] Investigate gas translation failure logs
Code review: GAS translation provider and surrounding infrastructure
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed the GAS translation failure investigation branch. No code defects were found; this PR documents the review outcome.
Findings
GasTranslationProvider: Redirect handling correctly switches POST→GET on 301/302/303 while preserving POST for 307/308, matching GAS/execredirect behavior. BOM and XSSI)]}'prefix stripping innormalizeJsonBodyis correct for Google responses.getString(root, "source")falls back torequest.sourceLanguageHint()(always non-null"") when blank or"auto"— consistent withDeepLTranslationProvider, butdetectedSourceLanguageinTranslationResultmay be empty.ChatglotConfigmodel constants:gpt-5.3-codex,gpt-5-nano,gemini-flash-latest,claude-haiku-4-5appear to be placeholder/future model identifiers — worth validating against live APIs.ChatTranslationActions.exceptionallycorrectly unwrapsCompletionExceptionand posts error text to chat HUD.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.