ci: the macOS zip publishes its checksum beside it - #105
Merged
Merged
Conversation
Each Linux tarball has always had a .sha256 next to it on the release; the macOS zip had none, which is why the macOS installer has to pick its digest out of the release JSON. The release now writes Notary-vX.Y.Z-macos.zip.sha256 in the same format and uploads it with the zip, and the publish check will not lift a draft without it. Switching the installer to read it waits for a release that carries the file, since the installer always reads the latest release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of zig-nostr/plaza#361, which asks for the same change in both repos.
Notary-vX.Y.Z-macos.zip.sha256withshasum -a 256, the same<hash> <name>format the Linux.sha256files use, and both publish branches upload it with the zip.scripts/check-release-assets.shexpects it, so the draft stays hidden if it is missing. New self-test case: a macOS zip without its digest is refused, naming that file.The installer keeps reading the digest from the release JSON for now. It always installs the latest release, so switching it before a release carries this file would break every macOS install. That switch, and deleting the JSON parsing, follow the next Notary release.