Skip to content

ci: the macOS zip publishes its checksum beside it #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sepehr-safari merged 1 commit into from
Sep 25, 2026
Merged

ci: the macOS zip publishes its checksum beside it #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,13 @@ jobs:
- name: Zip the .app (ditto preserves the signature)
run: ditto -c -k --sequesterRsrc --keepParent "gui/dist/Notary.app" "Notary-${{ github.ref_name }}-macos.zip"

# Published beside the zip, the same way each Linux tarball has its
# `.sha256`, so the macOS installer can read the digest of the file it
# downloads by name instead of picking it out of the release JSON, and a
# reader can check a download by hand from the release page.
- name: Write the zip's digest
run: shasum -a 256 "Notary-${{ github.ref_name }}-macos.zip" > "Notary-${{ github.ref_name }}-macos.zip.sha256"

# The tag and the manifest have to agree, and this is the last place it can
# be checked. `gui/app.zon` is where the app reads the version it shows,
# so tagging v0.5.0 on a tree that still says 0.4.0 ships a build that
Expand Down Expand Up @@ -91,13 +98,13 @@ jobs:
if gh release view "$GITHUB_REF_NAME" >/dev/null 2>&1; then
echo "release exists; hiding it and replacing its artifact with the one built here"
gh release edit "$GITHUB_REF_NAME" --draft=true
gh release upload "$GITHUB_REF_NAME" "$asset" --clobber
gh release upload "$GITHUB_REF_NAME" "$asset" "$asset.sha256" --clobber
else
# A DRAFT. The Linux tarballs are built by another job that takes
# minutes longer, and a release published before they arrive is one
# whose Linux installer 404s for exactly as long as that takes. The
# `publish` job below lifts the draft once every artifact is up.
gh release create "$GITHUB_REF_NAME" "$asset" \
gh release create "$GITHUB_REF_NAME" "$asset" "$asset.sha256" \
--draft \
--title "Notary $GITHUB_REF_NAME" \
--notes-file .github/RELEASE_NOTES.md
Expand Down
6 changes: 4 additions & 2 deletions scripts/check-release-assets.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ LINUX_ARCHES="x86_64 aarch64"
# Every file a release of $1 should carry, one per line.
expected() {
local tag="$1" ver="${1#v}" arch
printf '%s\n' "Notary-$tag-macos.zip"
printf '%s\n' "Notary-$tag-macos.zip" "Notary-$tag-macos.zip.sha256"
for arch in $LINUX_ARCHES; do
printf '%s\n' "notary-$ver-linux-$arch.tar.gz" "notary-$ver-linux-$arch.tar.gz.sha256"
done
Expand Down Expand Up @@ -87,7 +87,9 @@ self_test() {
refuses "an unfinished upload" "Notary-v9.9.9-macos.zip" 1 "${full/$from/$to}"
from="x86_64.tar.gz${tab}uploaded${tab}1000" to="x86_64.tar.gz${tab}uploaded${tab}0"
refuses "an empty file" "notary-9.9.9-linux-x86_64.tar.gz" 1 "${full/$from/$to}"
refuses "a release built for another version" "Notary-v9.9.9-macos.zip" 5 \
refuses "a macOS zip without its digest" "Notary-v9.9.9-macos.zip.sha256" 1 \
"$(grep -v 'macos.zip.sha256' <<<"$full")"
refuses "a release built for another version" "Notary-v9.9.9-macos.zip" 6 \
"${full//9.9.9/9.9.8}"

local matrix
Expand Down
Loading